From patchwork Tue Nov 7 09:51:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13448230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B401C4167D for ; Tue, 7 Nov 2023 09:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=44k0rf/BGG8qGklw2vC5oeopj92bIsfMW7Jm8aXx7Hc=; b=z7bwa2icr4c7cz VHQWlyEjvQHiI1U1Ryl9/Udn9uasQhZcY3kmQzgSD8aM/R2yRiGLx2S605c+2ixPFTPSpgeCarQFF GX0lnUeEu8RSscMaffmV+OggO7y4CqUtGUuKEFXFWy02GP/lbrMeFPKguU2nRZ700IhNMB0F++rwN qHQI/VIgdCTn0zaohsGROzIUt1sBz3VDBR8GSlXobFX2z5zRykrzfF8tRBRZQD8jWysL99IFSKRCk VU+IEjGIa48Bf6VeDw7FXgjCERqBnR/4mocI/U93kcvpaUYDQZbm6HqS7uRWoDF4D1vK0UPA6lTi2 pvfcdK9PAiuP6Jcw+QUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Ikp-000xKi-2T; Tue, 07 Nov 2023 09:52:15 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Ikm-000xIs-2K; Tue, 07 Nov 2023 09:52:14 +0000 Received: from umang.jain (unknown [103.251.226.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B477F468; Tue, 7 Nov 2023 10:51:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699350705; bh=992nyrW3qUC6fzmLZft4VuCTg3PrVta5dBlOJYrS35k=; h=From:To:Cc:Subject:Date:From; b=aviGoKyF5NftuZmyd/Nb3WLsScbCXI2DuSnLk+A7qwghnMoQP0LlPrlvGKtgH2dkR VMAoU3XFex629xKg3DDH21wy1WYmKQ+2xBFpNaHfKFEch+H/k7Ucdaw3soEWse2GTg uV0ELuXZZhHwUch5MCgbJuFW8eBgOFi48VUM2j0M= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell , Dave Stevenson , Umang Jain Subject: [PATCH 0/9] staging: vc04_services: Smatch fixes and remove custom logging Date: Tue, 7 Nov 2023 04:51:47 -0500 Message-ID: <20231107095156.365492-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_015212_900808_E8B62B3E X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Patch 1/9 to 3/9 targets the warnings exposed by Smatch analysis. Smatch fixes was sent earlier under "staging: vc04: Smatch analysis fixes", but now I have patches on top of them, I have tied these fixes in this series (so could be merged all at once). This series also removes the vchiq_log_* macro and makes use of dev_dbg() directly. 4/9 is just a drive-by patch to shorten function helper. 5/9 is bug fixup where NULL was passed instead of a struct device pointer 6/9 to 7/9 removes each of the vchiq_log_* respectively. This completes the following TODO item: ``` * Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. ``` Umang Jain (9): staging: vc04_services: vchiq_core: Log through struct vchiq_instance staging: vc04_services: Log using pr_err() when vchiq_state is unset staging: vc04_services: bcm2835-camera: Remove redundant null check staging: vc04_services: Shorten helper function name staging: vc04_services: Do not pass NULL to vchiq_log_error() staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg .../bcm2835-camera/bcm2835-camera.c | 7 +- drivers/staging/vc04_services/interface/TODO | 5 - .../interface/vchiq_arm/vchiq_arm.c | 223 +++++---- .../interface/vchiq_arm/vchiq_connected.c | 8 +- .../interface/vchiq_arm/vchiq_connected.h | 4 +- .../interface/vchiq_arm/vchiq_core.c | 463 ++++++++++-------- .../interface/vchiq_arm/vchiq_core.h | 36 +- .../interface/vchiq_arm/vchiq_dev.c | 112 +++-- 8 files changed, 461 insertions(+), 397 deletions(-) base-commit: d2f51b3516dade79269ff45eae2a7668ae711b25