mbox series

[v2,00/18] mfd: Convert to platform remove callback returning void

Message ID 20231123165627.492259-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series mfd: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König Nov. 23, 2023, 4:56 p.m. UTC
Hello,

this series converts all platform drivers below drivers/mfd to use
.remove_new(). Compared to the traditional .remove() callback
.remove_new() returns no value. This is a good thing because the driver
core doesn't (and cannot) cope for errors during remove. The only effect
of a non-zero return value in .remove() is that the driver core emits a
warning. The device is removed anyhow and an early return from .remove()
usually yields resource leaks and/or use-after-free bugs.

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.

All drivers converted here already returned zero unconditionally in
.remove(), so they are converted here trivially.

Compared to the (implicit) v1[1] I added two review tags and rebased to
today's next/master. Also I failed to Cc: all patches of v1 to lkml.

Best regards
Uwe

[1] https://lore.kernel.org/all/20231106171708.3892347-1-u.kleine-koenig@pengutronix.de

Uwe Kleine-König (18):
  mfd: ab8500-sysctrl: Convert to platform remove callback returning
    void
  mfd: cros_ec_dev: Convert to platform remove callback returning void
  mfd: exynos-lpass: Convert to platform remove callback returning void
  mfd: fsl-imx25-tsadc: Convert to platform remove callback returning
    void
  mfd: hi655x-pmic: Convert to platform remove callback returning void
  mfd: intel-lpss-acpi: Convert to platform remove callback returning
    void
  mfd: kempld-core: Convert to platform remove callback returning void
  mfd: mcp-sa11x0: Convert to platform remove callback returning void
  mfd: mxs-lradc: Convert to platform remove callback returning void
  mfd: omap-usb-host: Convert to platform remove callback returning void
  mfd: omap-usb-tll: Convert to platform remove callback returning void
  mfd: pcf50633-adc: Convert to platform remove callback returning void
  mfd: qcom-pm8xxx: Convert to platform remove callback returning void
  mfd: sm501: Convert to platform remove callback returning void
  mfd: stm32-timers: Convert to platform remove callback returning void
  mfd: ti_am335x_tscadc: Convert to platform remove callback returning
    void
  mfd: tps65911-comparator: Convert to platform remove callback
    returning void
  mfd: twl4030-audio: Convert to platform remove callback returning void

 drivers/mfd/ab8500-sysctrl.c      | 6 ++----
 drivers/mfd/cros_ec_dev.c         | 5 ++---
 drivers/mfd/exynos-lpass.c        | 6 ++----
 drivers/mfd/fsl-imx25-tsadc.c     | 6 ++----
 drivers/mfd/hi655x-pmic.c         | 5 ++---
 drivers/mfd/intel-lpss-acpi.c     | 6 ++----
 drivers/mfd/kempld-core.c         | 6 ++----
 drivers/mfd/mcp-sa11x0.c          | 6 ++----
 drivers/mfd/mxs-lradc.c           | 6 ++----
 drivers/mfd/omap-usb-host.c       | 5 ++---
 drivers/mfd/omap-usb-tll.c        | 5 ++---
 drivers/mfd/pcf50633-adc.c        | 6 ++----
 drivers/mfd/qcom-pm8xxx.c         | 6 ++----
 drivers/mfd/sm501.c               | 6 ++----
 drivers/mfd/stm32-timers.c        | 6 ++----
 drivers/mfd/ti_am335x_tscadc.c    | 6 ++----
 drivers/mfd/tps65911-comparator.c | 6 ++----
 drivers/mfd/twl4030-audio.c       | 6 ++----
 18 files changed, 36 insertions(+), 68 deletions(-)

base-commit: 4e87148f80d198ba5febcbcc969c6b9471099a09

Comments

Lee Jones Nov. 23, 2023, 5:14 p.m. UTC | #1
On Thu, 23 Nov 2023 17:56:28 +0100, Uwe Kleine-König wrote:
> this series converts all platform drivers below drivers/mfd to use
> .remove_new(). Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver
> core doesn't (and cannot) cope for errors during remove. The only effect
> of a non-zero return value in .remove() is that the driver core emits a
> warning. The device is removed anyhow and an early return from .remove()
> usually yields resource leaks and/or use-after-free bugs.
> 
> [...]

Applied, thanks!

[01/18] mfd: ab8500-sysctrl: Convert to platform remove callback returning void
        commit: 05ce16c1303acaf2094f55ea248fd0d14119ed8f
[02/18] mfd: cros_ec_dev: Convert to platform remove callback returning void
        commit: c86e0818174f506e77dcb7ca0251f18269d79219
[03/18] mfd: exynos-lpass: Convert to platform remove callback returning void
        commit: e3468e03a63e8c24a8b2f9f84ed8443268dcccf4
[04/18] mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void
        commit: 05d78da532ededbc11889ca5a22b302aaa8b9e1e
[05/18] mfd: hi655x-pmic: Convert to platform remove callback returning void
        commit: 30441c456171723d4d40ea86fdc7675a630cb5f8
[06/18] mfd: intel-lpss-acpi: Convert to platform remove callback returning void
        commit: 8b7ffe18eb0bf86b21d558c739279a9cb349b78d
[07/18] mfd: kempld-core: Convert to platform remove callback returning void
        commit: 5c9d52223920a70becbbdf67cce192917f997319
[08/18] mfd: mcp-sa11x0: Convert to platform remove callback returning void
        commit: 0082e145163801002a257c2cbaf2982192ab761e
[09/18] mfd: mxs-lradc: Convert to platform remove callback returning void
        commit: f9714ad21b8c01e6964e0638858d37f941dc19ba
[10/18] mfd: omap-usb-host: Convert to platform remove callback returning void
        commit: 7e5e828e1fef60673c20b47573054eaa036d1980
[11/18] mfd: omap-usb-tll: Convert to platform remove callback returning void
        commit: 6ee0e1844c917fb4e5f314aec2b780f1641375f0
[12/18] mfd: pcf50633-adc: Convert to platform remove callback returning void
        commit: 3e6eccaca6923e8d1ac4a0913b3367b5ab94f95c
[13/18] mfd: qcom-pm8xxx: Convert to platform remove callback returning void
        commit: 31b895f2528bda4db526dee1942f915f8f34091b
[14/18] mfd: sm501: Convert to platform remove callback returning void
        commit: 69fbad222c5caad34f777da33271ccdad3d9504c
[15/18] mfd: stm32-timers: Convert to platform remove callback returning void
        commit: 59569bc36fcec1cd62bd2f639784126c87c6fd1e
[16/18] mfd: ti_am335x_tscadc: Convert to platform remove callback returning void
        commit: 1dbe13baca338502bf741bbe3b199c07c7d1c5bc
[17/18] mfd: tps65911-comparator: Convert to platform remove callback returning void
        commit: 4aa72c8515734c2edf4c6c264aee4925efd97366
[18/18] mfd: twl4030-audio: Convert to platform remove callback returning void
        commit: db1e0b072da189db99f905b758676a81bb796a1a

--
Lee Jones [李琼斯]