[net-next,v9,0/5] net: phy: generic polarity + LED support for qca808x

Message

Christian Marangi Jan. 5, 2024, 2:27 p.m. UTC

This small series add LEDs support for qca808x.

QCA808x apply on PHY reset a strange polarity settings and require
some tweak to apply a more common configuration found on devices.
On adding support for it, it was pointed out that a similar
feature is also being implemented for a marvell PHY where
LED polarity is set per LED (and not global) and also have
a special mode where the LED is tristated.

The first 3 patch are to generalize this as we expect more PHY
in the future to have a similar configuration.

The implementation is extensible to support additional special
mode in the future with minimal changes and don't create regression
on already implemented PHY drivers.

(changelog present in single patch)

Christian Marangi (5):
  dt-bindings: net: phy: Make LED active-low property common
  dt-bindings: net: phy: Document LED inactive high impedance mode
  net: phy: add support for PHY LEDs polarity modes
  dt-bindings: net: Document QCA808x PHYs
  net: phy: at803x: add LED support for qca808x

 .../devicetree/bindings/leds/common.yaml      |  12 +
 .../bindings/leds/leds-bcm63138.yaml          |   4 -
 .../bindings/leds/leds-bcm6328.yaml           |   4 -
 .../devicetree/bindings/leds/leds-bcm6358.txt |   2 -
 .../bindings/leds/leds-pwm-multicolor.yaml    |   4 -
 .../devicetree/bindings/leds/leds-pwm.yaml    |   5 -
 .../devicetree/bindings/net/qca,qca808x.yaml  |  54 +++
 drivers/net/phy/at803x.c                      | 325 ++++++++++++++++++
 drivers/net/phy/phy_device.c                  |  16 +
 include/linux/phy.h                           |  22 ++
 10 files changed, 429 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/qca,qca808x.yaml

Comments

Jakub Kicinski Jan. 9, 2024, 3:14 a.m. UTC | #1

On Fri,  5 Jan 2024 15:27:12 +0100 Christian Marangi wrote:
> This small series add LEDs support for qca808x.
> 
> QCA808x apply on PHY reset a strange polarity settings and require
> some tweak to apply a more common configuration found on devices.
> On adding support for it, it was pointed out that a similar
> feature is also being implemented for a marvell PHY where
> LED polarity is set per LED (and not global) and also have
> a special mode where the LED is tristated.
> 
> The first 3 patch are to generalize this as we expect more PHY
> in the future to have a similar configuration.
> 
> The implementation is extensible to support additional special
> mode in the future with minimal changes and don't create regression
> on already implemented PHY drivers.

Looks like we're missing some tags from DTB maintainers here.
Andrew, is there some urgency in getting this merged or can we
defer until v6.9?

Andrew Lunn Jan. 9, 2024, 1:55 p.m. UTC | #2

> Looks like we're missing some tags from DTB maintainers here.
> Andrew, is there some urgency in getting this merged or can we
> defer until v6.9?

It can wait.

	Andrew

Christian Marangi Jan. 22, 2024, 11:14 p.m. UTC | #3

On Tue, Jan 09, 2024 at 02:55:26PM +0100, Andrew Lunn wrote:
> > Looks like we're missing some tags from DTB maintainers here.
> > Andrew, is there some urgency in getting this merged or can we
> > defer until v6.9?
>

Should I send a new version now that net-next is open again or it's ok?