From patchwork Wed Jan 24 11:19:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 13529169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F125C46CD2 for ; Wed, 24 Jan 2024 12:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=t47wBrxiobdhklSDWCot5j6CvgabYtFDKnxwyhpjUbA=; b=IJ4HlfAmFF3twt fImnLcr5/W77dA4OP+sGUvcJ4y7ewgazLsYAbRqWfLj9g9VI730dPKlphCBC2HW7iF2vcG1sk6/uv Rdn/Ogt6CZbgL+ydj5PxHv0abfvS7ax8STYuBAzPdh/ALixIoylYvGKc08KcHOZWtjCZjxJdYNwTG QcpZj3iZ1hWRVnYI7EYLMXdvc9xwWh81JQHJ/ZFHqyUj5uTmL0bWyOOVs0oqz3zXbeiWhH0KcNFOj tIFxbrCNiUbKXiUQVaZG6zq+GH7mTXZ32ACGynyJq2FCKRNmN3vLY4kMRV0uL1EnSaBvKnFk6zMoB pwG4i8kg2rwwkO8HWAxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rScOt-003E2U-0f; Wed, 24 Jan 2024 12:30:39 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSbIG-002ilT-2b for linux-arm-kernel@lists.infradead.org; Wed, 24 Jan 2024 11:19:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706095178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Tdg6Pxwo5yb88aEPcd5SX3GxtpgWjx+EchJ6YmUkm4=; b=Hq48JieXOlyUCEN8k/hJOUJgdS/CjxtYFUN1TCsCGb1u5Dhj83k9rtyhCVem7wUxHDI8R+ YKOQnoMTtrlnG2LWBFDUn+2UDxj0NJvyg681eHzn9aXzwFRbseVa+mBtMluB6qYiQSzoMg rxDKjfg7QMAc2k0HIOgAylCimBQ94MM= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-u1WrbNTiO0C0mT8EkXoNqw-1; Wed, 24 Jan 2024 06:19:37 -0500 X-MC-Unique: u1WrbNTiO0C0mT8EkXoNqw-1 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-469be81ec74so537160137.1 for ; Wed, 24 Jan 2024 03:19:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706095177; x=1706699977; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Tdg6Pxwo5yb88aEPcd5SX3GxtpgWjx+EchJ6YmUkm4=; b=MtZI3//1StaBTmE9OGCP+yMWUgJBV/DHwkP/gbH8QLXdCI2xTBjdp+gTFfaAlijxrm 8zGdiaF048gOzWZxUwZ8EASjYDbxwImqc7y3B02Nd6vYBupaOF6O7n6gxdNUjSl0pLAa 1UZvomiocYC1yFygbQU/eCSjuanPY1FLPURit/dlc+tNPXZstprU4zdFkupNivWiceNq X+wxpdOufwKsvAQlOjoSghfszRjKvGuI8qu2ZikwlDS0YIiKWYfjtq+9vNiFt61YxZTN I1+bejvwWl8m1CQerSh8Q9SZSi0bVSIkhwqdacSuwJSZFLli5H6pspZB4LtlYlYlI/+E Lemw== X-Gm-Message-State: AOJu0YwJIV/ULVD6yZ5v08X6kn6QA5vXMn4isKaYxjZZeFeEKuBZBvqV Ep7Ytt+Ev/QEJvpR7aTol7h7wJGT1xM/V9v+p5tkykc2BAN1QhLg/c8qG7hKHIwO49Q6zASz727 PwoAlJmJSZm+lRxSTSpOQAeYqbaQnJ7dkVnua+VKpPbNC8Vi6Sj3r/D2BNGVj6xjYAwmg1wK+ X-Received: by 2002:a67:cf4d:0:b0:469:aec1:b425 with SMTP id f13-20020a67cf4d000000b00469aec1b425mr1668108vsm.3.1706095176865; Wed, 24 Jan 2024 03:19:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfq/53hwK5W6EYfpAy/CIrTd6ajQQRINtlI/Tva0zppHFqHuvfSChD8fb6zOGYnC6pXS//nA== X-Received: by 2002:a67:cf4d:0:b0:469:aec1:b425 with SMTP id f13-20020a67cf4d000000b00469aec1b425mr1668087vsm.3.1706095176567; Wed, 24 Jan 2024 03:19:36 -0800 (PST) Received: from pstanner-thinkpadt14sgen1.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id ql3-20020a056214540300b00686aa6dbcbfsm1027016qvb.81.2024.01.24.03.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 03:19:36 -0800 (PST) From: Philipp Stanner To: Laurentiu Palcu , Lucas Stach , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Philipp Stanner Subject: [PATCH v4 0/2] drm/imx/dcss: implement region request and devres Date: Wed, 24 Jan 2024 12:19:03 +0100 Message-ID: <20240124111904.18261-2-pstanner@redhat.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240124_031944_943144_0D501DB4 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org @Laurentiu: Thank you very much for the review. I was indeed on an older branch. As Linus's master is currently broken for ARM64 [1], unfortunately, I built it instead against: 60096f0a77600ac2cc92b82fee279d1905576950 Hope that's fine. Changes in v4: - Add Laurentiu's Reviewed-by to patch #1 - Remove unnecsseray struct device pointers from all touched files - Rebase against newer kernel due to changes in dcss_drv_platform_remove() Changes in v3: - Fix build errors (missing variable, forgotten remove to call of deleted function) Changes in v2: - Add the region-request to this patch-series. That was previously a separate patch. dcss currently does not request its memory resource. This series adds that request with devres. As we're at it, it also ports all the ioremaps and associated allocations to devres. I can build this, but I don't have the hardware available to test it. So you might want to have a closer look. P. [1] https://lore.kernel.org/lkml/45ad1d0f-a10f-483e-848a-76a30252edbe@paulmck-laptop/ Philipp Stanner (2): drm/imx/dcss: request memory region drm/imx/dcss: have all init functions use devres drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 13 ++----------- drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 14 +++----------- drivers/gpu/drm/imx/dcss/dcss-dev.c | 19 +++++++++---------- drivers/gpu/drm/imx/dcss/dcss-dev.h | 1 - drivers/gpu/drm/imx/dcss/dcss-dpr.c | 21 +++------------------ drivers/gpu/drm/imx/dcss/dcss-drv.c | 12 +++--------- drivers/gpu/drm/imx/dcss/dcss-dtg.c | 26 +++++--------------------- drivers/gpu/drm/imx/dcss/dcss-scaler.c | 21 +++------------------ drivers/gpu/drm/imx/dcss/dcss-ss.c | 12 +++--------- 9 files changed, 31 insertions(+), 108 deletions(-)