From patchwork Thu Jan 25 15:16:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13531075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 266C8C47258 for ; Thu, 25 Jan 2024 15:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TnAH/snAirjPHV+E/ZV2KSEFa+cLgSZ68xWDU+KVw+M=; b=GRHdGHwRKx2mVh uenu3lbUwm7M1l01PqYKPFcE6WeQyiZbqCEpQZgCifKrXZoN1Iqqhk2Le7lS5F1uFleCxzp8cSQfM 8dka/wlrxQeTrXspqWvqxTMIScqtQyIp583Z9RQyfM8bkxOhqaAD5sRxL1R0xMfVNX0QH7l9QOT4h ARvfLnzO+aYqpNbzQcEp44U5l5hSky4HCaRkeSsLQTk4RCDjLiKlWZ/iMhx0fcl0U15NpHn7IeD+A RJcg13YMXUf6mOXNH74Z6iQTCwMImF7/aLDDVD/k0IZG8YgwH61v8KmVYH26ooDQ7P26snOY+vH9A gJRXEmL4W/HADGbSR5NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT1TA-00000000Zfv-3nHK; Thu, 25 Jan 2024 15:16:44 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT1T7-00000000Zez-2r2g for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 15:16:43 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3394446205dso2465932f8f.1 for ; Thu, 25 Jan 2024 07:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706195799; x=1706800599; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qQoIeZ794qaGVa7O+x2w9XHa6gq/yapDW4Z31do6ZCo=; b=Pb9c1b3gdgLqEwU+lM79hF84RCXg5h8aV/x0JRoHwkme4MIkcs9impWVLIXUl35ryi +w3BbzKabIDTqtcM9fwu1eToxQCNYSMHaNP7FyTvNolzQ5adHPAlFrRKBPPrdY6Cl5Af WGEVEg6JTkkL/F74qtXC3uILIu7kNOGnUTdigig4AmDiDK2CQq3iYzYW66x7AYUznOxt 6TskCsJW5ZDE6mwWolHtny9xHOFwvvSNps0vd6Y6ne+4jNbAh4Wop7+PnmVT7nR7kmEF LjPcWwfPLSuiSlTSSL6WolC9Bqj5EdHjR3kYuz72JWBS5Lg50j/7ZJpk9utBQftuwUhA a9Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706195799; x=1706800599; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qQoIeZ794qaGVa7O+x2w9XHa6gq/yapDW4Z31do6ZCo=; b=Yt8T8awH9D9/bWwYilyiU7HAJyza8Y/ePw10fmOdk6OxgfefQieEYBrh1SVz5KTwYt aTYAJ4F2FUakBjXb0e4/wquArmt4diJMm5UMqXV53XPKsGGGyDfNaS6t33RtD+2ixG58 XMX1UsseV+xy8PpTOfs4+teFo6c+JbRmqqGAIf1X/z08qV8b3bwR131cxdVROz8K3WRJ v4s0Qjkt/8MgBAVdl/XSCg8lIi9z/1S6v4ZSULNtB4X4LWy3RtJmPHgGF/cCKw809Fey nVPwPKmbb21eUYrd8SXVXULnv5azu3R/zYDl6TxjVBFdNAcA4qtkJ5RLqRtCrq9ulZmH wYpA== X-Gm-Message-State: AOJu0YwEs3GCMZRnD0FIwILV7dt2NRg1JHkSXnVHoPjgrXr2VZeha4gi UtgwGIv2QHIVBSLpJuyQkoxrJPaPe6KU/ZB0xdzq238fPIphnHbdsMcmmWAFX2s= X-Google-Smtp-Source: AGHT+IHP8rPbXmySZmV4hTwPoeW+IcSMERM2waGJhBWSvZn39MNoFHAqNGw/HYgSokHmRAreNlQqww== X-Received: by 2002:adf:e9d2:0:b0:337:bba4:6bdd with SMTP id l18-20020adfe9d2000000b00337bba46bddmr664866wrn.54.1706195799478; Thu, 25 Jan 2024 07:16:39 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id q17-20020adfcb91000000b00337d3465997sm3184656wrh.38.2024.01.25.07.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 07:16:38 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org Cc: robh+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, semen.protsenko@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 0/7] ARM: dts: samsung: specify the SPI fifosize Date: Thu, 25 Jan 2024 15:16:23 +0000 Message-ID: <20240125151630.753318-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_071641_772995_0A087E8A X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, The "samsung,spi-fifosize" was introduced in the following patch set: https://lore.kernel.org/linux-arm-kernel/20240125145007.748295-1-tudor.ambarus@linaro.org/T/#t I expect Mark will provide an immutable tag for the bindings so that it can be merged into the samsung tree. We'll avoid this way using the property into the device trees without having it defined into the bindings. These patches close the circle and break the dependency between the SPI of_alias ID and the SPI driver. The SPI of_alias ID was used as an index into the fifo_lvl_mask to determine the FIFO depth of the SPI node. Changing the alias ID into the device tree would make the driver choose a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask array boundaries. Not specifying an SPI alias would make the driver fail to probe, which was wrong too. Thus I updated the driver and I provided alternatives to either infer the FIFO size from the compatible, where the SoC uses the same FIFO size for all the instances of the IP, or by using the "samsung,spi-fifosize" dt property, where the SoC uses different FIFO sizes for the instances of the IP. This patch set takes care of the second case and adds "samsung,spi-fifosize" for all the SoCs that need it. Cheers, ta Tudor Ambarus (7): ARM: dts: samsung: s5pv210: specify the SPI fifosize ARM: dts: samsung: exynos3250: specify the SPI fifosize ARM: dts: samsung: exynos4: specify the SPI fifosize ARM: dts: samsung: exynos5250: specify the SPI fifosize ARM: dts: samsung: exynos5450: specify the SPI fifosize ARM: dts: samsung: exynos5433: specify the SPI fifosize ARM: dts: samsung: exynosautov9: specify the SPI fifosize arch/arm/boot/dts/samsung/exynos3250.dtsi | 2 ++ arch/arm/boot/dts/samsung/exynos4.dtsi | 3 +++ arch/arm/boot/dts/samsung/exynos5250.dtsi | 3 +++ arch/arm/boot/dts/samsung/exynos5420.dtsi | 3 +++ arch/arm/boot/dts/samsung/s5pv210.dtsi | 2 ++ arch/arm64/boot/dts/exynos/exynos5433.dtsi | 5 +++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 12 ++++++++++++ 7 files changed, 30 insertions(+)