From patchwork Fri Jan 26 17:15:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13532899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02646C47422 for ; Fri, 26 Jan 2024 17:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cVVrxNPKS7wXBcogmE7j+CzazMsyTBtdUMAfNRzeNdc=; b=ExPff2oNdqsR/J etoZkcWSX6wLCBeBGxyxy3JeavjHppg1XJu88HW/kRCuGtbrFoxd0X1me3YXNocqQs4JbZoNYwrtx dC/wnWNiOgLKNQKSJGWGbIsDzR4wQyVQX0x/bDkYri+IFEY2Js31zW3Ni5Zk1nFlkiZdpWTJgcREK YXKA1qIsuLXo7kqEd683qJZumqObmTTgM/B5paO2WBLWLDRsSntsb7Cr2waZdlIrv6q+GHxueeaK0 /6do2KEFGM85lyEVEWMjOzCedjpjp75C5BYgeecqsIDNR3m70+8q1tQK6GbXLFurnM/dOhEAnUvj9 Mwo1I5Uw6/wODaCmtqtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPo1-00000004pPd-1s5H; Fri, 26 Jan 2024 17:15:53 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPny-00000004pON-2eli for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 17:15:52 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40e7065b692so9304735e9.3 for ; Fri, 26 Jan 2024 09:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706289349; x=1706894149; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hBQadJTQmd+rp5iQVTCEPm0E+5bcMf5aFRFa6IDttrs=; b=ApwRO7IRlEIrsZyUvnG3rFgUAYunn/8/HTOiQnrCR2evMUo3bwcdytbbK/n3ufQCOR MSDTx46enQm72rA9QItvRhPuADnI/PCdsTHqT1PDj+8Mi48FVExIJ/ZN6mxUs8AlY/tN cJaUpPRkAdSIa1A44FYrtgzemH3g0vwajBhQEpKSEFqAx8JjDq2xtQXYOOq6+NHX70Lv /7k4JjQHKy73qls6YNTDmzOVBu9bObb7i0YxsQiwtYGMEKuhk5/5UdF6rRDACRvSLg1H JuPtV4wUqCbw8xmNqdPj2+v5/vRkBvwMO+kvpCFKreNC77nXCfJu/b3TH2z+kncsiExm 18KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706289349; x=1706894149; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hBQadJTQmd+rp5iQVTCEPm0E+5bcMf5aFRFa6IDttrs=; b=XJ3dE6HLpoyncdfXGQX5jhvbs5chTsXirZbjJoDIf6dnSVLAyfChrSz1ZnLuIvDZcW 1ZkbCrQw3RJsASixMa4nPeY7EO5d+NoECvZeI20Hf6lxBBs4piS9LClmu7eWhzk5VAix wrlqz4YjgoKfmRxGTFUzhH7HUjjC6wt5DT0FxfeDpMUk6+LFLvjgeMww/NQE6viF0FNs Z4aU3eTkYDtuoFJcXihAoqQi2Fb5snRrNDom6OLmHKkZxSH3DIgZvuTqNnFllieP7l2g HbtUFBjZ9nzZBDzyC6uf8Zva3IKyXgjc0YPZ7JxG6PXVwmrP3zjJe+XzWUv5AQrJEvnr PZxw== X-Gm-Message-State: AOJu0YyJn3l1x/euqVuVcij/k6yZcA5p/58Sokgot+ex0Wnplf3UEmqI sma0XbguGTueFimj+itUkxaqgOAqydNyvM/6ofQ8nTBP0yy5HIrg4xaccB/RcWg= X-Google-Smtp-Source: AGHT+IGRkC4wroA/6kPAgQvjykcxN7dPJ1nl0UjHKakeWfw1B7pvhfAxB8IyBSSZAdHdlBym1L3+0Q== X-Received: by 2002:a05:600c:45c5:b0:40e:e025:8d4e with SMTP id s5-20020a05600c45c500b0040ee0258d4emr91907wmo.27.1706289348701; Fri, 26 Jan 2024 09:15:48 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id k10-20020a05600c1c8a00b0040e451fd602sm6287286wms.33.2024.01.26.09.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:15:48 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, jassi.brar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v3 00/17] spi: s3c64xx: straightforward cleanup Date: Fri, 26 Jan 2024 17:15:28 +0000 Message-ID: <20240126171546.1233172-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_091550_701952_D7266637 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Straightforward patches that clean the driver. Just compiled tested. Stands up just the patch that updates the driver to use the bitfield access macros. The bit operations shall be identical after the patch. Sam and Andi have some concerns on whether using the bitfield access macros are just a matter of taste, or they are actually necessary. I think they are necessary. Here are the concerns/discussions: https://lore.kernel.org/linux-arm-kernel/ee4107c3-1141-45ab-874c-03474d8ec18d@linaro.org/ https://lore.kernel.org/linux-arm-kernel/ri7gerw4ov4jnmmkhtumhhtgfgxtr6kpsopdxjlx6fylbqznna@3qgvejyhjirw/ Cheers, ta v3: - reworked the bitfied access macros patch so that the bit operations are the same as before the patch. Fix S3C64XX_SPI_PSR_MASK value, drop S3C64XX_SPI_CS_NSC_CNT_MASK. - add a new patches to explicitly remove a duplicated definition and to drop a superfluous bitwise NOT operation. - collect R-b tags v2: https://lore.kernel.org/linux-arm-kernel/36a664b1-666d-4fc4-90d9-35b42e56973d@linaro.org/ Tudor Ambarus (17): spi: s3c64xx: explicitly include spi: s3c64xx: explicitly include spi: s3c64xx: avoid possible negative array index spi: s3c64xx: fix typo, s/configuartion/configuration spi: s3c64xx: sort headers alphabetically spi: s3c64xx: remove unneeded (void *) casts in of_match_table spi: s3c64xx: remove else after return spi: s3c64xx: move common code outside if else spi: s3c64xx: check return code of dmaengine_slave_config() spi: s3c64xx: propagate the dma_submit_error() error code spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() spi: s3c64xx: drop blank line between declarations spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props spi: s3c64xx: remove duplicated definition spi: s3c64xx: drop a superfluous bitwise NOT operation spi: s3c64xx: use bitfield access macros drivers/spi/spi-s3c64xx.c | 298 ++++++++++++++++++++------------------ 1 file changed, 158 insertions(+), 140 deletions(-)