[v4,00/19] Remove pm_power_off use in drivers/power/reset

Message

Andrew Davis Feb. 12, 2024, 4:28 p.m. UTC

Hello all,

Use of pm_power_off is considered legacy and should be replaced with
register_sys_off*(). Same for register_restart_handler(). Do this
for the drivers/power/reset subsystem for all trivial cases.

Thanks,
Andrew

Changes for v4:
 - Fix sparse warning in [12/19] and [13/19]
 - Move data allocate from [19/19] to [18/19]
 - Add review tags in patches [7/19] and [11/19]
 - Rebase on v6.8-rc4

Changes for v3:
 - Use dev_err_probe() in patch [11/19]
 - Add review tags in patches [18/19] and [19/19]

Changes for v2:
 - Fix sparse warning in 7/19 and 10/19
 - Add new patch fixing an already existing sparse warning (3/19)
 - Rebase on v6.8-rc3

Andrew Davis (19):
  power: reset: atc260x-poweroff: Use
    devm_register_sys_off_handler(RESTART)
  power: reset: atc260x-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: xgene-reboot: Use devm_platform_ioremap_resource()
    helper
  power: reset: xgene-reboot: Use devm_register_sys_off_handler(RESTART)
  power: reset: tps65086-restart: Use
    devm_register_sys_off_handler(RESTART)
  power: reset: tps65086-restart: Remove unneeded device data struct
  power: reset: brcm-kona-reset: Use
    devm_register_sys_off_handler(RESTART)
  power: reset: axxia-reset: Use devm_register_sys_off_handler(RESTART)
  power: reset: rmobile-reset: Use devm_platform_ioremap_resource()
    helper
  power: reset: rmobile-reset: Use
    devm_register_sys_off_handler(RESTART)
  power: reset: mt6323-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: msm-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: msm-poweroff: Use devm_register_sys_off_handler(RESTART)
  power: reset: regulator-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: as3722-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: gemini-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: restart-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)
  power: reset: syscon-poweroff: Move device data into a struct
  power: reset: syscon-poweroff: Use
    devm_register_sys_off_handler(POWER_OFF)

 drivers/power/reset/as3722-poweroff.c    | 30 ++++-------
 drivers/power/reset/atc260x-poweroff.c   | 55 ++++++++------------
 drivers/power/reset/axxia-reset.c        | 16 +++---
 drivers/power/reset/brcm-kona-reset.c    | 11 ++--
 drivers/power/reset/gemini-poweroff.c    | 16 +++---
 drivers/power/reset/msm-poweroff.c       | 21 +++-----
 drivers/power/reset/mt6323-poweroff.c    | 26 +++++-----
 drivers/power/reset/regulator-poweroff.c | 36 +++++--------
 drivers/power/reset/restart-poweroff.c   | 25 +++------
 drivers/power/reset/rmobile-reset.c      | 35 ++++---------
 drivers/power/reset/syscon-poweroff.c    | 66 ++++++++++++------------
 drivers/power/reset/tps65086-restart.c   | 58 ++++-----------------
 drivers/power/reset/xgene-reboot.c       | 21 +++-----
 13 files changed, 150 insertions(+), 266 deletions(-)

Comments

Sebastian Reichel Feb. 13, 2024, 1:30 a.m. UTC | #1

On Mon, 12 Feb 2024 10:28:12 -0600, Andrew Davis wrote:
> Use of pm_power_off is considered legacy and should be replaced with
> register_sys_off*(). Same for register_restart_handler(). Do this
> for the drivers/power/reset subsystem for all trivial cases.
> 
> Thanks,
> Andrew
> 
> [...]

Applied, thanks!

[01/19] power: reset: atc260x-poweroff: Use devm_register_sys_off_handler(RESTART)
        commit: f22e835028902b01915f584d2912cc25a397c84e
[02/19] power: reset: atc260x-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: ab1439b05168dc73539e78d8b3100a0336a83bca
[03/19] power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper
        commit: 7ddfd33c6ee58ee915d09177a7dbac2c5be7b536
[04/19] power: reset: xgene-reboot: Use devm_register_sys_off_handler(RESTART)
        commit: 6af1ee028537be0a43ce939eb8f5321096208667
[05/19] power: reset: tps65086-restart: Use devm_register_sys_off_handler(RESTART)
        commit: e68b71812ebf385317c5bcf82674c109806be452
[06/19] power: reset: tps65086-restart: Remove unneeded device data struct
        commit: 11d2642e14ad022de13f261370ccddd33693c045
[07/19] power: reset: brcm-kona-reset: Use devm_register_sys_off_handler(RESTART)
        commit: 45079f206e635a08cba395a08dd3fd7629dbb24d
[08/19] power: reset: axxia-reset: Use devm_register_sys_off_handler(RESTART)
        commit: ad8d7b8002a1d3a673f2d6f110b378d137f61037
[09/19] power: reset: rmobile-reset: Use devm_platform_ioremap_resource() helper
        commit: 0867276eb12230a5e94ec2b28eba718e76b77eb1
[10/19] power: reset: rmobile-reset: Use devm_register_sys_off_handler(RESTART)
        commit: ba1188ea8be80a7bc091073792d404ab54b187b1
[11/19] power: reset: mt6323-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: 6ab9137719a719f39e000aa62887ae25e1194815
[12/19] power: reset: msm-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: b5711ff9171325261a7d6406b3c2b3c7752b6b8a
[13/19] power: reset: msm-poweroff: Use devm_register_sys_off_handler(RESTART)
        commit: 00ae86ebf893e0c89a7af6bfd270259e3ded93d1
[14/19] power: reset: regulator-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: 77b61173c2d0ff42e5d609dc1fad137f1229f03b
[15/19] power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: 348fde771ce7f5219a73750bd7a0d4c4497b1223
[16/19] power: reset: gemini-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: b6475c3f81c13d6d69113f69a668c96af3a5af51
[17/19] power: reset: restart-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: c3ede0b6f7dd345d8986cb69b861cadb9976782f
[18/19] power: reset: syscon-poweroff: Move device data into a struct
        commit: ffa212831289f15a92fe295a371157290619bb8f
[19/19] power: reset: syscon-poweroff: Use devm_register_sys_off_handler(POWER_OFF)
        commit: 14c5678720bdee7c5b582839a8dbcffd0c50de5c

Best regards,