From patchwork Fri Feb 16 07:05:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13559612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41074C48260 for ; Fri, 16 Feb 2024 07:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2pQC/CQte1+fchTYVsDKKCbDFIWIgRv+fjSOjccCxRg=; b=l4vPYT/5yVAxY1 LyuXYBY8EiLP7fgh9DVlHsn2f6dpLWaGMBuFto/K8g6snqs+khamOe+U513eGlx81b3Z6AyoTrpSK 5+vwFvbjVWcvGAHm2ov0V8/DCHumypJKQjeb4HwdbaNGHHjmgWe8fI481Gk3c2wggVUcbEw2DQ0/f gd1PTZ9P2q9IShisoxwGB8FMGuI9LrkMZHjM4XooaBe1YjVKxn1CpsXV91Uu3S7cEnYTBT++wBcvn mgJdeqQdeTHX9Id72ZmC6ujkhx21GltCNvlSUI17IVoBR9GqvK7BO/k4NzgjHQ22R5n9fPS0nNMY4 cHrvelwnpuBSEqJnOjjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rasIS-00000001JAJ-0Bt9; Fri, 16 Feb 2024 07:06:08 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rasIL-00000001J7y-35LU for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 07:06:05 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3394ca0c874so289615f8f.2 for ; Thu, 15 Feb 2024 23:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708067159; x=1708671959; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uFOh+ffUHbTzqoNg7f3NtavVRglY5kTfBM1QkaehxhQ=; b=TCGuGmcSsS8719qIHNpbTjbOH8LmoVyIhhyVW+8JR1mf8bhsJD0APR+nnFivZP5WW3 UWQp7rPHdyIQDdcD0l+uZJTixD+bRangds4cqlJcg0D1amMcbuX8DnLP4tdMnDn7htTA 24olAkhFUGLMvaUhs0HDuzOBJyhdcC0Vj5LuolpM2m8wccYwKmBrz885XjKh3tLKrsJH dCAQSMa85g0ehoXOF8RHK27adlsvQmzbhm1NQPFV7GEiG9IhFHaqequ1wu8F+hbBRKie bkS7QvGX/NFZQZcbB9siiCxm0tXiPW8dBCF/qehhlMRAqzU4L5ZYKIAMFOV9mFOEY2eD kxVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708067159; x=1708671959; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uFOh+ffUHbTzqoNg7f3NtavVRglY5kTfBM1QkaehxhQ=; b=rU0pw9OUqllc1JVC7a8RIVbrhussDQH+yyDax+PFRBtUsppuXVLoIphstQK78A82vJ CIp916NQXSNUk9d3c5DT9mo3YxHhMYPlLSk+iV54UwpsaJsCWyQaiHRXD3BaHVnnAisj hcJPP6Sv0Qk+XZXO3v6NxoKKQ4FtzN61ZGy1/6TR+R3M95vL4hYwLvwVVkpeg6AfaKvX v4boB4zYIUxb5JzjHfQBbitg/+EUraiEDRqDdjKSGyJWotNhMMHr06ELpGRHz+TCBMt9 zt6bbnzqDd5ZHQjlbvW097TJ42x7nT+7UX5Oa/SuOerRuwvFoDrHBKv1hhZwGAqh+EPe T6qg== X-Forwarded-Encrypted: i=1; AJvYcCWVLxlO0x8beJQUazmh+ABRhb8MFl88J3Ol3Vs1XSII+vbexmvSBi21dzHAxKifKGctMs6T24SEDt6dz11x+bdupQLe5HOq5qQrDo/uU89xEu9mrgM= X-Gm-Message-State: AOJu0YwIY7w2ML3BeWJYeJfmzl57rolckj00zR0a4KlrSMiIsHHUyfs+ G3M+6j/2e9s5d50J9eDzZBJZldu25WFUUZ73fKoAqBJPSupYB+tI0NrZuDYhQi4= X-Google-Smtp-Source: AGHT+IGy0mnVYtYozVNTM9NIVBhX9/4wYTRqXkWmb8HX1VziUVkIvro8ChPAqsm7xYi9J/dZTIyEkw== X-Received: by 2002:a5d:4486:0:b0:33d:d32:2a5b with SMTP id j6-20020a5d4486000000b0033d0d322a5bmr2407932wrq.3.1708067159298; Thu, 15 Feb 2024 23:05:59 -0800 (PST) Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0033940016d6esm1298839wrw.93.2024.02.15.23.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 23:05:58 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, Tudor Ambarus Subject: [PATCH v3 00/12] spi: s3c64xx: remove OF alias ID dependency Date: Fri, 16 Feb 2024 07:05:43 +0000 Message-ID: <20240216070555.2483977-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_230601_836084_20199D8E X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver was wrong as it assumed that the alias values in devicetree have a particular meaning in identifying instances. This immediately breaks when there is a dtb file that does not use the same alias values, e.g. because it only needs some of the SPI ports. Tested gs101 SPI with spi-loopback-test, all went fine. I updated exynos850 as it uses the same USI.SPI_VERSION as gs101. Maybe Sam can test exynos850, if not, we can drop that patch (12/12). v3: - fix indentation in dt-bindings - collect Rob's R-b v2: - update bindings to consider the asymmetric case where the RX FIFO depth can differ from the TX FIFO depth - update commit message in patch 11/12 to describe the GS101 change (I was wrongly mentioning exynos 850). Tudor Ambarus (12): spi: dt-bindings: introduce FIFO depth properties spi: s3c64xx: define a magic value spi: s3c64xx: allow full FIFO masks spi: s3c64xx: determine the fifo depth only once spi: s3c64xx: retrieve the FIFO depth from the device tree spi: s3c64xx: allow FIFO depth to be determined from the compatible spi: s3c64xx: let the SPI core determine the bus number spi: s3c64xx: introduce s3c64xx_spi_set_port_id() spi: s3c64xx: get rid of the OF alias ID dependency spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id spi: s3c64xx: switch gs101 to new port config data spi: s3c64xx: switch exynos850 to new port config data .../bindings/spi/spi-controller.yaml | 27 ++++ drivers/spi/spi-s3c64xx.c | 142 ++++++++++++++---- 2 files changed, 138 insertions(+), 31 deletions(-)