From patchwork Thu Feb 22 18:12:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13567856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE3D9C5479F for ; Thu, 22 Feb 2024 18:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=P3sU7NOswJXAS3f1H2YnOrf8pSRwgQDF4BMjgVN8YbA=; b=47yDKpvcasChSv HPGrVyzhfLm+H5OdypGIAySAsTGMCad1wgdARtB4OSOn84L1nK/Uva+gZSaFcBn3X4o6/lIBwllih tt08A+3qc2us6IQxKuy/J3AWtKZNpdcr92n9vnzbnfa2ZxeZr4PxGOSzPxMLCTWFlGof87IN2Zj// QTT0a81ca6I7EDIeKwikAKzADJkVjepaLHKkXM7efHfQmgv0hHh40qAifTq+fGAR4fpPz0f+SSAfw f5xNy5iZUkSaTNtnu9H3Flbt+VTXH8VNsp0EdC5a9nY+/zD7anpfedhd+eRD5rcCJPqsbHh7KLsoB phYNEfIJM2x43NDlf8YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDb0-00000005xGB-3LIG; Thu, 22 Feb 2024 18:15:06 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDaW-00000005x3W-3OqN for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 18:14:43 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-511976c126dso127722e87.1 for ; Thu, 22 Feb 2024 10:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708625661; x=1709230461; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PN5NRQnWHEZRwyT6/9VVPAz+f1vMXJvzGhXBi4EmoP0=; b=G98LEHR1mt4PcBfgra0n3MY03VJlHEvqZSBdKorqUUwj7JRkAX6l9CTn1AZAu9hDM2 W0bbMzsuW16B+84FFYoyIFFW8Pd35UdXgbzV4rzSKDqz4koGYnBGfSglDKJBZKAD0oTY OhrsmheWprmorlTTXJ/+CDyOJOVQqKoek27QaHMKUj2654fWQdeDifXU5KtTB+Bk2qIN smkNG6j2DA13pTxFJRcGxjcbzA35zVTmjvHxMEOuOihvPFZM/BqsN9vFzSwNUfSpTDrd sg08l677CNoirSNyBCj91ccAEp3FFACT5Kts6g+T1PDmGfYNEX8fP3n80P30JsFKLsKA H3xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708625661; x=1709230461; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PN5NRQnWHEZRwyT6/9VVPAz+f1vMXJvzGhXBi4EmoP0=; b=pY0GkD+QRyV60lV0NFjv+8vM0OmsiX+rtfJ0qNcMF06A2PWJcSdqehDyCfI+F3oz4p tCszUDJA9kk8DHoyx4U35JTxZLAMbLBB2e/F7H1pwaVrYUKG9BTDTljr1yGQfQod+crv 0THTfWUPynyCo1c1RzQw86kuHCWs7ymyUJw22qvdT/o55AJ6rHguG3TpSCL1Nj/mivCh 2gDub/jxL6buZRRGiWu9Y2auAXQlwGCPxtSQXoQKZK8I5G5K2UU8PyzdAtw5zh5/AoJ5 7iXBO7eDYbX2A0ADMS5J8KXqdhIgxo9GA17lUi/qgeDl/CWGLUQgQPk0TK1tsN5lfD3Z T3Kw== X-Forwarded-Encrypted: i=1; AJvYcCUN5QaVulVZG6xq2t2EKNCiQ+74CmyPZwxBlTU2sLiOm3c++rtiiCexAEi90iO8CiEEK5y26/N+PGsyvi5M7Fh9mNtbVj04cJuXOcvsCVEg8xx9Tq8= X-Gm-Message-State: AOJu0YwDxut3XSO7BG5bOcevdoc6/pZm6771UUe0+kAT4WeLEXSV+Dav s1dAIK6g8/1v+uIYq6MxMh07nqznVVQiC7HWf5rhlODVBSB66yS5hyXe5d+ZFik= X-Google-Smtp-Source: AGHT+IHNzg7aBgXaIJbMNuK7guBEV8t9q5d8NEnp8aTPztWCzWFVniq+diGN4H/a4FvKPWQ4MvMgFg== X-Received: by 2002:a05:6512:3089:b0:512:ada6:f218 with SMTP id z9-20020a056512308900b00512ada6f218mr12105162lfd.59.1708625661075; Thu, 22 Feb 2024 10:14:21 -0800 (PST) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id w5-20020a05651204c500b00512dfa19983sm246262lfq.50.2024.02.22.10.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:14:20 -0800 (PST) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 00/20] EDAC/mc/synopsys: Various fixes and cleanups Date: Thu, 22 Feb 2024 21:12:45 +0300 Message-ID: <20240222181324.28242-1-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_101432_575114_D5EF0CD0 X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patchset is a first one in the series created in the framework of my Synopsys DW uMCTL2 DDRC-related work: [1: In-progress v5] EDAC/mc/synopsys: Various fixes and cleanups Link: ---you are looking at it--- [2: In-progress v4] EDAC/synopsys: Add generic DDRC info and address mapping Link: https://lore.kernel.org/linux-edac/20230920192806.29960-1-fancer.lancer@gmail.com [3: In-progress v4] EDAC/synopsys: Add generic resources and Scrub support Link: https://lore.kernel.org/linux-edac/20230920195720.32047-1-fancer.lancer@gmail.com Note the patchsets above must be merged in the same order as they are placed in the list in order to prevent conflicts. Nothing prevents them from being reviewed synchronously though. Any tests are very welcome. Thanks in advance. The main goal of the entire set of the changes provided in the mentioned patchsets is to as much as possible specialise the synopsys_edac.c driver to be working with the Synopsys DW uMCTL2 DDR controllers of various versions and synthesized parameters, and add useful error-detection features. Regarding this series content. It's an initial patchset which traditionally provides various fixes, cleanups and modifications required for the more comfortable further features development. The main goal of it though is to detach the Xilinx Zynq A05 DDRC related code into the dedicated driver since first it has nothing to do with the Synopsys DW uMCTL2 DDR controller and second it will be a great deal obstacle on the way of extending the Synopsys-part functionality. The series starts with the fixes patches, which in short concern the next aspects: touching the ZynqMP-specific CSRs on the Xilinx ZinqMP platform only, serializing an access to the ECCCLR/ECCCTL register, adding correct memory devices type detection, setting a correct value to the mem_ctl_info.scrub_cap field, dropping an erroneous ADDRMAP[4] parsing and getting back a correct order of the ECC errors info detection procedure. Afterwards the patchset provides several cleanup patches required for the more coherent code splitting up (Xilinx Zynq A05 and Synopsys DW uMCTL2 DDRCs) so the provided modifications would be useful in both drivers. First the platform resource open-coded IO-space remapping is replaced with the devm_platform_ioremap_resource() method call for the sake of the code simplification. Secondly the next redundant entities are dropped: internal CE/UE errors counters, local to_mci() macros definition, some redundant ecc_error_info structure fields and redundant info from the error message, duplicated dimm->nr_pages debug printout and spaces from the MEM_TYPE flags declarations. (The later two updates concern the MCI core part.) Thirdly before detaching the Zynq A05-related code an unique MC index allocation infrastructure is added to the MCI core. It's required since after splitting the driver up both supported types of memory devices could be correctly probed on the same platform. Note even though it's currently unsupported by the synsopsys_edac.c driver it's claimed to be possible by the original driver author (it was a reason of having two unrelated devices supported in a single driver). Finally the Xilinx Zynq A05 part of the driver is moved out to a dedicated driver. After that the platform-specific setups API is removed from the Synopsys DW uMCTL2 DDRC driver since it's no longer required. Finally as the cherry on the cake a set of the local coding style cleanups are provided: unify the DW uMCTL2 DDRC driver entities naming and replace the open-coded "shift/mask" pattern with the kernel helpers like BIT/GENMASK/FIELD_x in there. It shall significantly improve the code readability. Changelog v2: - Move Synopsys DW uMCTL2 DDRC bindings file renaming to a separate patch. (@Krzysztof) - Introduce a new compatible string "snps,dw-umctl2-ddrc" matching the new DT-schema name. - Forgot to fix some of the prefix of the SYNPS_ZYNQMP_IRQ_REGS macro in several places. (@tbot) - Drop the no longer used "priv" pointer from the mc_init() function. (@tbot) - Include "linux/bitfield.h" header file to get the FIELD_GET macro definition. (@tbot) - Drop the already merged in patches: [PATCH 12/20] EDAC/mc: Replace spaces with tabs in memtype flags definition [PATCH 13/20] EDAC/mc: Drop duplicated dimm->nr_pages debug printout Changelog v3: - Drop the no longer used "priv" pointer from the mc_init() function. (@tbot) - Drop the merged in patches: [PATCH v2 14/19] dt-bindings: memory: snps: Detach Zynq DDRC controller support [PATCH v2 15/19] dt-bindings: memory: snps: Use more descriptive device name (@Krzysztof) Changelog v4: - Remove Rob, Krzysztof and DT-mailing list from Cc since the respective patches have already been merged in. - Add a new patch [PATCH v4 6/20] EDAC/synopsys: Fix misleading IRQ self-cleared quirk flag detached from the very first patch of the series. - Add a new patch [PATCH v4 15/20] EDAC/mc: Re-use generic unique MC index allocation procedure - Add a new patch [PATCH v4 18/20] EDAC/synopsys: Unify CSRs macro declarations collecting the changes from various patches of the series. - Drop redundant empty lines left by mistake. - Drop private counters access from the check_errors() method too. - Rebase onto the kernel v6.6-rcX. Link: https://lore.kernel.org/linux-edac/20230920191059.28395-1-fancer.lancer@gmail.com Changelog v5: - Fix function names in the zynq_edac.c kdoc. - Rebase onto the kernel 6.8-rc3. Signed-off-by: Serge Semin Cc: Punnaiah Choudary Kalluri Cc: Dinh Nguyen Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org Cc: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (20): EDAC/synopsys: Fix ECC status data and IRQ disable race condition EDAC/synopsys: Fix generic device type detection procedure EDAC/synopsys: Fix mci->scrub_cap field setting EDAC/synopsys: Drop erroneous ADDRMAP4.addrmap_col_b10 parse EDAC/synopsys: Fix reading errors count before ECC status EDAC/synopsys: Fix misleading IRQ self-cleared quirk flag EDAC/synopsys: Use platform device devm ioremap method EDAC/synopsys: Drop internal CE and UE counters EDAC/synopsys: Drop local to_mci() macro definition EDAC/synopsys: Drop struct ecc_error_info.blknr field EDAC/synopsys: Shorten out struct ecc_error_info.bankgrpnr field name EDAC/synopsys: Drop redundant info from the error messages EDAC/mc: Init DIMM labels in MC registration method EDAC/mc: Add generic unique MC index allocation procedure EDAC/mc: Re-use generic unique MC index allocation procedure EDAC/synopsys: Detach Zynq A05 DDRC support to separate driver EDAC/synopsys: Drop unused platform-specific setup API EDAC/synopsys: Unify CSRs macro declarations EDAC/synopsys: Unify struct/macro/function prefixes EDAC/synopsys: Convert to using BIT/GENMASK/FIELD_x macros MAINTAINERS | 1 + drivers/edac/Kconfig | 9 +- drivers/edac/Makefile | 1 + drivers/edac/dmc520_edac.c | 4 +- drivers/edac/edac_mc.c | 135 ++++- drivers/edac/edac_mc.h | 4 + drivers/edac/pasemi_edac.c | 5 +- drivers/edac/ppc4xx_edac.c | 5 +- drivers/edac/synopsys_edac.c | 967 ++++++++++++----------------------- drivers/edac/zynq_edac.c | 501 ++++++++++++++++++ 10 files changed, 963 insertions(+), 669 deletions(-) create mode 100644 drivers/edac/zynq_edac.c Reviewed-by: Shubhrajyoti Datta