From patchwork Fri Mar 8 15:46:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 13586979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1DCDC54E4A for ; Fri, 8 Mar 2024 15:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4gT/WPfNTCHkoDuq69QOJKvFeVvlal6D/HaRxrr4J5o=; b=R+b8nwmwN/5r10 tLt5aj6bI981xPZYQN88m9qWw8KBFDgLhcB3bDDebzve2+ANofTEep9JWN9wVMUFpeMLp2HkY04id AKEvbFvKdLQHGdatY0r3vD6fORLg8UFJobEQ6JKxoAkW1j63/KVQKsj41mjtrPUluc04p4YXkiq73 GIJZWTS6U9ZOEXyI5hY/ox8GLREXHf/fy2mc4w9gbC6+DQxVo+S8rarzzhAEblokmv5VcHapiopME o9r6oXDhUu5XE3GWVaGiwaKeloYee4lHjBjpt/zDSyz2pp6IN5ibeAPHpvT0yI1JyzPvgaVuxU0DW 9VpmT+zgE6xTcHEPxVVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ricQf-00000009xqX-30bt; Fri, 08 Mar 2024 15:46:37 +0000 Received: from smtp-8fa8.mail.infomaniak.ch ([83.166.143.168]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ricQV-00000009xj3-2t0R for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 15:46:31 +0000 Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TrrB83ylpzMpsfS; Fri, 8 Mar 2024 16:46:24 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4TrrB76PDrz3X; Fri, 8 Mar 2024 16:46:23 +0100 (CET) From: Quentin Schulz Subject: [PATCH v2 0/3] rockchip: small DTS fixes for RK3399 Puma Date: Fri, 08 Mar 2024 16:46:06 +0100 Message-Id: <20240308-puma-diode-pu-v2-0-309f83da110a@theobroma-systems.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAL4y62UC/3WMwQ6DIBBEf8XsuTSA0Jqe/I/Gg8Ba96AYlpoa4 7+Xeu9t3mTm7cCYCBke1Q4JV2KKcwF9qcCP/fxCQaEwaKmNrGUjlvfUi0AxYIlCBT0Ya5XDW4D yWRIO9Dl9z67wSJxj2k79qn7tP9OqhBTa1Y2xd+eDl20eMboUy4g3zjjx1ccJuuM4vk+Qhk62A AAA To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Klaus Goger , Quentin Schulz , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz , Dragan Simic X-Mailer: b4 0.13.0 X-Infomaniak-Routing: alpha X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_074628_064469_30C4BA43 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There's a pull-up missing on a pin that is used as GPIO input for PCIe which will make the diode/level-shifter not let voltage pass and thus not allowing the state of the pin to change. Also add the missing regulators for the PCIe PHY+connector though this is purely cosmetic. There's also a missing PU on the USB ID pin used as a GPIO input, so let's add it for the same reasons as the one used for PCIe listed above. Note there's a light dependency on https://lore.kernel.org/linux-rockchip/43d84aa9-ce0f-406e-82ac-2a691264ee23@theobroma-systems.com/T/#ma0499cbc5e5c20f1a4c6b8452baa2d296abe2d0d to prevent a git conflict for the maintainer(s). Signed-off-by: Quentin Schulz --- Changes in v2: - added underscore in regulator names to match schematics, - reworded commit log for PCIE_WAKE# pull-up as suggested off-list by Heiko, - Link to v1: https://lore.kernel.org/r/20240308-puma-diode-pu-v1-0-2b38457bcdc0@theobroma-systems.com --- Quentin Schulz (3): arm64: dts: rockchip: enable internal pull-up on Q7_USB_ID for RK3399 Puma arm64: dts: rockchip: enable internal pull-up on PCIE_WAKE# for RK3399 Puma arm64: dts: rockchip: add regulators for PCIe on RK3399 Puma Haikou .../arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 33 +++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) --- base-commit: 370e52abbf8306f09b0022995ad7ccdff3a834bb change-id: 20240308-puma-diode-pu-1d2f4551be6d Best regards,