mbox series

[v2,0/3] firmware: arm_ffa: Add support to run inside a guest/VM under a hypervisor

Message ID 20240411-ffa_npi_support-v2-0-927a670254e6@arm.com (mailing list archive)
Headers show
Series firmware: arm_ffa: Add support to run inside a guest/VM under a hypervisor | expand

Message

Sudeep Holla April 11, 2024, 12:57 p.m. UTC
Add support for running the driver inside a guest/VM under a hypervisor.

The main difference include:
1. supporting introducing notification pending interrupt and
2. Avoiding creation of all the notification bitmaps as they must be
   created by the hypervisor before the VM is initialised

The guest may need to use a notification pending interrupt instead of
or in addition to the schedule receiver interrupt.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
Hi Jens,

This is almost identical to you single patch now. Just split into
3 patches with refactoring kept separate. Can you please check if
this continues to work on your setup(unlikely to break anything).
Once you confirm, I am happy to queue it.

Regards,
Sudeep

Changes in v2:
- Dropped the idea of SRI or NPI support
- Added back both SRI and NPI to co-exist as in the original patch
  from Jens
  https://lore.kernel.org/all/20240325081335.2326979-1-jens.wiklander@linaro.org/
- Link to v1: https://lore.kernel.org/r/20240410-ffa_npi_support-v1-0-1a5223391bd1@arm.com

---
Jens Wiklander (2):
      firmware: arm_ffa: Skip creation of the notification bitmaps
      firmware: arm_ffa: Add support for handling notification pending interrupt(NPI)

Sudeep Holla (1):
      firmware: arm_ffa: Refactor SRI handling in prepartion to add NPI support

 drivers/firmware/arm_ffa/driver.c | 128 ++++++++++++++++++++++++++------------
 1 file changed, 87 insertions(+), 41 deletions(-)
---
base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702
change-id: 20240410-ffa_npi_support-98edfdcc4882

Best regards,

Comments

Jens Wiklander April 11, 2024, 1:30 p.m. UTC | #1
Hi Sudeep,

On Thu, Apr 11, 2024 at 2:57 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Add support for running the driver inside a guest/VM under a hypervisor.
>
> The main difference include:
> 1. supporting introducing notification pending interrupt and
> 2. Avoiding creation of all the notification bitmaps as they must be
>    created by the hypervisor before the VM is initialised
>
> The guest may need to use a notification pending interrupt instead of
> or in addition to the schedule receiver interrupt.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> Hi Jens,
>
> This is almost identical to you single patch now. Just split into
> 3 patches with refactoring kept separate. Can you please check if
> this continues to work on your setup(unlikely to break anything).
> Once you confirm, I am happy to queue it.

Works for me:
Tested-by: Jens Wiklander <jens.wiklander@linaro.org>

Thanks,
Jens

>
> Regards,
> Sudeep
>
> Changes in v2:
> - Dropped the idea of SRI or NPI support
> - Added back both SRI and NPI to co-exist as in the original patch
>   from Jens
>   https://lore.kernel.org/all/20240325081335.2326979-1-jens.wiklander@linaro.org/
> - Link to v1: https://lore.kernel.org/r/20240410-ffa_npi_support-v1-0-1a5223391bd1@arm.com
>
> ---
> Jens Wiklander (2):
>       firmware: arm_ffa: Skip creation of the notification bitmaps
>       firmware: arm_ffa: Add support for handling notification pending interrupt(NPI)
>
> Sudeep Holla (1):
>       firmware: arm_ffa: Refactor SRI handling in prepartion to add NPI support
>
>  drivers/firmware/arm_ffa/driver.c | 128 ++++++++++++++++++++++++++------------
>  1 file changed, 87 insertions(+), 41 deletions(-)
> ---
> base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702
> change-id: 20240410-ffa_npi_support-98edfdcc4882
>
> Best regards,
> --
> Regards,
> Sudeep
>
Sudeep Holla April 11, 2024, 2:30 p.m. UTC | #2
On Thu, Apr 11, 2024 at 03:30:41PM +0200, Jens Wiklander wrote:
> Hi Sudeep,
> 
> On Thu, Apr 11, 2024 at 2:57 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > Add support for running the driver inside a guest/VM under a hypervisor.
> >
> > The main difference include:
> > 1. supporting introducing notification pending interrupt and
> > 2. Avoiding creation of all the notification bitmaps as they must be
> >    created by the hypervisor before the VM is initialised
> >
> > The guest may need to use a notification pending interrupt instead of
> > or in addition to the schedule receiver interrupt.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > Hi Jens,
> >
> > This is almost identical to you single patch now. Just split into
> > 3 patches with refactoring kept separate. Can you please check if
> > this continues to work on your setup(unlikely to break anything).
> > Once you confirm, I am happy to queue it.
> 
> Works for me:
> Tested-by: Jens Wiklander <jens.wiklander@linaro.org>
> 

Thanks !
Sudeep Holla April 18, 2024, 10:01 a.m. UTC | #3
On Thu, 11 Apr 2024 13:57:31 +0100, Sudeep Holla wrote:
> Add support for running the driver inside a guest/VM under a hypervisor.
>
> The main difference include:
> 1. supporting introducing notification pending interrupt and
> 2. Avoiding creation of all the notification bitmaps as they must be
>    created by the hypervisor before the VM is initialised
>
> [...]

Applied to sudeep.holla/linux (for-next/ffa/updates), thanks!

[1/3] firmware: arm_ffa: Skip creation of the notification bitmaps
      https://git.kernel.org/sudeep.holla/c/2b9c66d1abac
[2/3] firmware: arm_ffa: Refactor SRI handling in prepartion to add NPI support
      https://git.kernel.org/sudeep.holla/c/f936c242553f
[3/3] firmware: arm_ffa: Add support for handling notification pending interrupt(NPI)
      https://git.kernel.org/sudeep.holla/c/08530a2aa921
--
Regards,
Sudeep