mbox series

[0/2] Add support for the dual-role dwc3 controllers on rk3588-tiger

Message ID 20240418210332.2394871-1-heiko@sntech.de (mailing list archive)
Headers show
Series Add support for the dual-role dwc3 controllers on rk3588-tiger | expand

Message

Heiko Stuebner April 18, 2024, 9:03 p.m. UTC
A comment fix and then the addition of the nodes for the dwc3 controllers
using the newly merged usbdp phys.

Heiko Stuebner (2):
  arm64: dts: rockchip: fix comment for upper usb3 port
  arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou

 .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 60 ++++++++++++++++++-
 .../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 15 +++++
 2 files changed, 74 insertions(+), 1 deletion(-)

Comments

Rob Herring April 19, 2024, 10:24 p.m. UTC | #1
On Thu, 18 Apr 2024 23:03:30 +0200, Heiko Stuebner wrote:
> A comment fix and then the addition of the nodes for the dwc3 controllers
> using the newly merged usbdp phys.
> 
> Heiko Stuebner (2):
>   arm64: dts: rockchip: fix comment for upper usb3 port
>   arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou
> 
>  .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 60 ++++++++++++++++++-
>  .../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 15 +++++
>  2 files changed, 74 insertions(+), 1 deletion(-)
> 
> --
> 2.39.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588-tiger-haikou.dtb' for 20240418210332.2394871-1-heiko@sntech.de:

arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: /extcon-usb3: failed to match any schema with compatible: ['linux,extcon-usb-gpio']
Heiko Stuebner April 22, 2024, 7:43 a.m. UTC | #2
Hi Rob,

Am Samstag, 20. April 2024, 00:24:23 CEST schrieb Rob Herring:
> On Thu, 18 Apr 2024 23:03:30 +0200, Heiko Stuebner wrote:
> > A comment fix and then the addition of the nodes for the dwc3 controllers
> > using the newly merged usbdp phys.
> > 
> > Heiko Stuebner (2):
> >   arm64: dts: rockchip: fix comment for upper usb3 port
> >   arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou
> > 
> >  .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 60 ++++++++++++++++++-
> >  .../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 15 +++++
> >  2 files changed, 74 insertions(+), 1 deletion(-)
> > 
> > --
> > 2.39.2
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y rockchip/rk3588-tiger-haikou.dtb' for 20240418210332.2394871-1-heiko@sntech.de:
> 
> arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dtb: /extcon-usb3: failed to match any schema with compatible: ['linux,extcon-usb-gpio']

This follows the txt-binding from
	https://www.kernel.org/doc/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
so in mainline there is no yaml binding yet for the usb-id-extcon.

Though I did find a still pending yaml conversion for it in
	https://lore.kernel.org/linux-arm-kernel/20240215093214.796821-1-alexander.stein@ew.tq-group.com/T/

Though not sure what the holdup is there as it got a Review from you?
Can you just pick this for the main dt-tree?


Heiko