From patchwork Mon Apr 29 14:02:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13647027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A4B4C4345F for ; Mon, 29 Apr 2024 14:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5gPVUbwYDY4KSJ7v157QmZY1zhuzyF5Pk/2qVxs4l1Y=; b=dIcOtpayxguNq/ gdrD7J2iR5QY0s62r/iTdk3T69qHzBWq3+axcfYbDCDIxdQnGtICh35IVOUyXuXJ3Iyl/DU4kPo/F MCq25I3TU+PIG9g8R+wpSq34YWXmI3OEh/dKoSgDVk3rF4dmLP1eaG3gQh/S/U2/wPGsLChjzrvF8 sVqaoIxd27yP1WWcz8mInm1CLraW0XJmTRWeRIagBqNtZupNAevRqH35mSuXSVS9hLbN7PnACX8Jy CTIC5QJhhdH2BxQQyi0XBxtec7x/OEWLJTvJqcP9GsmRwk8SewdV7q3W+CjUY9HMTTLair0q4t3Kn jix3EPUmfKrb8Ta9IBEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1RaJ-000000032O5-1D6N; Mon, 29 Apr 2024 14:02:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1RaG-000000032ND-1V0S for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 14:02:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C7282F4; Mon, 29 Apr 2024 07:02:45 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3E153F793; Mon, 29 Apr 2024 07:02:16 -0700 (PDT) From: Ryan Roberts To: Catalin Marinas , Will Deacon , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , David Hildenbrand , Peter Xu , Mike Rapoport , Shivansh Vij Cc: Ryan Roberts , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] arm64/mm: Enable userfaultfd write-protect Date: Mon, 29 Apr 2024 15:02:04 +0100 Message-Id: <20240429140208.238056-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_070220_483516_5A8FDCEE X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi All, This series adds uffd write-protect support for arm64. Previous attempts to add uffd-wp (and soft-dirty) have failed because of a perceived lack of available PTE SW bits. However it actually turns out that there are 2 available but they are hidden. PTE_PROT_NONE was previously occupying a SW bit, but can be moved, freeing up the SW bit. Bit 63 is marked as "IGNORED" in the Arm ARM, but it does not currently indicate "reserved for SW use" like it does for the other SW bits. I've confirmed with the spec owner that this is an oversight; the bit is intended to be reserved for SW use and the spec will clarify this in a future update. So now we have two spare bits; patch 3 enables uffd-wp on arm64, using the SW bit freed up by moving PTE_PROT_NONE. This leaves bit 63 spare for future use (e.g. soft-dirty - see RFC at [2] - or some other usage). --- This applies on top of v6.9-rc5. All mm selftests involving uffd-wp now run. However, this work exposed a bug in core-mm that was leading to some test uffd-wp failures in the pagemap_ioctl test. The fix for that is posted at [3]. With the fix applied, all the uffd-wp tests pass and no other selftest regressions are observed. Changes since v1 [1] ==================== patch 1 & 2 (was patch 1): - generalized PMD_PRESENT_INVALID into PTE_INVALID - removed explicit PTE_PROT_NONE bit patch 3 (was patch 2): - collected R-b/A-b from Peter and Catalin - thanks! [1] https://lore.kernel.org/linux-arm-kernel/20240424111017.3160195-1-ryan.roberts@arm.com/ [2] https://lore.kernel.org/all/20240419074344.2643212-1-ryan.roberts@arm.com/ [3] https://lore.kernel.org/all/20240429114104.182890-1-ryan.roberts@arm.com/ Thanks, Ryan Ryan Roberts (3): arm64/mm: Refactor PMD_PRESENT_INVALID and PTE_PROT_NONE bits arm64/mm: Move PTE_INVALID to overlay PTE_NS arm64/mm: Add uffd write-protect support arch/arm64/Kconfig | 1 + arch/arm64/include/asm/pgtable-hwdef.h | 1 + arch/arm64/include/asm/pgtable-prot.h | 17 ++--- arch/arm64/include/asm/pgtable.h | 88 +++++++++++++++++++------- 4 files changed, 75 insertions(+), 32 deletions(-) -- 2.25.1