| Message ID | 20240430045853.3894633-1-Kelly_Hung@asus.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | modify Signed-off-by field | expand |
Dear Kelly, Am 30.04.24 um 06:58 schrieb Kelly Hung: > For the warning message: > From: Kelly Hung '<ppighouse@gmail.com>' != 'Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>' > > I replaced Kelly_Hung@asus.com with my private Gmail account. > > Due to a security issue with ASUS's mail server, I am unable to use > ASUS's mail system to send patches out from my build server. > So I executed git send-email using my private gmail account. To put light on ASUS’ upstream work, using your company address would be nice in my opinion. Do you have it configured everything in git (`~/.gitconfig`)? git config --global user.name "Kelly Hung" git config --global user.email Kelly_Hung@asus.com Then `git format-patch` and `git send-email` should put From: Kelly Hung <Kelly_Hung@asus.com> at the top of the message. Kind regards, Paul
Dear Chia, Thank you for your reply. I am sorry, this causes so much trouble. Am 30.04.24 um 12:04 schrieb Chia Li Hung: > Paul Menzel 於 2024年4月30日 週二 下午2:48寫道： >> Am 30.04.24 um 06:58 schrieb Kelly Hung: >>> For the warning message: >>> From: Kelly Hung '<ppighouse@gmail.com>' != 'Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>' >>> >>> I replaced Kelly_Hung@asus.com with my private Gmail account. >>> >>> Due to a security issue with ASUS's mail server, I am unable to use >>> ASUS's mail system to send patches out from my build server. >>> So I executed git send-email using my private gmail account. >> >> To put light on ASUS’ upstream work, using your company address would be >> nice in my opinion. Do you have it configured everything in git >> (`~/.gitconfig`)? >> >> git config --global user.name "Kelly Hung" >> git config --global user.email Kelly_Hung@asus.com > Below is my git configuration. > [user] > name = Kelly Hung > email = Kelly_Hung@asus.com > [sendemail] > smtpserver = smtp.gmail.com > smtpEncryption = tls > smtpUser = ppighouse@gmail.com > smtpServerPort = 587 > > I made sure the "From" value after executing git format-patch was my ASUS > email address. > > From: Kelly Hung <Kelly_Hung@asus.com> > Date: Thu, 29 Feb 2024 16:45:02 +0800 > Subject: [PATCH v7 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board > > Since my smtp server is Gmail, when I run send-gmail it replaces my "From" > value with the Gmail account. I asked ASUS IT for assistance today and > tried to get an SMTP acount. *A thing you should know if you are using multiple email accounts with `git send-email`* [1] says to use git send-email --from ppighouse@gmail.com 000*.patch Kind regards, Paul [1]: https://sjp38.github.io/post/git_send_email_multiple_email_caution/
For the warning message: From: Kelly Hung '<ppighouse@gmail.com>' != 'Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>' I replaced Kelly_Hung@asus.com with my private Gmail account. Due to a security issue with ASUS's mail server, I am unable to use ASUS's mail system to send patches out from my build server. So I executed git send-email using my private gmail accoutt. Kelly Hung (2): dt-bindings: arm: aspeed: add ASUS X4TF board ARM: dts: aspeed: x4tf: Add dts for asus x4tf project .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts | 581 ++++++++++++++++++ 3 files changed, 583 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts