mbox series

[v4,00/11] Series to deliver Ethernet for STM32MP13

Message ID 20240604143502.154463-1-christophe.roullier@foss.st.com (mailing list archive)
Headers show
Series Series to deliver Ethernet for STM32MP13 | expand

Message

Christophe Roullier June 4, 2024, 2:34 p.m. UTC
STM32MP13 is STM32 SOC with 2 GMACs instances
    GMAC IP version is SNPS 4.20.
    GMAC IP configure with 1 RX and 1 TX queue.
    DMA HW capability register supported
    RX Checksum Offload Engine supported
    TX Checksum insertion supported
    Wake-Up On Lan supported
    TSO supported
Rework dwmac glue to simplify management for next stm32 (integrate RFC from Marek)

V2: - Remark from Rob Herring (add Krzysztof's ack in patch 02/11, update in yaml)
      Remark from Serge Semin (upate commits msg)
V3: - Remove PHY regulator patch and Ethernet2 DT because need to clarify how to
      manage PHY regulator (in glue or PHY side)
    - Integrate RFC from Marek
    - Remark from Rob Herring in YAML documentation
V4: - Remark from Marek (remove max-speed, extra space in DT, update commit msg)
    - Remark from Rasmus (add sign-off, add base-commit)
    - Remark from Sai Krishna Gajula

Christophe Roullier (6):
  dt-bindings: net: add STM32MP13 compatible in documentation for stm32
  net: ethernet: stmmac: add management of stm32mp13 for stm32
  ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13
  ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board
  ARM: dts: stm32: add ethernet1 for STM32MP135F-DK board
  ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support

Marek Vasut (5):
  net: stmmac: dwmac-stm32: Separate out external clock rate validation
  net: stmmac: dwmac-stm32: Separate out external clock selector
  net: stmmac: dwmac-stm32: Extract PMCR configuration
  net: stmmac: dwmac-stm32: Clean up the debug prints
  net: stmmac: dwmac-stm32: Fix Mhz to MHz

 .../devicetree/bindings/net/stm32-dwmac.yaml  |  41 ++++-
 arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi   |  71 ++++++++
 arch/arm/boot/dts/st/stm32mp131.dtsi          |  38 ++++
 arch/arm/boot/dts/st/stm32mp133.dtsi          |  31 ++++
 arch/arm/boot/dts/st/stm32mp135f-dk.dts       |  23 +++
 arch/arm/configs/multi_v7_defconfig           |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 172 ++++++++++++++----
 7 files changed, 330 insertions(+), 47 deletions(-)


base-commit: cd0057ad75116bacf16fea82e48c1db642971136

Comments

Rob Herring (Arm) June 4, 2024, 3:29 p.m. UTC | #1
On Tue, 04 Jun 2024 16:34:51 +0200, Christophe Roullier wrote:
> STM32MP13 is STM32 SOC with 2 GMACs instances
>     GMAC IP version is SNPS 4.20.
>     GMAC IP configure with 1 RX and 1 TX queue.
>     DMA HW capability register supported
>     RX Checksum Offload Engine supported
>     TX Checksum insertion supported
>     Wake-Up On Lan supported
>     TSO supported
> Rework dwmac glue to simplify management for next stm32 (integrate RFC from Marek)
> 
> V2: - Remark from Rob Herring (add Krzysztof's ack in patch 02/11, update in yaml)
>       Remark from Serge Semin (upate commits msg)
> V3: - Remove PHY regulator patch and Ethernet2 DT because need to clarify how to
>       manage PHY regulator (in glue or PHY side)
>     - Integrate RFC from Marek
>     - Remark from Rob Herring in YAML documentation
> V4: - Remark from Marek (remove max-speed, extra space in DT, update commit msg)
>     - Remark from Rasmus (add sign-off, add base-commit)
>     - Remark from Sai Krishna Gajula
> 
> Christophe Roullier (6):
>   dt-bindings: net: add STM32MP13 compatible in documentation for stm32
>   net: ethernet: stmmac: add management of stm32mp13 for stm32
>   ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13
>   ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board
>   ARM: dts: stm32: add ethernet1 for STM32MP135F-DK board
>   ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support
> 
> Marek Vasut (5):
>   net: stmmac: dwmac-stm32: Separate out external clock rate validation
>   net: stmmac: dwmac-stm32: Separate out external clock selector
>   net: stmmac: dwmac-stm32: Extract PMCR configuration
>   net: stmmac: dwmac-stm32: Clean up the debug prints
>   net: stmmac: dwmac-stm32: Fix Mhz to MHz
> 
>  .../devicetree/bindings/net/stm32-dwmac.yaml  |  41 ++++-
>  arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi   |  71 ++++++++
>  arch/arm/boot/dts/st/stm32mp131.dtsi          |  38 ++++
>  arch/arm/boot/dts/st/stm32mp133.dtsi          |  31 ++++
>  arch/arm/boot/dts/st/stm32mp135f-dk.dts       |  23 +++
>  arch/arm/configs/multi_v7_defconfig           |   1 +
>  .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 172 ++++++++++++++----
>  7 files changed, 330 insertions(+), 47 deletions(-)
> 
> 
> base-commit: cd0057ad75116bacf16fea82e48c1db642971136
> --
> 2.25.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dk.dtb' for 20240604143502.154463-1-christophe.roullier@foss.st.com:

arch/arm/boot/dts/st/stm32mp135f-dk.dtb: adc@48003000: 'ethernet@5800e000' does not match any of the regexes: '^adc@[0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
Christophe Roullier June 4, 2024, 4:24 p.m. UTC | #2
On 6/4/24 17:29, Rob Herring (Arm) wrote:
> On Tue, 04 Jun 2024 16:34:51 +0200, Christophe Roullier wrote:
>> STM32MP13 is STM32 SOC with 2 GMACs instances
>>      GMAC IP version is SNPS 4.20.
>>      GMAC IP configure with 1 RX and 1 TX queue.
>>      DMA HW capability register supported
>>      RX Checksum Offload Engine supported
>>      TX Checksum insertion supported
>>      Wake-Up On Lan supported
>>      TSO supported
>> Rework dwmac glue to simplify management for next stm32 (integrate RFC from Marek)
>>
>> V2: - Remark from Rob Herring (add Krzysztof's ack in patch 02/11, update in yaml)
>>        Remark from Serge Semin (upate commits msg)
>> V3: - Remove PHY regulator patch and Ethernet2 DT because need to clarify how to
>>        manage PHY regulator (in glue or PHY side)
>>      - Integrate RFC from Marek
>>      - Remark from Rob Herring in YAML documentation
>> V4: - Remark from Marek (remove max-speed, extra space in DT, update commit msg)
>>      - Remark from Rasmus (add sign-off, add base-commit)
>>      - Remark from Sai Krishna Gajula
>>
>> Christophe Roullier (6):
>>    dt-bindings: net: add STM32MP13 compatible in documentation for stm32
>>    net: ethernet: stmmac: add management of stm32mp13 for stm32
>>    ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13
>>    ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board
>>    ARM: dts: stm32: add ethernet1 for STM32MP135F-DK board
>>    ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support
>>
>> Marek Vasut (5):
>>    net: stmmac: dwmac-stm32: Separate out external clock rate validation
>>    net: stmmac: dwmac-stm32: Separate out external clock selector
>>    net: stmmac: dwmac-stm32: Extract PMCR configuration
>>    net: stmmac: dwmac-stm32: Clean up the debug prints
>>    net: stmmac: dwmac-stm32: Fix Mhz to MHz
>>
>>   .../devicetree/bindings/net/stm32-dwmac.yaml  |  41 ++++-
>>   arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi   |  71 ++++++++
>>   arch/arm/boot/dts/st/stm32mp131.dtsi          |  38 ++++
>>   arch/arm/boot/dts/st/stm32mp133.dtsi          |  31 ++++
>>   arch/arm/boot/dts/st/stm32mp135f-dk.dts       |  23 +++
>>   arch/arm/configs/multi_v7_defconfig           |   1 +
>>   .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 172 ++++++++++++++----
>>   7 files changed, 330 insertions(+), 47 deletions(-)
>>
>>
>> base-commit: cd0057ad75116bacf16fea82e48c1db642971136
>> --
>> 2.25.1
>>
>>
>>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>    pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dk.dtb' for 20240604143502.154463-1-christophe.roullier@foss.st.com:
>
> arch/arm/boot/dts/st/stm32mp135f-dk.dtb: adc@48003000: 'ethernet@5800e000' does not match any of the regexes: '^adc@[0-9]+$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
>
Hi Rob,

I will provide v5 to fix it.

Thanks

>
>
>