From patchwork Tue Jun 25 17:25:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13711714 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F6F0C2BBCA for ; Tue, 25 Jun 2024 17:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Mime-Version:Message-Id:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=fBtNvIbgeXhFX/mpmhNLQiRrqYWtpqiLi29bwI4m2nc=; b=H8HnPLzKAWKIluXSLMP47Zkp0f RRVzqN71Zn2wIQtFiRoWR97e8Hji0DSYcigtIuYN2oJf4aImZ6ZWJGmMs+O7CjVstcUKqEgeJpq6N NC8XMkIrJ7vjR/lgeNUrcHaG6xjWuFrQKYtTRWxR5q7gi0/XmJw0WTBMm/0QFBgYB4/rvXK/RndSr KxXgffIypnncEyNxlctc8aoBtI3Spe/ha4pARhm/kMgqvRHq464cMwks5agEuqLd32jeZzZpHfRUl eiwTvqL+wmkTTm9OkPSLRnrvjiRUjvIZQW097SPRz/QMkYItikyDtGEG8GOiTyeRRW6prrsuYPXIl 54RJpkYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM9vu-00000003sSv-1LHc; Tue, 25 Jun 2024 17:26:18 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM9vm-00000003sPp-2zuG for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 17:26:11 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-64399573fd3so86217087b3.0 for ; Tue, 25 Jun 2024 10:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719336368; x=1719941168; darn=lists.infradead.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=fBtNvIbgeXhFX/mpmhNLQiRrqYWtpqiLi29bwI4m2nc=; b=ldrRFkInLawQzLybWXzNLn9lzEXPVOaR/BtuzN4WrUo3KidZJ7EHj/mtsT8KyCh7hz U4YbuaApPRSMANTRXYSNP2FrHKaGPPNB7QG30CPj8tm7GbcfAtoHoXoBXcErFbhxqi/v yzAf7UpK72UMHF/dnAHliIZ1KAiVA1iwWNwX5lFCB1YdjPX6icfpbx6tvXleiYyUrwYF zVvsBdDRnSK34wHz1cFIY2RvuzsFHwLzH6/gKHBFnRtaxE/COF6H4vEp6jQTkvIRvOIe XUTtN24PR8tAA2OAMJnF+YSJub5IGtsNkupzDYlZHkyYtCWZf2lzANqCt7JK7o55pmvh UwEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719336368; x=1719941168; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fBtNvIbgeXhFX/mpmhNLQiRrqYWtpqiLi29bwI4m2nc=; b=rOP49eZBOeE5jVUzN6RrCkG31CWLvswg5g42ADDfAXVFEdFMBdWPlonL3OsU476LKg SyBBnuVd2uWLR9Mm4k63C0eQwdK6CbYpz6v3B4MagVmATdErruWsnCBG/laMoeMaWejW iNlnHUOk+xE2iREG1IN8lLeijWjgb00/M+uLCOplVwnmAwTme+BVU0GsfCHv8NBXJ8Wp pXc3vhehpVRMaeIkdaxMknB5lhwGjoab3oclenjOHVztNxyLbzfo2ub0wC3pJwyXVJap RxYxgwsdiL4788HHnDohn+Ni7TLbkJXZFZH6dh7hBxqnnyv/ZMYokOOjG2/pe07YF2og 4kJA== X-Forwarded-Encrypted: i=1; AJvYcCU08oc0Eepe46IMwbIJ+peGByw9xn1Z8qRxJX2a1wx+mcPyh73kgnDZRJQmg1xgD5sdiFpjoVT1zAhuaJ118zAwwQlTSA51FvuqZSzwg2S8QRKFUIE= X-Gm-Message-State: AOJu0Ywd30WZIJQbkGfnS6dYTsyoQThef5Y0dKfu7ZP0r1SwjqP1lG9f mxYbShXpDeG7nXfUGwty/YwKsnREyHqtf8BRzwAllSl2yuAFeHcJplzTHmdGBVFK+K3krPUmA3E VprMaJQ== X-Google-Smtp-Source: AGHT+IENrGELXvRDCJiRLBdPp2h3dHb67HAIy3m65ItxGzzGqUmFAw/zmAvgosPietAoOpog2VycAm0oqsZU X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:b4cb:a52b:f9ea:8678]) (user=irogers job=sendgmr) by 2002:a05:690c:ecd:b0:61d:4701:5e66 with SMTP id 00721157ae682-643ab455a9dmr5525947b3.2.1719336367698; Tue, 25 Jun 2024 10:26:07 -0700 (PDT) Date: Tue, 25 Jun 2024 10:25:37 -0700 Message-Id: <20240625172603.900667-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v1 00/26] Constify tool pointers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_102610_810048_6674FCEF X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations. This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command. Ian Rogers (26): perf tool: Constify tool pointers perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init perf kmem: Use perf_tool__init perf buildid-list: Use perf_tool__init perf kvm: Use perf_tool__init perf lock: Use perf_tool__init perf evlist: Use perf_tool__init perf record: Use perf_tool__init perf c2c: Use perf_tool__init perf script: Use perf_tool__init perf inject: Use perf_tool__init perf report: Use perf_tool__init perf stat: Use perf_tool__init perf annotate: Use perf_tool__init perf sched: Use perf_tool__init perf mem: Use perf_tool__init perf timechart: Use perf_tool__init perf diff: Use perf_tool__init perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf auxevent: Add explicit dummy tool initialization perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init perf tool: Remove perf_tool__fill_defaults perf session: Constify tool tools/perf/arch/x86/util/event.c | 4 +- tools/perf/bench/synthesize.c | 2 +- tools/perf/builtin-annotate.c | 44 ++-- tools/perf/builtin-buildid-list.c | 10 + tools/perf/builtin-c2c.c | 33 ++- tools/perf/builtin-diff.c | 30 ++- tools/perf/builtin-evlist.c | 10 +- tools/perf/builtin-inject.c | 159 +++++++------ tools/perf/builtin-kmem.c | 20 +- tools/perf/builtin-kvm.c | 19 +- tools/perf/builtin-kwork.c | 33 ++- tools/perf/builtin-lock.c | 41 ++-- tools/perf/builtin-mem.c | 37 +-- tools/perf/builtin-record.c | 49 ++-- tools/perf/builtin-report.c | 67 +++--- tools/perf/builtin-sched.c | 50 ++-- tools/perf/builtin-script.c | 106 ++++----- tools/perf/builtin-stat.c | 26 +-- tools/perf/builtin-timechart.c | 25 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 4 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/dlfilter-test.c | 2 +- tools/perf/tests/dwarf-unwind.c | 2 +- tools/perf/tests/event_update.c | 9 +- tools/perf/tests/stat.c | 6 +- tools/perf/tests/thread-map.c | 2 +- tools/perf/util/Build | 1 + tools/perf/util/arm-spe.c | 9 +- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 20 +- tools/perf/util/bpf-event.c | 4 +- tools/perf/util/build-id.c | 34 +-- tools/perf/util/build-id.h | 8 +- tools/perf/util/cs-etm.c | 9 +- tools/perf/util/data-convert-bt.c | 34 ++- tools/perf/util/data-convert-json.c | 47 ++-- tools/perf/util/event.c | 54 +++-- tools/perf/util/event.h | 38 ++-- tools/perf/util/header.c | 6 +- tools/perf/util/header.h | 4 +- tools/perf/util/hisi-ptt.c | 6 +- tools/perf/util/intel-bts.c | 9 +- tools/perf/util/intel-pt.c | 10 +- tools/perf/util/jitdump.c | 4 +- tools/perf/util/s390-cpumsf.c | 7 +- tools/perf/util/session.c | 342 ++-------------------------- tools/perf/util/session.h | 6 +- tools/perf/util/synthetic-events.c | 80 +++---- tools/perf/util/synthetic-events.h | 70 +++--- tools/perf/util/tool.c | 294 ++++++++++++++++++++++++ tools/perf/util/tool.h | 18 +- tools/perf/util/tsc.c | 2 +- 53 files changed, 945 insertions(+), 981 deletions(-) create mode 100644 tools/perf/util/tool.c