From patchwork Wed Jun 26 20:36:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13713393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EA40C30653 for ; Wed, 26 Jun 2024 20:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Mime-Version:Message-Id:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=c3z4mjiJwqFTlGfQGdTxhJfg4DHbpaFVUu0X6ClFmOM=; b=bl4OB6oBQ8wsD3sCPnB6og+grO KitiGD/m1zxaSnGhy51rBzesRo9+SlXAhcrIF7qibAnUny1sd99/cEg+oR2f5BEIwP6MzISBD1FBg 3JhsiDh7zV5QkPzNg3294RtN4Mxlp6uBvymgo6pb9fqv9eHBuT3n2y8+HjXJ3iBFt7snV5b+drzPG NWnB0/bI3+/Z77qnKJG6bwWpWy+RWLnynwb/e29kXxWAs6IphfpOQ4A8ilNgojfvPU3a6KA/4HfhG xECqLIIgS1TWKqHn0gezc/17xAtfz9FrfcJXXRMEGKV4EaN6CuVg9CZMPAUmYId1VB2KLeOHXu6ng /F4lZoyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMZNo-00000008F84-3WSf; Wed, 26 Jun 2024 20:36:48 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMZNg-00000008F5K-1SFu for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 20:36:42 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-63bca8ce79eso151468407b3.1 for ; Wed, 26 Jun 2024 13:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719434199; x=1720038999; darn=lists.infradead.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=c3z4mjiJwqFTlGfQGdTxhJfg4DHbpaFVUu0X6ClFmOM=; b=LcXudmCmv7BKNCNUByHnTdV7uq6CioYMBuKQp4QHV6Q59P5Lwq8jFnCIpmFCmDFbIo KGQIFDhzSInIvWIhwngIGLIRLIp5n7UTF9siWHpFnLanKtM7gXMnDoiBU80Gmld8g06R IBgHMi04U4jInst5wqKqekdxltSDbq/UPegN9i/aNLk61E2T3Rb9AmzSDXL4E7BLmjQS 8ZUPOWDi+TQUa0rglkHzb03eNLTeh0WmgJbdfSPQoMEWJXSX1Bxzorp+AoA9viDA5Fj/ kp/DcHpyBPP3pFuYYhYtpr/ZDnogMXc3YOGorTb0KTD9fBefrzc0pyVj9uhJ6WorDCH3 08DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719434199; x=1720038999; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=c3z4mjiJwqFTlGfQGdTxhJfg4DHbpaFVUu0X6ClFmOM=; b=TbNIWap0YSe83gKt64kvOD5xw0+Je9b019jZhlyNPS9M48ueLjAAqhhQWqxBnyFMjL BrstwxSXTB6ocrQghg8+o2vSHJDh+/WK2G1VYIsW+hb6dMeSH0V/GAEBquEEmmJFDTPK ZbF8MG3J9L6pPT0P3pFCNljg/y/rwHFUZl60QWCZQgVss2WlxBPSANulT1NdJyALN656 9G0Wlf0/ApfzrdcCJufEhVPQNzEku8XT6JQ8vbvbg6gghgaW65hmMQs94cdQWQZrBsQo ZepyMMMSuS+ndS7Aw4B7lc9K3YGO3hiDblQ6qaA0k/N9PRBgoUtgtCMwA+ZcvIF6BMFu nG3Q== X-Forwarded-Encrypted: i=1; AJvYcCUbHO/aMPDUBx5lZrbI4KldIKjttqq1SbBLW79+giELfBjonrmYM1DuuZN9d/oxz7ELt22SQwuB+A1h6GT3I5dVOQSUod2gFqytDnbc6738J9tR+7k= X-Gm-Message-State: AOJu0Yw9hTbD7+Qfd8xP2Tye2QDGe9qFeF1j9kTV5RzhAFecdqZvHaYh SrD8iqWq2MkXbUBB3pJpOvIYEn6lBexLDAb6HA5Jvla5YZ55Q811+6/jeKi2S2iH/rWBKquGtHR 8xsOh5g== X-Google-Smtp-Source: AGHT+IHQoNW7EBiDlY2CaPg02hKB+zsNGCyLVPLQP+hAr612VAXtdXj/jRAYk7bFbb1ZclTwvgVMu2EqH0eE X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:23a1:25b9:2412:56de]) (user=irogers job=sendgmr) by 2002:a05:690c:25ca:b0:62c:ea0b:a447 with SMTP id 00721157ae682-643aba49756mr2851447b3.2.1719434198766; Wed, 26 Jun 2024 13:36:38 -0700 (PDT) Date: Wed, 26 Jun 2024 13:36:02 -0700 Message-Id: <20240626203630.1194748-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v2 00/27] Constify tool pointers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_133640_450203_CE40E46C X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations. This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command. v2: Remove dummy tool initialization [Adrian] and make zero sized. Add cs-etm fix for address sanitizer build, found necessary when testing dummy tool change. Ian Rogers (27): perf auxevent: Zero size dummy tool perf cs-etm: Fix address sanitizer dso build failure perf tool: Constify tool pointers perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init perf kmem: Use perf_tool__init perf buildid-list: Use perf_tool__init perf kvm: Use perf_tool__init perf lock: Use perf_tool__init perf evlist: Use perf_tool__init perf record: Use perf_tool__init perf c2c: Use perf_tool__init perf script: Use perf_tool__init perf inject: Use perf_tool__init perf report: Use perf_tool__init perf stat: Use perf_tool__init perf annotate: Use perf_tool__init perf sched: Use perf_tool__init perf mem: Use perf_tool__init perf timechart: Use perf_tool__init perf diff: Use perf_tool__init perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init perf tool: Remove perf_tool__fill_defaults perf session: Constify tool tools/perf/arch/x86/util/event.c | 4 +- tools/perf/bench/synthesize.c | 2 +- tools/perf/builtin-annotate.c | 44 ++-- tools/perf/builtin-buildid-list.c | 10 + tools/perf/builtin-c2c.c | 33 ++- tools/perf/builtin-diff.c | 30 ++- tools/perf/builtin-evlist.c | 10 +- tools/perf/builtin-inject.c | 159 +++++++------ tools/perf/builtin-kmem.c | 20 +- tools/perf/builtin-kvm.c | 19 +- tools/perf/builtin-kwork.c | 33 ++- tools/perf/builtin-lock.c | 41 ++-- tools/perf/builtin-mem.c | 37 +-- tools/perf/builtin-record.c | 47 ++-- tools/perf/builtin-report.c | 67 +++--- tools/perf/builtin-sched.c | 50 ++-- tools/perf/builtin-script.c | 106 ++++----- tools/perf/builtin-stat.c | 26 +-- tools/perf/builtin-timechart.c | 25 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 4 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/dlfilter-test.c | 2 +- tools/perf/tests/dwarf-unwind.c | 2 +- tools/perf/tests/event_update.c | 9 +- tools/perf/tests/stat.c | 6 +- tools/perf/tests/thread-map.c | 2 +- tools/perf/util/Build | 1 + tools/perf/util/arm-spe.c | 14 +- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 20 +- tools/perf/util/bpf-event.c | 4 +- tools/perf/util/build-id.c | 34 +-- tools/perf/util/build-id.h | 8 +- tools/perf/util/cs-etm.c | 24 +- tools/perf/util/data-convert-bt.c | 34 ++- tools/perf/util/data-convert-json.c | 47 ++-- tools/perf/util/dso.h | 10 + tools/perf/util/event.c | 54 +++-- tools/perf/util/event.h | 38 ++-- tools/perf/util/header.c | 6 +- tools/perf/util/header.h | 4 +- tools/perf/util/hisi-ptt.c | 6 +- tools/perf/util/intel-bts.c | 14 +- tools/perf/util/intel-pt.c | 15 +- tools/perf/util/jitdump.c | 4 +- tools/perf/util/s390-cpumsf.c | 11 +- tools/perf/util/session.c | 342 ++-------------------------- tools/perf/util/session.h | 6 +- tools/perf/util/synthetic-events.c | 80 +++---- tools/perf/util/synthetic-events.h | 70 +++--- tools/perf/util/tool.c | 294 ++++++++++++++++++++++++ tools/perf/util/tool.h | 18 +- tools/perf/util/tsc.c | 2 +- 54 files changed, 967 insertions(+), 1001 deletions(-) create mode 100644 tools/perf/util/tool.c