mbox series

[net-next,0/2] Fixes for stm32-dwmac driver fails to probe

Message ID 20240627084917.327592-1-christophe.roullier@foss.st.com (mailing list archive)
Headers show
Series Fixes for stm32-dwmac driver fails to probe | expand

Message

Christophe Roullier June 27, 2024, 8:49 a.m. UTC 
Mark Brown found issue during stm32-dwmac probe:

For the past few days networking has been broken on the Avenger 96, a
stm32mp157a based platform.  The stm32-dwmac driver fails to probe:

<6>[    1.894271] stm32-dwmac 5800a000.ethernet: IRQ eth_wake_irq not found
<6>[    1.899694] stm32-dwmac 5800a000.ethernet: IRQ eth_lpi not found
<6>[    1.905849] stm32-dwmac 5800a000.ethernet: IRQ sfty not found
<3>[    1.912304] stm32-dwmac 5800a000.ethernet: Unable to parse OF data
<3>[    1.918393] stm32-dwmac 5800a000.ethernet: probe with driver stm32-dwmac failed with error -75

which looks a bit odd given the commit contents but I didn't look at the
driver code at all.

Full boot log here:

   https://lava.sirena.org.uk/scheduler/job/467150

A working equivalent is here:

   https://lava.sirena.org.uk/scheduler/job/466518

I delivered 2 fixes to solve issue.

Christophe Roullier (2):
  net: stmmac: dwmac-stm32: Add test to verify if ETHCK is used before
    checking clk rate
  net: stmmac: dwmac-stm32: update err status in case different of
    stm32mp13

 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


base-commit: f261aa15b2ca73d4f9dbb8b116b16743237edad9

Comments

Mark Brown June 27, 2024, 11:58 a.m. UTC | #1 
On Thu, Jun 27, 2024 at 10:49:15AM +0200, Christophe Roullier wrote:
> Mark Brown found issue during stm32-dwmac probe:
> 
> For the past few days networking has been broken on the Avenger 96, a
> stm32mp157a based platform.  The stm32-dwmac driver fails to probe:

These patches resolve the boot issue I'm seeing on this platform:

Tested-by: Mark Brown <broonie@kernel.org>