From patchwork Thu Jun 27 08:49:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Roullier X-Patchwork-Id: 13714151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98A32C2BD09 for ; Thu, 27 Jun 2024 10:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=UEPDtkwS6mWQxqmVu+aQznNw+twWmzwbU06XGY49NsQ=; b=VvXCWva0TkqLASSKiyqHEbHCfa 8+oBNSPs0/RVOlZgKZx4gt2psgb2x6K9zL68e22N6oBy5ujEDjYV+lINV3NjKi3w5UD74xa5/b+sL 2j9lKqYSP5iVDVTWoHNzCUyNKgsj3i78/72ah1G4E7Is88A+GuYKYd+LJlpJsS/RIPzMboxk1YcBq jufP5c09838E7yX7yYa95bvzh6+tdQAvcglaBnD1BYLuTXAGGy+KDlfTVgPp4g6usxE4YyxM6zyNC OB2HP20dqaZSPH6ceH4jHcqYrpQzCoWmg/eMBJEtCnBi6HDPGXybfU3xoc6kk0bmomHE+4/QVRFre N7qEY/jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmUk-00000009z44-3Pxl; Thu, 27 Jun 2024 10:36:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmTh-00000009ych-1uJg for linux-arm-kernel@bombadil.infradead.org; Thu, 27 Jun 2024 10:35:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=UEPDtkwS6mWQxqmVu+aQznNw+twWmzwbU06XGY49NsQ=; b=FgHO7qXyFyZPC8HSNzcDq2zc8+ v2NxO7KecHo9PgU8qKtzXYqUVZMGd3Q6Q8DNl8BohG9Lv9gLmIpo2oZlgFOQsVLIHzQsbUN9009NF eK7Qp/SHJoxRVE0Sf/hCbGD0afu03lDIEoqi3KclMRCNigLwsexdCt0oiRjq00eWKgpvY2+365Qov btUyNkeO7vyUzUBdncwFEW649lln9zWOZ5a5jTWOQSG3Wu7ttxWsuKnfbPaQGRKVYN/q9BAYB4BVZ gXflhs/heMh5kp4NNjqKHrtn8YjoHdDnG3AWMye8P7pHnvg/DTe4gjz05YgAGRvfi68+CUAOzSWw2 W8GJSkjQ==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMkqr-00000008lLE-31hN for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 08:52:04 +0000 Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45R6suEc025136; Thu, 27 Jun 2024 10:50:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=UEPDtkwS6mWQxqmVu+aQzn Nw+twWmzwbU06XGY49NsQ=; b=BUUDFCyWmif/XpmyOVTOfW0kNwDNQ/AfzhHnwS GwvCmHFguF5wM0+QycdeniiC8hwLqKzLuXiqEMh9P/gBnSV/Mj97TXgaGj7aXO+Y Z7gUoa8lX9zsPgoIvjATGV9F/2JIo9caF6oVWKsD3JVJ07AfiwJhGSpONwoU/cBr 09qqkoi9iTruFfzL8WK7rygh+Dk+aYR9KDY7r7YwYuGqt0apM2hQyWz9mpKm3RBf JC+dJOm7HE+eiH5iyZEB5RVhpj0JPB3duA80y4drfG1595Zb+bYn9yRxJ2r9O830 4TbbDGSMmCzbkYo1XHGilnP1n/EZkb5gJTveG3QQq3qLY+yQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3yx860tbfv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jun 2024 10:50:53 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id B238E40054; Thu, 27 Jun 2024 10:50:40 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 686BA2138E3; Thu, 27 Jun 2024 10:49:26 +0200 (CEST) Received: from localhost (10.48.86.164) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 27 Jun 2024 10:49:25 +0200 From: Christophe Roullier To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Christophe Roullier , Marek Vasut CC: , , , , Subject: [net-next,PATCH 0/2] Fixes for stm32-dwmac driver fails to probe Date: Thu, 27 Jun 2024 10:49:15 +0200 Message-ID: <20240627084917.327592-1-christophe.roullier@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.48.86.164] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-27_05,2024-06-25_01,2024-05-17_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_095152_707339_3BB19AE2 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mark Brown found issue during stm32-dwmac probe: For the past few days networking has been broken on the Avenger 96, a stm32mp157a based platform. The stm32-dwmac driver fails to probe: <6>[ 1.894271] stm32-dwmac 5800a000.ethernet: IRQ eth_wake_irq not found <6>[ 1.899694] stm32-dwmac 5800a000.ethernet: IRQ eth_lpi not found <6>[ 1.905849] stm32-dwmac 5800a000.ethernet: IRQ sfty not found <3>[ 1.912304] stm32-dwmac 5800a000.ethernet: Unable to parse OF data <3>[ 1.918393] stm32-dwmac 5800a000.ethernet: probe with driver stm32-dwmac failed with error -75 which looks a bit odd given the commit contents but I didn't look at the driver code at all. Full boot log here: https://lava.sirena.org.uk/scheduler/job/467150 A working equivalent is here: https://lava.sirena.org.uk/scheduler/job/466518 I delivered 2 fixes to solve issue. Christophe Roullier (2): net: stmmac: dwmac-stm32: Add test to verify if ETHCK is used before checking clk rate net: stmmac: dwmac-stm32: update err status in case different of stm32mp13 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) base-commit: f261aa15b2ca73d4f9dbb8b116b16743237edad9 Tested-by: Mark Brown