From patchwork Sat Jun 29 04:53:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13716785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32CAEC27C4F for ; Sat, 29 Jun 2024 04:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Mime-Version:Message-Id:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=/0dC8Bwm3vf/Imiu0GWXnmXRUHRnUVX3GhUs/K6jXVQ=; b=JrDNLBesWBocOwWJq3gOFQH8pp twuoJUBX5+//dvIVR5HGBEmDyhqQ8CWz1d3WEg50RQ/WbeXmUPgzcjXl4om+jDwOEOe3pcno43Xlv 8wk5u5mfy3GCrQ0mSdGqDGOl3T9waut6o2fIuXlp7AdhzVetUvIQwKkljjqYANhM6VM0Hzjz0CRzn RC/J7Mpr8KYCOWwmjAY+cXJM57SwInNOeulU4XQnBLVrmnFiOV7nIOm7P26yyKWSsDuo9skeskpSo L4TDQrMUD6vvnAP5u4t2TKMoOWbzDI0w/j65ewVEmHdGAcGIXzFgHkzBO6m8FnMdGKtANGjKecxLc 3OUbEkcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ6N-0000000Fr1d-43rY; Sat, 29 Jun 2024 04:54:19 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ6D-0000000FqyQ-2Q8F for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 04:54:11 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-643acc141cbso14177337b3.1 for ; Fri, 28 Jun 2024 21:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636848; x=1720241648; darn=lists.infradead.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=/0dC8Bwm3vf/Imiu0GWXnmXRUHRnUVX3GhUs/K6jXVQ=; b=GNkI2Zgx3AHRtA4oUFLwmfPgRHXSMANxgcWapTIAugAl2mBWmbf9Ow0PiaBQt2k2Uw 6B7emy8E1uekv/cX+X5wITbWlHoj3q5SCC/dlrd++D1LZDxWLC+bELR9UyeHiDJN+wZf 7CP54+EjFWzfSNlPYc6j6d74uYiQqHPLmcI0Iwu0acHvy+5bJ9Qm9he/53C4nBLLiCUc DPxvNUuhRI6i0eZlTuO+s7P+HbIg/e8Uky+on+LOejCByETryFQ0Le5u2uYT5avfKjhi Ru0TmGecUCRz1gKi6kei2+JDVZjjKcoWqwXOSEckO9BLoQqqZ4Z+ujmhRXWsdiGVsuCJ wBag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636848; x=1720241648; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/0dC8Bwm3vf/Imiu0GWXnmXRUHRnUVX3GhUs/K6jXVQ=; b=iNetOrWff/5bPmrvYm0W91UmkQHLspVE9qTOBSmYt10/ov+WrXeI5sS0TkQ5U5pgrg +ZIXnKn0lOuf03TPoYuDo0Qt88KKbLqpk1WBhCeOCqE4Ku+J/dJtPDrgtINTNWH8end/ XPxU3M7ObdfPBVielp3yHPykhDa28c6Lczrk3mW58NPXHBk5ZtUE+jjKe+KLZeXAqziP MmgrB67XboyAMQ6YGSX0VrsD3v3OKgFCN4/xzzXVbCC1HdC7Rt5zu/2oj953J4PxFPTJ wylRUUaOudZ5eLiGZ2yprN21yQXaGjOFOS6moWx363LCT0L7AgrVjCOsdYCq4Q5D8t52 PYTg== X-Forwarded-Encrypted: i=1; AJvYcCXJFITPPp7U3+y7wSd7S50apG+px2cjKOSjrEMrrK5QBb9yQYgyTT6lNwq6KYYEJDzjCJrSIUpCj8MAT7L1isvw0uOtsBla72xI4KQZWXXtzRaJazw= X-Gm-Message-State: AOJu0YzBaQJwwftYJINB7HgNX8DByFJW/AuXZJ+abydZxMAGZ4Bv4I6R 8cGJpptivOh7nVx8vPMU+aW0hft0uHJrgdA50GMMDmigSadFoVCfVo1fV9fjlYdlwwZaPopdazw GBHs+aA== X-Google-Smtp-Source: AGHT+IHoHdrZmEBlrpZ6Zqpk1K2Ypd9vGdWOS5MBKTc36yPJSr3winrBSZVjqq0a+AN9vOt7GZ4Og36DCWr+ X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a81:9281:0:b0:648:2f1d:1329 with SMTP id 00721157ae682-64c6b773206mr325697b3.1.1719636848038; Fri, 28 Jun 2024 21:54:08 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:22 -0700 Message-Id: <20240629045350.285243-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 00/28] Constify tool pointers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_215409_663857_1E91F7CB X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations. This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command. v3: Just remove auxtrace dummy tools [Adrian] and make s390-cpumsf struct removal its own patch [Adrian]. v2: Remove dummy tool initialization [Adrian] and make zero sized. Add cs-etm fix for address sanitizer build, found necessary when testing dummy tool change. Ian Rogers (28): perf auxtrace: Remove dummy tools perf s390-cpumsf: Remove unused struct perf cs-etm: Fix address sanitizer dso build failure perf tool: Constify tool pointers perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init perf kmem: Use perf_tool__init perf buildid-list: Use perf_tool__init perf kvm: Use perf_tool__init perf lock: Use perf_tool__init perf evlist: Use perf_tool__init perf record: Use perf_tool__init perf c2c: Use perf_tool__init perf script: Use perf_tool__init perf inject: Use perf_tool__init perf report: Use perf_tool__init perf stat: Use perf_tool__init perf annotate: Use perf_tool__init perf sched: Use perf_tool__init perf mem: Use perf_tool__init perf timechart: Use perf_tool__init perf diff: Use perf_tool__init perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init perf tool: Remove perf_tool__fill_defaults perf session: Constify tool tools/perf/arch/x86/util/event.c | 4 +- tools/perf/bench/synthesize.c | 2 +- tools/perf/builtin-annotate.c | 44 ++-- tools/perf/builtin-buildid-list.c | 10 + tools/perf/builtin-c2c.c | 33 ++- tools/perf/builtin-diff.c | 30 ++- tools/perf/builtin-evlist.c | 10 +- tools/perf/builtin-inject.c | 159 ++++++------ tools/perf/builtin-kmem.c | 20 +- tools/perf/builtin-kvm.c | 19 +- tools/perf/builtin-kwork.c | 33 ++- tools/perf/builtin-lock.c | 41 ++- tools/perf/builtin-mem.c | 37 +-- tools/perf/builtin-record.c | 47 ++-- tools/perf/builtin-report.c | 67 +++-- tools/perf/builtin-sched.c | 50 ++-- tools/perf/builtin-script.c | 106 ++++---- tools/perf/builtin-stat.c | 26 +- tools/perf/builtin-timechart.c | 25 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 4 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/dlfilter-test.c | 2 +- tools/perf/tests/dwarf-unwind.c | 2 +- tools/perf/tests/event_update.c | 9 +- tools/perf/tests/stat.c | 6 +- tools/perf/tests/thread-map.c | 2 +- tools/perf/util/Build | 1 + tools/perf/util/arm-spe.c | 55 +--- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 20 +- tools/perf/util/bpf-event.c | 4 +- tools/perf/util/build-id.c | 34 +-- tools/perf/util/build-id.h | 8 +- tools/perf/util/cs-etm.c | 49 +--- tools/perf/util/data-convert-bt.c | 34 ++- tools/perf/util/data-convert-json.c | 47 ++-- tools/perf/util/dso.h | 10 + tools/perf/util/event.c | 54 ++-- tools/perf/util/event.h | 38 +-- tools/perf/util/header.c | 6 +- tools/perf/util/header.h | 4 +- tools/perf/util/hisi-ptt.c | 6 +- tools/perf/util/intel-bts.c | 37 +-- tools/perf/util/intel-pt.c | 30 +-- tools/perf/util/jitdump.c | 4 +- tools/perf/util/s390-cpumsf.c | 11 +- tools/perf/util/session.c | 372 ++++------------------------ tools/perf/util/session.h | 9 +- tools/perf/util/synthetic-events.c | 80 +++--- tools/perf/util/synthetic-events.h | 70 +++--- tools/perf/util/tool.c | 294 ++++++++++++++++++++++ tools/perf/util/tool.h | 18 +- tools/perf/util/tsc.c | 2 +- 54 files changed, 998 insertions(+), 1107 deletions(-) create mode 100644 tools/perf/util/tool.c