[0/3] Add Per-transport SCMI debug statistics

Message

Luke Parkin July 1, 2024, 2:28 p.m. UTC

Hi,

This series adds support for tracking Arm SCMI statistics, [Patch 2]
A config option to enable this, [Patch 1] 
And in [Patch 3] a selection of new debugfs entries to present these statistics

These statistics are per transport instance, and will be a helpful resource when
debugging the SCMI and running tests.

Based on v6.9, Tested on Arm Juno [1]

Thanks,
Luke

[1]: https://www.arm.com/products/development-tools/development-boards/juno-arm-dev-platform

Luke Parkin (3):
  Add Kconfig option for scmi debug statistics
  Track basic SCMI statistics
  Create debugfs files for statistics

 drivers/firmware/arm_scmi/Kconfig  | 10 +++++
 drivers/firmware/arm_scmi/driver.c | 61 +++++++++++++++++++++++++++++-
 2 files changed, 69 insertions(+), 2 deletions(-)

Comments

Cristian Marussi July 1, 2024, 3:20 p.m. UTC | #1

On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote:
> Hi,
> 

Hi Luke,

thanks for taking a shot at this, a few comments down below and along
this series.

> This series adds support for tracking Arm SCMI statistics, [Patch 2]
> A config option to enable this, [Patch 1] 
> And in [Patch 3] a selection of new debugfs entries to present these statistics
> 
> These statistics are per transport instance, and will be a helpful resource when
> debugging the SCMI and running tests.
> 
> Based on v6.9, Tested on Arm Juno [1]
> 

First of all a nitpick on commit messages themselves...when posting patches on a specific
subsystem, the commit message "style" should align with the subsystem conventions:
IOW all the patches in your series (beside this cover-letter) should be titled as:

  firmware: arm_scmi: My patch starting with a capital letter

as you can guess having a look at git log --oneline drivers/firmware/arm_scmi

So please do this in V2 together with other reviews.

Thanks,
Cristian

Cristian Marussi July 1, 2024, 4:21 p.m. UTC | #2

On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote:
> Hi,
> 
> This series adds support for tracking Arm SCMI statistics, [Patch 2]
> A config option to enable this, [Patch 1] 
> And in [Patch 3] a selection of new debugfs entries to present these statistics
> 
> These statistics are per transport instance, and will be a helpful resource when
> debugging the SCMI and running tests.
> 
> Based on v6.9, Tested on Arm Juno [1]
> 
> Thanks,
> Luke
> 
> [1]: https://www.arm.com/products/development-tools/development-boards/juno-arm-dev-platform
> 
> Luke Parkin (3):
>   Add Kconfig option for scmi debug statistics
>   Track basic SCMI statistics
>   Create debugfs files for statistics
> 
>  drivers/firmware/arm_scmi/Kconfig  | 10 +++++
>  drivers/firmware/arm_scmi/driver.c | 61 +++++++++++++++++++++++++++++-
>  2 files changed, 69 insertions(+), 2 deletions(-)
> 

All in all, seems to me a good start, please address or dispute my (and
possibly other reviewers) observations in V2.

Thanks,
Cristian