mbox series

[v3,0/4] Do device node auto cleanup in drivers/soc/ti/

Message ID 20240707055341.3656-1-five231003@gmail.com (mailing list archive)
Headers show
Series Do device node auto cleanup in drivers/soc/ti/ | expand

Message

Kousik Sanagavarapu July 7, 2024, 5:14 a.m. UTC
Do "struct device_node" auto cleanup in soc/ti/.  This patch series takes
care of all the cases where this is possible.

Thanks Jonathan for the review on the previous round.

v2:

	https://lore.kernel.org/linux-arm-kernel/20240703065710.13786-1-five231003@gmail.com/

Changes since v2:
- Split v2 1/3 into v3 1/4 and v3 2/4.  The memory setup code is
  seperated out of the pruss_probe() function and put into 1/4 and the
  actual conversion to auto cleanup is done in 2/4.
- Replace dev_err() with dev_err_probe() in the code paths touched.

v1:

	https://lore.kernel.org/linux-arm-kernel/20240510071432.62913-1-five231003@gmail.com/

Changes since v1:
- Refactor code so that it the scope of the pointers touched is reduced,
  making the code look more clean.
- The above also the side-effect of fixing the errors that clang emitted
  (but my local version of gcc didn't) for PATCH 2/3 during v1.

Kousik Sanagavarapu (4):
  soc: ti: pruss: factor out memories setup
  soc: ti: pruss: do device_node auto cleanup
  soc: ti: knav_qmss_queue: do device_node auto cleanup
  soc: ti: pm33xx: do device_node auto cleanup

 drivers/soc/ti/knav_qmss_queue.c | 100 +++++++++---------
 drivers/soc/ti/pm33xx.c          |  52 ++++-----
 drivers/soc/ti/pruss.c           | 176 ++++++++++++++-----------------
 3 files changed, 155 insertions(+), 173 deletions(-)

Comments

Kousik Sanagavarapu July 17, 2024, 9:34 p.m. UTC | #1
On Sun, Jul 07, 2024 at 10:44:15AM +0530, Kousik Sanagavarapu wrote:
> Do "struct device_node" auto cleanup in soc/ti/.  This patch series takes
> care of all the cases where this is possible.
> 
> Thanks Jonathan for the review on the previous round.
> 
> v2:
> 
> 	https://lore.kernel.org/linux-arm-kernel/20240703065710.13786-1-five231003@gmail.com/
> 
> Changes since v2:
> - Split v2 1/3 into v3 1/4 and v3 2/4.  The memory setup code is
>   seperated out of the pruss_probe() function and put into 1/4 and the
>   actual conversion to auto cleanup is done in 2/4.
> - Replace dev_err() with dev_err_probe() in the code paths touched.
> 
> v1:
> 
> 	https://lore.kernel.org/linux-arm-kernel/20240510071432.62913-1-five231003@gmail.com/
> 
> Changes since v1:
> - Refactor code so that it the scope of the pointers touched is reduced,
>   making the code look more clean.
> - The above also the side-effect of fixing the errors that clang emitted
>   (but my local version of gcc didn't) for PATCH 2/3 during v1.
> 
> Kousik Sanagavarapu (4):
>   soc: ti: pruss: factor out memories setup
>   soc: ti: pruss: do device_node auto cleanup
>   soc: ti: knav_qmss_queue: do device_node auto cleanup
>   soc: ti: pm33xx: do device_node auto cleanup
> 
>  drivers/soc/ti/knav_qmss_queue.c | 100 +++++++++---------
>  drivers/soc/ti/pm33xx.c          |  52 ++++-----
>  drivers/soc/ti/pruss.c           | 176 ++++++++++++++-----------------
>  3 files changed, 155 insertions(+), 173 deletions(-)

Ping
Nishanth Menon July 18, 2024, 11:21 a.m. UTC | #2
On 03:04-20240718, Kousik Sanagavarapu wrote:
> On Sun, Jul 07, 2024 at 10:44:15AM +0530, Kousik Sanagavarapu wrote:
> > Do "struct device_node" auto cleanup in soc/ti/.  This patch series takes
> > care of all the cases where this is possible.
> > 
> > Thanks Jonathan for the review on the previous round.
> > 
> > v2:
> > 
> > 	https://lore.kernel.org/linux-arm-kernel/20240703065710.13786-1-five231003@gmail.com/
> > 
> > Changes since v2:
> > - Split v2 1/3 into v3 1/4 and v3 2/4.  The memory setup code is
> >   seperated out of the pruss_probe() function and put into 1/4 and the
> >   actual conversion to auto cleanup is done in 2/4.
> > - Replace dev_err() with dev_err_probe() in the code paths touched.
> > 
> > v1:
> > 
> > 	https://lore.kernel.org/linux-arm-kernel/20240510071432.62913-1-five231003@gmail.com/
> > 
> > Changes since v1:
> > - Refactor code so that it the scope of the pointers touched is reduced,
> >   making the code look more clean.
> > - The above also the side-effect of fixing the errors that clang emitted
> >   (but my local version of gcc didn't) for PATCH 2/3 during v1.
> > 
> > Kousik Sanagavarapu (4):
> >   soc: ti: pruss: factor out memories setup
> >   soc: ti: pruss: do device_node auto cleanup
> >   soc: ti: knav_qmss_queue: do device_node auto cleanup
> >   soc: ti: pm33xx: do device_node auto cleanup
> > 
> >  drivers/soc/ti/knav_qmss_queue.c | 100 +++++++++---------
> >  drivers/soc/ti/pm33xx.c          |  52 ++++-----
> >  drivers/soc/ti/pruss.c           | 176 ++++++++++++++-----------------
> >  3 files changed, 155 insertions(+), 173 deletions(-)
> 
> Ping

Umm... ping for what? for whom and why? In addition to reviews, I will
need someone to do tested-by as well - pruss/am33xx folks..? Further,
fyi, 6.12 collection cycle starts with 6.11 rc1 and I close mine around
rc4.
Kousik Sanagavarapu July 18, 2024, 2:12 p.m. UTC | #3
On Thu, Jul 18, 2024 at 06:21:34AM -0500, Nishanth Menon wrote:
> On 03:04-20240718, Kousik Sanagavarapu wrote:
>
> [...]
>
> > Ping
> 
> Umm... ping for what? for whom and why? In addition to reviews, I will
> need someone to do tested-by as well - pruss/am33xx folks..? Further,
> fyi, 6.12 collection cycle starts with 6.11 rc1 and I close mine around
> rc4.

Sorry for not being more specific.  Since the last version was reviewed
by Jonathan, I was wondering if he could review this round too.

And yes, it would be great if someone could test these patches as I don't
have access to the hardware - so RFT.

Also thanks for the heads up on the cycle, I didn't know.

Thanks