mbox series

[00/10] armada-370-xp irqchip updates round 4

Message ID 20240711160907.31012-1-kabel@kernel.org (mailing list archive)
Headers show
Series armada-370-xp irqchip updates round 4 | expand

Message

Marek Behún July 11, 2024, 4:08 p.m. UTC
Hi Thomas, Andrew, Ilpo et al.,

since round 3 was reviewed so quickly, here comes round 4, which should
be similarly easy to review.

This series can be applied on tip/irq/core, but only after round 2 and
round 3 series are applied:
  https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=869325
  https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=870469

Marek

Marek Behún (10):
  irqchip/armada-370-xp: Use consistent variable names for hwirqs
  irqchip/armada-370-xp: Use consistent types when iterating interrupts
  irqchip/armada-370-xp: Use consistent name for struct irq_data
    variables
  irqchip/armada-370-xp: Simplify mpic_reenable_percpu() and
    mpic_resume()
  irqchip/armada-370-xp: Drop unneeded curly brackets
  irqchip/armada-370-xp: Drop redundant continue
  irqchip/armada-370-xp: Rename variable for consistency
  irqchip/armada-370-xp: Use u32 type instead of unsigned long where
    possieble
  irqchip/armada-370-xp: Refactor initial memory regions mapping
  irqchip/armada-370-xp: Print error and return error code on
    initialization failure

 drivers/irqchip/irq-armada-370-xp.c | 201 ++++++++++++++++------------
 1 file changed, 118 insertions(+), 83 deletions(-)

Comments

Thomas Gleixner July 11, 2024, 8:56 p.m. UTC | #1
Marek!

On Thu, Jul 11 2024 at 18:08, Marek Behún wrote:

> Hi Thomas, Andrew, Ilpo et al.,
>
> since round 3 was reviewed so quickly, here comes round 4, which should
> be similarly easy to review.
>
> This series can be applied on tip/irq/core, but only after round 2 and
> round 3 series are applied:
>   https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=869325
>   https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=870469

I marked all of this as material to merge right after 6.11-rc1.

Thanks,

        tglx
Marek Behún July 12, 2024, 7:46 a.m. UTC | #2
Hello Thomas,

On Thu, Jul 11, 2024 at 10:56:35PM +0200, Thomas Gleixner wrote:
> Marek!
> 
> On Thu, Jul 11 2024 at 18:08, Marek Behún wrote:
> 
> > Hi Thomas, Andrew, Ilpo et al.,
> >
> > since round 3 was reviewed so quickly, here comes round 4, which should
> > be similarly easy to review.
> >
> > This series can be applied on tip/irq/core, but only after round 2 and
> > round 3 series are applied:
> >   https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=869325
> >   https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=870469
> 
> I marked all of this as material to merge right after 6.11-rc1.

I have another 10 refactoring/cleanup patches prepared, bringing this
driver to modern style, I will be sending that as round 5.

And finally after that I have the patch adding support for SoC Error
interrupts, which is why I have been doing all this.

Hopefully this SoC Error interrupt support will get merger for 6.12.

Marek
Thomas Gleixner July 12, 2024, 10:19 p.m. UTC | #3
Marek!

On Fri, Jul 12 2024 at 09:46, Marek Behún wrote:
> On Thu, Jul 11, 2024 at 10:56:35PM +0200, Thomas Gleixner wrote:
>> I marked all of this as material to merge right after 6.11-rc1.
>
> I have another 10 refactoring/cleanup patches prepared, bringing this
> driver to modern style, I will be sending that as round 5.
>
> And finally after that I have the patch adding support for SoC Error
> interrupts, which is why I have been doing all this.
>
> Hopefully this SoC Error interrupt support will get merger for 6.12.

I don't see a problem with that if the quality stays at that level. Nice
work!

Thanks,

        tglx
Thomas Gleixner July 29, 2024, 9:44 a.m. UTC | #4
Marek!

On Sat, Jul 13 2024 at 00:19, Thomas Gleixner wrote:
> On Fri, Jul 12 2024 at 09:46, Marek Behún wrote:
>> On Thu, Jul 11, 2024 at 10:56:35PM +0200, Thomas Gleixner wrote:
>>> I marked all of this as material to merge right after 6.11-rc1.
>>
>> I have another 10 refactoring/cleanup patches prepared, bringing this
>> driver to modern style, I will be sending that as round 5.
>>
>> And finally after that I have the patch adding support for SoC Error
>> interrupts, which is why I have been doing all this.
>>
>> Hopefully this SoC Error interrupt support will get merger for 6.12.
>
> I don't see a problem with that if the quality stays at that level. Nice
> work!

I've applied the lot (except the brackets one) to tip irq/core and fixed
up a bunch of line breaks while going through it. The 80 character limit
was lifted quite some time ago and extended to 100.

Please double check that everything is correct.

Btw, please Cc: LKML on your next series as that's the official mailing
list for irqchip work.

Thanks,

        tglx