From patchwork Thu Jul 11 17:59:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13730955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5B24C3DA45 for ; Thu, 11 Jul 2024 18:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Mime-Version:Message-Id:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Vd8Kna0+0RAluWRoKv6o+QCtglnUtuOoGSBcyKDtFeg=; b=0oqON3xUNMuXGQL4Y2ToiFiGpN sfYUR02OqpbFE6TLeO8fb9Z0YauYqJ41XqioV5pITy+VmBAjbll1vPgvqn0szYIvAzLiSg2yDW8Pc u7iyYA2VV13/8AcTfi7Du7zUTqRrjzqZVx96PUKUF4CnayiY6ZtZbo0g7+IvsJcun4zhE5W5eQFmx 8tbE0NwfnN3DhD/o5nqmnssy54tPpL4cJaRn5UvoTpYELZE42xVsCMtTeURifa8SoceEvFCT/FcVw EMTpacWw/HN1ggBipd6d/f5lRgwmZOS66UhaiR7ClnJNZoEM75ZFtnFzMh1lNywy+Lzw2NNhAl37H 4XS4Wu0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRy5r-0000000EwCq-0vAe; Thu, 11 Jul 2024 18:00:35 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRy5W-0000000Ew3w-3Je6 for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 18:00:16 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-e02b5792baaso2084298276.2 for ; Thu, 11 Jul 2024 11:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720720813; x=1721325613; darn=lists.infradead.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=Vd8Kna0+0RAluWRoKv6o+QCtglnUtuOoGSBcyKDtFeg=; b=LU8ccnWjt7kEfDzGDeoMctfA5GVBLwCzDvOdBETLCFw6peb5cPRtrjFsPoWiQD9LCz S+FTbN9dh+XwsW2nU5K4cubfrkNSQoGu6udNXvB3Kmvs8x7thPxHFtS+k6ktLQauae1Z yDQAEj2Gg6ssQCnwbCcoHKlA/tq2QGJZRIWdDSNlXTswCa0pEvrSame1ATQ226GrNwk7 vJCTweE7XqqHMauRxvqKBQahgldRCw78BDm1f1xJ0P269vKEqEFvvpi6y+y9bHwSGGFa cKgOKkDwSON7+hv5c9io624I5QvlgHlwUSTOzuU16t0qJSQzwPlXRvfMM5btDZ/7JnyX AkZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720720813; x=1721325613; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Vd8Kna0+0RAluWRoKv6o+QCtglnUtuOoGSBcyKDtFeg=; b=uWNCoPVjem0m5RArDSY5hg3I3s83y7rhSeaDucxBPzOLs7+bNVD4+XqfmD3tG/7CKw xdSddOKq7RC+2/YytmTT1yR856bpe4FbEM4kL3eSkpqlOo6uzcpMe2+7QVcB1AOVexwK S/x6e9vgHNOvFm33+UpUdFwcwwI98IzskT79QVD9SdiSPdidnGnOppjznhB6JmhqN5xa sWI+wbfZBbhV+P0odLviGlPOX5KZT4sbXjohhfWb8drzC9NNQ8jeu6yyRQAUofMk40Lo e7OsR3ZwdFiiNHiUpP3YgTPCmVEtcQOQHxvG96J5Toxh8xywxnrvcwymZGQMGk7SXeo8 Fhgw== X-Forwarded-Encrypted: i=1; AJvYcCX77uyNFfyzPW9DVQ+zmV0V6Npj8GJFNUaqKKcPyANdJ516F7dQUyrCIOF1pfPDhhqdH2/HUlSrfoqe1IrMx1OSye+CVy6/ABu3Yfzq7yWnmhdud3A= X-Gm-Message-State: AOJu0Ywiv2aUER0eAh32SR2pwjBtLNS5NO4V0mPbnZ+2nWBGMvDzbROt NqeJ83cRxW/fu+zObu4gLhBv+/jBmj7gZ60i1EeW/SAewysApBVb+depUbOwSHYx4RkWYqxh2Ya qLGZzPA== X-Google-Smtp-Source: AGHT+IFAKCKgweyOaJWl5MOnJPgmzdawWpR8UxfR4LBJcvZ/Pxrc/95vokU4ESpEhRtx4U/Yj7T2pPa8qTrX X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:bd08:a1e0:c497:32db]) (user=irogers job=sendgmr) by 2002:a05:6902:2b0d:b0:dfb:1147:cbaa with SMTP id 3f1490d57ef6-e041b111731mr962320276.10.1720720813415; Thu, 11 Jul 2024 11:00:13 -0700 (PDT) Date: Thu, 11 Jul 2024 10:59:40 -0700 Message-Id: <20240711180008.188906-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Subject: [PATCH v4 00/28] Constify tool pointers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_110014_859218_81CDD105 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations. This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command. v4: Simplify perf_session__deliver_synth_attr_event following Adrian's suggestions. v3: Just remove auxtrace dummy tools [Adrian] and make s390-cpumsf struct removal its own patch [Adrian]. v2: Remove dummy tool initialization [Adrian] and make zero sized. Add cs-etm fix for address sanitizer build, found necessary when testing dummy tool change. Ian Rogers (28): perf auxtrace: Remove dummy tools perf s390-cpumsf: Remove unused struct perf cs-etm: Fix address sanitizer dso build failure perf tool: Constify tool pointers perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init perf kmem: Use perf_tool__init perf buildid-list: Use perf_tool__init perf kvm: Use perf_tool__init perf lock: Use perf_tool__init perf evlist: Use perf_tool__init perf record: Use perf_tool__init perf c2c: Use perf_tool__init perf script: Use perf_tool__init perf inject: Use perf_tool__init perf report: Use perf_tool__init perf stat: Use perf_tool__init perf annotate: Use perf_tool__init perf sched: Use perf_tool__init perf mem: Use perf_tool__init perf timechart: Use perf_tool__init perf diff: Use perf_tool__init perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init perf tool: Remove perf_tool__fill_defaults perf session: Constify tool tools/perf/arch/x86/util/event.c | 4 +- tools/perf/bench/synthesize.c | 2 +- tools/perf/builtin-annotate.c | 44 ++-- tools/perf/builtin-buildid-list.c | 10 + tools/perf/builtin-c2c.c | 33 ++- tools/perf/builtin-diff.c | 30 ++- tools/perf/builtin-evlist.c | 10 +- tools/perf/builtin-inject.c | 159 ++++++------ tools/perf/builtin-kmem.c | 20 +- tools/perf/builtin-kvm.c | 19 +- tools/perf/builtin-kwork.c | 33 ++- tools/perf/builtin-lock.c | 41 ++-- tools/perf/builtin-mem.c | 37 +-- tools/perf/builtin-record.c | 47 ++-- tools/perf/builtin-report.c | 67 +++-- tools/perf/builtin-sched.c | 50 ++-- tools/perf/builtin-script.c | 106 ++++---- tools/perf/builtin-stat.c | 26 +- tools/perf/builtin-timechart.c | 25 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 4 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/dlfilter-test.c | 2 +- tools/perf/tests/dwarf-unwind.c | 2 +- tools/perf/tests/event_update.c | 9 +- tools/perf/tests/stat.c | 6 +- tools/perf/tests/thread-map.c | 2 +- tools/perf/util/Build | 1 + tools/perf/util/arm-spe.c | 55 +---- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 20 +- tools/perf/util/bpf-event.c | 4 +- tools/perf/util/build-id.c | 34 +-- tools/perf/util/build-id.h | 8 +- tools/perf/util/cs-etm.c | 49 +--- tools/perf/util/data-convert-bt.c | 34 ++- tools/perf/util/data-convert-json.c | 47 ++-- tools/perf/util/dso.h | 10 + tools/perf/util/event.c | 54 ++-- tools/perf/util/event.h | 38 +-- tools/perf/util/header.c | 6 +- tools/perf/util/header.h | 4 +- tools/perf/util/hisi-ptt.c | 6 +- tools/perf/util/intel-bts.c | 37 +-- tools/perf/util/intel-pt.c | 30 +-- tools/perf/util/jitdump.c | 4 +- tools/perf/util/s390-cpumsf.c | 11 +- tools/perf/util/session.c | 366 +++------------------------- tools/perf/util/session.h | 9 +- tools/perf/util/synthetic-events.c | 80 +++--- tools/perf/util/synthetic-events.h | 70 +++--- tools/perf/util/tool.c | 294 ++++++++++++++++++++++ tools/perf/util/tool.h | 18 +- tools/perf/util/tsc.c | 2 +- 54 files changed, 992 insertions(+), 1107 deletions(-) create mode 100644 tools/perf/util/tool.c