[0/2] Add support for Firefly CORE PX30 JD4

Message

Christopher Obbard July 16, 2024, 3:51 p.m. UTC

The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
Firefly containing the Rockchip PX30 SOC. This series adds support for it.
    

---
Christopher Obbard (2):
      dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
      arm64: dts: rockchip: add Firefly CORE PX30 JD4

 .../devicetree/bindings/arm/rockchip.yaml          |   5 +
 arch/arm64/boot/dts/rockchip/Makefile              |   1 +
 .../dts/rockchip/px30-firefly-core-px30-jd4.dts    | 562 +++++++++++++++++++++
 3 files changed, 568 insertions(+)
---
base-commit: d67978318827d06f1c0fa4c31343a279e9df6fde
change-id: 20240716-rockchip-px30-firefly-59efc93d6784

Best regards,

Comments

Dragan Simic July 16, 2024, 5:45 p.m. UTC | #1

Hello Christopher,

On 2024-07-16 17:51, Christopher Obbard wrote:
> The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> Firefly containing the Rockchip PX30 SOC. This series adds support for 
> it.
> 
> ---
> Christopher Obbard (2):
>       dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
>       arm64: dts: rockchip: add Firefly CORE PX30 JD4
> 
>  .../devicetree/bindings/arm/rockchip.yaml          |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile              |   1 +
>  .../dts/rockchip/px30-firefly-core-px30-jd4.dts    | 562 
> +++++++++++++++++++++
>  3 files changed, 568 insertions(+)

It would be better to split this into two separate files: a dtsi
for the SoM, and a dts for the carrier board (which would include
the new dtsi).  That would reflect the actual hardware better.

> ---
> base-commit: d67978318827d06f1c0fa4c31343a279e9df6fde
> change-id: 20240716-rockchip-px30-firefly-59efc93d6784
> 
> Best regards,

Heiko Stübner July 16, 2024, 8:07 p.m. UTC | #2

Am Dienstag, 16. Juli 2024, 19:45:44 CEST schrieb Dragan Simic:
> Hello Christopher,
> 
> On 2024-07-16 17:51, Christopher Obbard wrote:
> > The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> > Firefly containing the Rockchip PX30 SOC. This series adds support for 
> > it.
> > 
> > ---
> > Christopher Obbard (2):
> >       dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
> >       arm64: dts: rockchip: add Firefly CORE PX30 JD4
> > 
> >  .../devicetree/bindings/arm/rockchip.yaml          |   5 +
> >  arch/arm64/boot/dts/rockchip/Makefile              |   1 +
> >  .../dts/rockchip/px30-firefly-core-px30-jd4.dts    | 562 
> > +++++++++++++++++++++
> >  3 files changed, 568 insertions(+)
> 
> It would be better to split this into two separate files: a dtsi
> for the SoM, and a dts for the carrier board (which would include
> the new dtsi).  That would reflect the actual hardware better.

correct :-) .

There are numerous examples of these types in the kernel
already, both these combinations - for inspiration :-) .

Rob Herring (Arm) July 16, 2024, 9:12 p.m. UTC | #3

On Tue, 16 Jul 2024 16:51:03 +0100, Christopher Obbard wrote:
> The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> Firefly containing the Rockchip PX30 SOC. This series adds support for it.
> 
> 
> ---
> Christopher Obbard (2):
>       dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
>       arm64: dts: rockchip: add Firefly CORE PX30 JD4
> 
>  .../devicetree/bindings/arm/rockchip.yaml          |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile              |   1 +
>  .../dts/rockchip/px30-firefly-core-px30-jd4.dts    | 562 +++++++++++++++++++++
>  3 files changed, 568 insertions(+)
> ---
> base-commit: d67978318827d06f1c0fa4c31343a279e9df6fde
> change-id: 20240716-rockchip-px30-firefly-59efc93d6784
> 
> Best regards,
> --
> Christopher Obbard <[e-mail]>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/px30-firefly-core-px30-jd4.dtb' for [e-mail]:

arch/arm64/boot/dts/rockchip/px30-firefly-core-px30-jd4.dtb: /dsi@ff450000/panel@0: failed to match any schema with compatible: ['sitronix,st7703']