mbox series

[v1,0/4] Removal of non-existent DAC nodes

Message ID 20240717-anvil-ashy-544e80a1317c@spud (mailing list archive)
Headers show
Series Removal of non-existent DAC nodes | expand

Message

Conor Dooley July 17, 2024, 9:37 a.m. UTC 
From: Conor Dooley <conor.dooley@microchip.com>

Recently I've been getting triggered by abuse of the Rohm dh2228fv
compatible to get the spidev driver probing in Linux on development
kits by employees of various silicon vendors (like NXP or my own
employer). I had a look around the kernel and all users other than the
original Clearfontz board added by Maxime appear to be similar abuse.
Drop the non-existent nodes from all of these devices :)

Fun fact: the dh2228fv isn't even real, and was originally a typo! The
real DAC is a bh2228fv

Cheers,
Conor.

CC: Dinh Nguyen <dinguyen@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Heiko Stuebner <heiko@sntech.de>
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <s.hauer@pengutronix.de>
CC: Pengutronix Kernel Team <kernel@pengutronix.de>
CC: Fabio Estevam <festevam@gmail.com>
CC: Huacai Chen <chenhuacai@kernel.org>
CC: WANG Xuerui <kernel@xen0n.name>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-rockchip@lists.infradead.org
CC: imx@lists.linux.dev
CC: loongarch@lists.linux.dev

Conor Dooley (4):
  arm64: dts: imx8: remove non-existent DACs
  ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1
  loongarch: dts: remove non-existent DAC from 2k1000-ref
  ARM: dts: socfpga: remove non-existent DAC from CycloneV devkit

 .../arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts | 6 ------
 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts            | 8 --------
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts             | 6 ------
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts              | 6 ------
 arch/loongarch/boot/dts/loongson-2k1000-ref.dts           | 5 -----
 5 files changed, 31 deletions(-)

Comments

Krzysztof Kozlowski July 17, 2024, 9:39 a.m. UTC | #1 
On 17/07/2024 11:37, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> There is no Rohm DAC on the CycloneV devkit according to the online
> documentation for it that I could find, and it definitely does not have
> a dh2228fv as this device does not actually exist! Remove the DAC node
> from the devicetree as it is not acceptable to pretend to have a device
> on a board in order to bind the spidev driver in Linux.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof