From patchwork Tue Jul 23 10:12:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Ott X-Patchwork-Id: 13739832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D013EC3DA49 for ; Tue, 23 Jul 2024 10:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=8cUp6hq8Rf9yICEw+ij+wA/0ySScqHZkH2/Mn4b/iJI=; b=eqD5hRtJjonvYkhWtu72vzngpn 2zJw/m7c9LcbF7jZ7OhYKBqZltYYS+TnvAYVxP2MSlvqjxIZvQewG07kF/ctPxRxB9XvaQJiZEUlB PgO5lRIlPAR2t9WqNq3jJ5Kk0Hes82FjefvThnyXEr+fbEriTo4Q3MB0j9hHWOKR73HGGkdZ9ErJu NS8hUS+awLLEqLILT56esQcaiO3FDhhRNI1qsMkXMhC9zi00esi3y34+XDffIyGcA5MwlgbvJ8RVr 16nQZnllS0FWIMaFQtEgkcKxFe5ZSZRPhMQfcv4QVmqp8V3tbHT1zLooYgfmBSOoY60gejTX2D2j0 rbDKx+mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWCVu-0000000C7qd-13Sl; Tue, 23 Jul 2024 10:12:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWCVU-0000000C7dF-0CvH for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 10:12:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721729532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8cUp6hq8Rf9yICEw+ij+wA/0ySScqHZkH2/Mn4b/iJI=; b=Pd94vRuvNvPkmMzGgB08j+Ns1jh6yEQzHZ9FtPqhNXl1N3l3tRh0rp3mhIphVoMF0Zu9Bb jlcn/GXqngZ4FJTOBSbHanL66pIgAL6icD0Yxi3/Ss/H0tOdgZcKtj+cO/0lbheG3mAN5C do7znY493edCNlAVP6tCmLYK9CiSr3Q= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-Uw5EP4lMNoGS47VQ-y8XmA-1; Tue, 23 Jul 2024 06:12:11 -0400 X-MC-Unique: Uw5EP4lMNoGS47VQ-y8XmA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-79f18746082so760813085a.2 for ; Tue, 23 Jul 2024 03:12:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721729530; x=1722334330; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8cUp6hq8Rf9yICEw+ij+wA/0ySScqHZkH2/Mn4b/iJI=; b=OWImZfDwi339tXMLwkJ9adskMBCzXjH7DTVlHDxxkeRrfJXGqqb53jzTdD92YbZ15K AiBHApaUhSmHuEe+4XeOoUfnXQipvZDw+cMi7t70QGX/KT9b3/MVKS0tt9WmqwEZitYD FiFn/SSbg8rRJe9/E9J3YFad4nGko2fHnF7wMZMNlFlpal5Cu//dAB8Vv934C9JmIbfK OATZNxS1ujslaPogw43m+Nf+Gujj9xm5Htm40dIWvxgvKl6BdsNw7dRJN00DkVcilzQ1 lq41ObQVmGG/nPZIhFOE86PsXeeWaoPn9DjtMsF3qM6A7mmpvRUSmCNBj/XBzoKC+aCO gObQ== X-Gm-Message-State: AOJu0Yw6S1eCqpEQ8zMgwF0pQ4AZWg0oPKCHsjt0YkdDWPVwb+qcFFJX mh5m+68oSBXHoSgQuJl/gBGD3NEMyubPRL4giqxmmy0r9eziWud+6YS1cPYwZRtbmmseFfHF+On Y76ngeyY0JP+gRwKN0aD4kxyjWNpaV/A2APdSWh3YofLwuHP33oK0E2WYXP+npfaTt+0Mv2ZlXq CK07gLBfCaELZEMzUtELQK55J2SO2IbICfIQ+c2MbAL15qZgkeU/AtjA== X-Received: by 2002:a05:620a:29d5:b0:79e:ff47:3307 with SMTP id af79cd13be357-7a1a130a702mr1465271385a.8.1721729530193; Tue, 23 Jul 2024 03:12:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyt0QS1IKTLLjiIiYvN5IywSbQLXxQfkNLU8SejKutptyLr0Xnp/x8tl4jKx3X5B48LdDkqQ== X-Received: by 2002:a05:620a:29d5:b0:79e:ff47:3307 with SMTP id af79cd13be357-7a1a130a702mr1465268685a.8.1721729529791; Tue, 23 Jul 2024 03:12:09 -0700 (PDT) Received: from rh.redhat.com (p200300c93f45e50062e5f8c654844c9a.dip0.t-ipconnect.de. [2003:c9:3f45:e500:62e5:f8c6:5484:4c9a]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1990063f2sm463780085a.64.2024.07.23.03.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 03:12:09 -0700 (PDT) From: Sebastian Ott To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Zenghui Yu , Mark Rutland Subject: [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build Date: Tue, 23 Jul 2024 12:12:01 +0200 Message-ID: <20240723101204.7356-1-sebott@redhat.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_031232_198134_8DDDB5DE X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Building arch/arm64/kvm/ with W=1 spills out a lot of warnings. When changing stuff I try to use as much tooling as possible to make sure that I don't screw up - having a clean baseline imho helps with that. With the first 2 patches applied make W=1 arch/arm64/kvm/ runs without warnings for me (fedora userspace, upstream linux after kvm merge). Patch 3 gets rid of sparse lock warnings in arch/arm64/kvm/vgic/. Patch 1 now just adds -Wno-override-init to the cflags of the affected files. Alternatives would be to add this to the whole subdir or reintroduce the flag for higher warn levels.. Sebastian Ott (3): KVM: arm64: fix override-init warnings in W=1 builds KVM: arm64: fix kdoc warnings in W=1 builds KVM: arm64: vgic: fix unexpected unlock sparse warnings arch/arm64/kvm/Makefile | 3 +++ arch/arm64/kvm/arm.c | 1 + arch/arm64/kvm/hyp/nvhe/Makefile | 2 ++ arch/arm64/kvm/hyp/vhe/Makefile | 2 ++ arch/arm64/kvm/vgic/vgic-irqfd.c | 7 ++++--- arch/arm64/kvm/vgic/vgic-its.c | 18 +++++++++++------- arch/arm64/kvm/vgic/vgic-v3.c | 2 +- arch/arm64/kvm/vgic/vgic.c | 2 +- arch/arm64/kvm/vgic/vgic.h | 2 +- 9 files changed, 26 insertions(+), 13 deletions(-) Reviewed-by: Marc Zyngier