| Message ID | 20240726110355.2181563-1-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On Fri, 26 Jul 2024 19:03:45 +0800, Kevin Chen wrote: > This patchset adds initial support for the ASPEED. > AST27XX Board Management controller (BMC) SoC family. > > AST2700 is ASPEED's 8th-generation server management processor. > Featuring a quad-core ARM Cortex A35 64-bit processor and two > independent ARM Cortex M4 processors > > This patchset adds minimal architecture and drivers such as: > Clocksource, Clock and Reset > > This patchset was tested on the ASPEED AST2700 evaluation board. > > Kevin Chen (10): > dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 > SCU > dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock > clk: ast2700: add clock controller > dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset > dt-bindings: arm: aspeed: Add maintainer > dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string > arm64: aspeed: Add support for ASPEED AST2700 BMC SoC > arm64: dts: aspeed: Add initial AST27XX device tree > arm64: dts: aspeed: Add initial AST2700 EVB device tree > arm64: defconfig: Add ASPEED AST2700 family support > > .../bindings/arm/aspeed/aspeed.yaml | 6 + > .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + > MAINTAINERS | 3 + > arch/arm64/Kconfig.platforms | 14 + > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/aspeed/Makefile | 4 + > arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ > arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + > arch/arm64/configs/defconfig | 1 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ > .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ > .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ > 13 files changed, 1772 insertions(+) > create mode 100644 arch/arm64/boot/dts/aspeed/Makefile > create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi > create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts > create mode 100644 drivers/clk/clk-ast2700.c > create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h > create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen@aspeedtech.com: arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /: failed to match any schema with compatible: ['aspeed,ast2700a1-evb', 'aspeed,ast2700'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /: failed to match any schema with compatible: ['aspeed,ast2700a1-evb', 'aspeed,ast2700'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-size' from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-sets' from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a dependency of 'cache-line-size' from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: 'cache-unified' is a required property from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: l2-cache0: Unevaluated properties are not allowed ('cache-level', 'cache-line-size', 'cache-sets', 'cache-size' were unexpected) from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram@10000000: #address-cells: 1 was expected from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram@10000000: #size-cells: 1 was expected from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: sram@10000000: 'exported@0' does not match any of the regexes: '^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/sram/sram.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc@10000000/syscon@12c02000: failed to match any schema with compatible: ['aspeed,ast2700-scu0', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc@10000000/syscon@12c02000/interrupt-controller@1D0: failed to match any schema with compatible: ['aspeed,ast2700-scu-ic0'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc@10000000/syscon@12c02000/interrupt-controller@1E0: failed to match any schema with compatible: ['aspeed,ast2700-scu-ic1'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: /soc@14000000/syscon@14c02000: failed to match any schema with compatible: ['aspeed,ast2700-scu1', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial@14c33b00: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial@14c33b00: 'pinctrl-0' is a dependency of 'pinctrl-names' from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
On 26/07/2024 15:09, Rob Herring (Arm) wrote: > > On Fri, 26 Jul 2024 19:03:45 +0800, Kevin Chen wrote: >> This patchset adds initial support for the ASPEED. >> AST27XX Board Management controller (BMC) SoC family. >> >> AST2700 is ASPEED's 8th-generation server management processor. >> Featuring a quad-core ARM Cortex A35 64-bit processor and two >> independent ARM Cortex M4 processors >> >> This patchset adds minimal architecture and drivers such as: >> Clocksource, Clock and Reset >> >> This patchset was tested on the ASPEED AST2700 evaluation board. >> >> Kevin Chen (10): >> dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 >> SCU >> dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock >> clk: ast2700: add clock controller >> dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset >> dt-bindings: arm: aspeed: Add maintainer >> dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string >> arm64: aspeed: Add support for ASPEED AST2700 BMC SoC >> arm64: dts: aspeed: Add initial AST27XX device tree >> arm64: dts: aspeed: Add initial AST2700 EVB device tree >> arm64: defconfig: Add ASPEED AST2700 family support >> >> .../bindings/arm/aspeed/aspeed.yaml | 6 + >> .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + >> MAINTAINERS | 3 + >> arch/arm64/Kconfig.platforms | 14 + >> arch/arm64/boot/dts/Makefile | 1 + >> arch/arm64/boot/dts/aspeed/Makefile | 4 + >> arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ >> arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + >> arch/arm64/configs/defconfig | 1 + >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ >> .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ >> .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ >> 13 files changed, 1772 insertions(+) >> create mode 100644 arch/arm64/boot/dts/aspeed/Makefile >> create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >> create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts >> create mode 100644 drivers/clk/clk-ast2700.c >> create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h >> create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h >> >> -- >> 2.34.1 >> >> >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for 20240726110355.2181563-1-kevin_chen@aspeedtech.com: Kevin, Just to clarify. Looking at the patches it was quite obvious you did not test it with dtbs_check. For a new arm64 platform without any legacy, having 0 warnings is a must. Consider Documentation/process/maintainer-soc-clean-dts.rst being implied for this platform. Best regards, Krzysztof
Hi Krzk, I will separate clock part in the v3 patch into Ryan's clock series. > > On 26/07/2024 15:09, Rob Herring (Arm) wrote: > > > > On Fri, 26 Jul 2024 19:03:45 +0800, Kevin Chen wrote: > >> This patchset adds initial support for the ASPEED. > >> AST27XX Board Management controller (BMC) SoC family. > >> > >> AST2700 is ASPEED's 8th-generation server management processor. > >> Featuring a quad-core ARM Cortex A35 64-bit processor and two > >> independent ARM Cortex M4 processors > >> > >> This patchset adds minimal architecture and drivers such as: > >> Clocksource, Clock and Reset > >> > >> This patchset was tested on the ASPEED AST2700 evaluation board. > >> > >> Kevin Chen (10): > >> dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 > >> SCU > >> dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock > >> clk: ast2700: add clock controller > >> dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset > >> dt-bindings: arm: aspeed: Add maintainer > >> dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string > >> arm64: aspeed: Add support for ASPEED AST2700 BMC SoC > >> arm64: dts: aspeed: Add initial AST27XX device tree > >> arm64: dts: aspeed: Add initial AST2700 EVB device tree > >> arm64: defconfig: Add ASPEED AST2700 family support > >> > >> .../bindings/arm/aspeed/aspeed.yaml | 6 + > >> .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + > >> MAINTAINERS | 3 + > >> arch/arm64/Kconfig.platforms | 14 + > >> arch/arm64/boot/dts/Makefile | 1 + > >> arch/arm64/boot/dts/aspeed/Makefile | 4 + > >> arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ > >> arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + > >> arch/arm64/configs/defconfig | 1 + > >> drivers/clk/Makefile | 1 + > >> drivers/clk/clk-ast2700.c | 1166 > +++++++++++++++++ > >> .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ > >> .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ > >> 13 files changed, 1772 insertions(+) create mode 100644 > >> arch/arm64/boot/dts/aspeed/Makefile > >> create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi > >> create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts > >> create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 > >> include/dt-bindings/clock/aspeed,ast2700-clk.h > >> create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h > >> > >> -- > >> 2.34.1 > >> > >> > >> > > > > > > My bot found new DTB warnings on the .dts files added or changed in > > this series. > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the > > warnings are fixed by another series. Ultimately, it is up to the > > platform maintainer whether these warnings are acceptable or not. No > > need to reply unless the platform maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then make > > sure dt-schema is up to date: > > > > pip3 install dtschema --upgrade > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/ast2700-evb.dtb' for > 20240726110355.2181563-1-kevin_chen@aspeedtech.com: > > Kevin, > Just to clarify. Looking at the patches it was quite obvious you did not test it > with dtbs_check. For a new arm64 platform without any legacy, having 0 > warnings is a must. Agree. > > Consider Documentation/process/maintainer-soc-clean-dts.rst being implied > for this platform. > > Best regards, > Krzysztof -- Best Regards, Kevin.Chen ************* Email Confidentiality Notice ******************** 免責聲明: 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作! DISCLAIMER: This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
This patchset adds initial support for the ASPEED. AST27XX Board Management controller (BMC) SoC family. AST2700 is ASPEED's 8th-generation server management processor. Featuring a quad-core ARM Cortex A35 64-bit processor and two independent ARM Cortex M4 processors This patchset adds minimal architecture and drivers such as: Clocksource, Clock and Reset This patchset was tested on the ASPEED AST2700 evaluation board. Kevin Chen (10): dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock clk: ast2700: add clock controller dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset dt-bindings: arm: aspeed: Add maintainer dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string arm64: aspeed: Add support for ASPEED AST2700 BMC SoC arm64: dts: aspeed: Add initial AST27XX device tree arm64: dts: aspeed: Add initial AST2700 EVB device tree arm64: defconfig: Add ASPEED AST2700 family support .../bindings/arm/aspeed/aspeed.yaml | 6 + .../bindings/mfd/aspeed,ast2x00-scu.yaml | 3 + MAINTAINERS | 3 + arch/arm64/Kconfig.platforms | 14 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/aspeed/Makefile | 4 + arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi | 217 +++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 + arch/arm64/configs/defconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/clk-ast2700.c | 1166 +++++++++++++++++ .../dt-bindings/clock/aspeed,ast2700-clk.h | 180 +++ .../dt-bindings/reset/aspeed,ast2700-reset.h | 126 ++ 13 files changed, 1772 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts create mode 100644 drivers/clk/clk-ast2700.c create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h