mbox series

[v1,0/6] Add SCMI transport descriptors

Message ID 20240730144707.1647025-1-cristian.marussi@arm.com (mailing list archive)
Headers show
Series Add SCMI transport descriptors | expand

Message

Cristian Marussi July 30, 2024, 2:47 p.m. UTC
Hi,

this small series is an extended version of this recent, already reviewed,
series [1] posted by Peng to add a new arm,scmi property to describe some
platform-specific SCMI timeout constraints.

On top of that, this adds 2 more properties to describe a couple more
platform-specific transport characteristics.

To minimize conflicts, the whole series is based on top of another recent
series, which represents a rework of the core SCMI stack to split SCMI
transports as standalone drivers. [2]

Thanks,
Cristian

[1]: https://lore.kernel.org/linux-arm-kernel/20240709140957.3171255-1-peng.fan@oss.nxp.com/
[2]: https://lore.kernel.org/linux-arm-kernel/20240730133318.1573765-1-cristian.marussi@arm.com/T/#t

---

Cristian Marussi (5):
  firmware: arm_scmi: Remove const from transport descriptors
  firmware: arm_scmi: Use max-rx-timeout-ms from devicetree
  dt-bindings: firmware: arm,scmi: Introduce more transport properties
  firmware: arm_scmi: Use max_msg and max_msg_size from devicetree
  firmware: arm_scmi: Relocate atomic_threshold to scmi_desc

Peng Fan (1):
  dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms

 .../bindings/firmware/arm,scmi.yaml           | 22 +++++++++
 drivers/firmware/arm_scmi/common.h            |  9 +++-
 drivers/firmware/arm_scmi/driver.c            | 46 ++++++++++++-------
 .../arm_scmi/scmi_transport_mailbox.c         |  2 +-
 .../firmware/arm_scmi/scmi_transport_optee.c  |  2 +-
 .../firmware/arm_scmi/scmi_transport_smc.c    |  2 +-
 .../firmware/arm_scmi/scmi_transport_virtio.c |  2 +-
 7 files changed, 64 insertions(+), 21 deletions(-)

Comments

Peng Fan July 31, 2024, 1:13 p.m. UTC | #1
> Subject: [PATCH v1 0/6] Add SCMI transport descriptors
> 
> Hi,
> 
> this small series is an extended version of this recent, already reviewed,
> series [1] posted by Peng to add a new arm,scmi property to describe
> some platform-specific SCMI timeout constraints.
> 
> On top of that, this adds 2 more properties to describe a couple more
> platform-specific transport characteristics.
> 
> To minimize conflicts, the whole series is based on top of another
> recent series, which represents a rework of the core SCMI stack to split
> SCMI transports as standalone drivers. [2]

For the patchset,
Tested-by: Peng Fan <peng.fan@nxp.com>  #i.MX95 19x19 EVK

Regards,
Peng.

> 
> Thanks,
> Cristian
> 
> 
> ---
> 
> Cristian Marussi (5):
>   firmware: arm_scmi: Remove const from transport descriptors
>   firmware: arm_scmi: Use max-rx-timeout-ms from devicetree
>   dt-bindings: firmware: arm,scmi: Introduce more transport properties
>   firmware: arm_scmi: Use max_msg and max_msg_size from
> devicetree
>   firmware: arm_scmi: Relocate atomic_threshold to scmi_desc
> 
> Peng Fan (1):
>   dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-
> ms
> 
>  .../bindings/firmware/arm,scmi.yaml           | 22 +++++++++
>  drivers/firmware/arm_scmi/common.h            |  9 +++-
>  drivers/firmware/arm_scmi/driver.c            | 46 ++++++++++++-------
>  .../arm_scmi/scmi_transport_mailbox.c         |  2 +-
>  .../firmware/arm_scmi/scmi_transport_optee.c  |  2 +-
>  .../firmware/arm_scmi/scmi_transport_smc.c    |  2 +-
>  .../firmware/arm_scmi/scmi_transport_virtio.c |  2 +-
>  7 files changed, 64 insertions(+), 21 deletions(-)
> 
> --
> 2.45.2
>
Cristian Marussi July 31, 2024, 1:58 p.m. UTC | #2
On Wed, Jul 31, 2024 at 01:13:14PM +0000, Peng Fan wrote:
> > Subject: [PATCH v1 0/6] Add SCMI transport descriptors
> > 
> > Hi,
> > 
> > this small series is an extended version of this recent, already reviewed,
> > series [1] posted by Peng to add a new arm,scmi property to describe
> > some platform-specific SCMI timeout constraints.
> > 
> > On top of that, this adds 2 more properties to describe a couple more
> > platform-specific transport characteristics.
> > 
> > To minimize conflicts, the whole series is based on top of another
> > recent series, which represents a rework of the core SCMI stack to split
> > SCMI transports as standalone drivers. [2]
> 
> For the patchset,
> Tested-by: Peng Fan <peng.fan@nxp.com>  #i.MX95 19x19 EVK
> 

Thanks for testing.
Cristian
Nikunj Kela Aug. 1, 2024, 7:17 p.m. UTC | #3
On 7/30/2024 7:47 AM, Cristian Marussi wrote:
> Hi,
>
> this small series is an extended version of this recent, already reviewed,
> series [1] posted by Peng to add a new arm,scmi property to describe some
> platform-specific SCMI timeout constraints.
>
> On top of that, this adds 2 more properties to describe a couple more
> platform-specific transport characteristics.
>
> To minimize conflicts, the whole series is based on top of another recent
> series, which represents a rework of the core SCMI stack to split SCMI
> transports as standalone drivers. [2]
>
> Thanks,
> Cristian
>
> [1]: https://lore.kernel.org/linux-arm-kernel/20240709140957.3171255-1-peng.fan@oss.nxp.com/
> [2]: https://lore.kernel.org/linux-arm-kernel/20240730133318.1573765-1-cristian.marussi@arm.com/T/#t
>
> ---

Thanks Cristian for the series. I have validated them on Qualcomm
SA8255p(to be upstreamed) Ride platform.

-Nikunj

>
> Cristian Marussi (5):
>   firmware: arm_scmi: Remove const from transport descriptors
>   firmware: arm_scmi: Use max-rx-timeout-ms from devicetree
>   dt-bindings: firmware: arm,scmi: Introduce more transport properties
>   firmware: arm_scmi: Use max_msg and max_msg_size from devicetree
>   firmware: arm_scmi: Relocate atomic_threshold to scmi_desc
>
> Peng Fan (1):
>   dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms
>
>  .../bindings/firmware/arm,scmi.yaml           | 22 +++++++++
>  drivers/firmware/arm_scmi/common.h            |  9 +++-
>  drivers/firmware/arm_scmi/driver.c            | 46 ++++++++++++-------
>  .../arm_scmi/scmi_transport_mailbox.c         |  2 +-
>  .../firmware/arm_scmi/scmi_transport_optee.c  |  2 +-
>  .../firmware/arm_scmi/scmi_transport_smc.c    |  2 +-
>  .../firmware/arm_scmi/scmi_transport_virtio.c |  2 +-
>  7 files changed, 64 insertions(+), 21 deletions(-)
>
Cristian Marussi Aug. 1, 2024, 7:23 p.m. UTC | #4
On Thu, Aug 01, 2024 at 12:17:36PM -0700, Nikunj Kela wrote:
> 
> On 7/30/2024 7:47 AM, Cristian Marussi wrote:
> > Hi,
> >
> > this small series is an extended version of this recent, already reviewed,
> > series [1] posted by Peng to add a new arm,scmi property to describe some
> > platform-specific SCMI timeout constraints.
> >
> > On top of that, this adds 2 more properties to describe a couple more
> > platform-specific transport characteristics.
> >
> > To minimize conflicts, the whole series is based on top of another recent
> > series, which represents a rework of the core SCMI stack to split SCMI
> > transports as standalone drivers. [2]
> >
> > Thanks,
> > Cristian
> >
> > [1]: https://lore.kernel.org/linux-arm-kernel/20240709140957.3171255-1-peng.fan@oss.nxp.com/
> > [2]: https://lore.kernel.org/linux-arm-kernel/20240730133318.1573765-1-cristian.marussi@arm.com/T/#t
> >
> > ---
> 
> Thanks Cristian for the series. I have validated them on Qualcomm
> SA8255p(to be upstreamed) Ride platform.
> 

Thanks for testing...does this solves your issues ?
(assuming that will go through as it is ...)

Cristian
Nikunj Kela Aug. 1, 2024, 7:44 p.m. UTC | #5
On 8/1/2024 12:23 PM, Cristian Marussi wrote:
> On Thu, Aug 01, 2024 at 12:17:36PM -0700, Nikunj Kela wrote:
>> On 7/30/2024 7:47 AM, Cristian Marussi wrote:
>>> Hi,
>>>
>>> this small series is an extended version of this recent, already reviewed,
>>> series [1] posted by Peng to add a new arm,scmi property to describe some
>>> platform-specific SCMI timeout constraints.
>>>
>>> On top of that, this adds 2 more properties to describe a couple more
>>> platform-specific transport characteristics.
>>>
>>> To minimize conflicts, the whole series is based on top of another recent
>>> series, which represents a rework of the core SCMI stack to split SCMI
>>> transports as standalone drivers. [2]
>>>
>>> Thanks,
>>> Cristian
>>>
>>> [1]: https://lore.kernel.org/linux-arm-kernel/20240709140957.3171255-1-peng.fan@oss.nxp.com/
>>> [2]: https://lore.kernel.org/linux-arm-kernel/20240730133318.1573765-1-cristian.marussi@arm.com/T/#t
>>>
>>> ---
>> Thanks Cristian for the series. I have validated them on Qualcomm
>> SA8255p(to be upstreamed) Ride platform.
>>
> Thanks for testing...does this solves your issues ?
> (assuming that will go through as it is ...)
>
> Cristian

Yes it works like a charm! Hope this series goes through.

-Nikunj
Sudeep Holla Aug. 20, 2024, 2:39 p.m. UTC | #6
On Tue, 30 Jul 2024 15:47:01 +0100, Cristian Marussi wrote:
> this small series is an extended version of this recent, already reviewed,
> series [1] posted by Peng to add a new arm,scmi property to describe some
> platform-specific SCMI timeout constraints.
> 
> On top of that, this adds 2 more properties to describe a couple more
> platform-specific transport characteristics.
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi/updates), thanks!

[1/6] firmware: arm_scmi: Remove const from transport descriptors
      https://git.kernel.org/sudeep.holla/c/668f0cb2337f
[2/6] dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms
      https://git.kernel.org/sudeep.holla/c/3a5e6ab06eab
[3/6] firmware: arm_scmi: Use max-rx-timeout-ms from devicetree
      https://git.kernel.org/sudeep.holla/c/1780e411ef94

--
Regards,
Sudeep