| Message ID | 20240805131013.587016-1-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add per-transport SCMI communication debug statistics | expand |
On Mon, Aug 05, 2024 at 02:10:07PM +0100, Sudeep Holla wrote: > This series adds support for SCMI communication debug metrict tracking. > I am just sending on behalf of Luke with minor reworks in his absense. > > Cristian, > > I have retained your review tags, please shout if you disagree. > > Regards, > Sudeep > Hi, LGTM. If this is what was on Fri on your next, I gave it a go on my setup too. Tested-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian
On Mon, Aug 05, 2024 at 04:12:33PM +0100, Cristian Marussi wrote: > On Mon, Aug 05, 2024 at 02:10:07PM +0100, Sudeep Holla wrote: > > This series adds support for SCMI communication debug metrict tracking. > > I am just sending on behalf of Luke with minor reworks in his absense. > > > > Cristian, > > > > I have retained your review tags, please shout if you disagree. > > > > Regards, > > Sudeep > > > > Hi, > > LGTM. > > If this is what was on Fri on your next, I gave it a go on my setup > too. > > Tested-by: Cristian Marussi <cristian.marussi@arm.com> > Thanks, I think I also modified some Kconfig text and scmi_inc_count() but nothing that affects testing
On Mon, 05 Aug 2024 14:10:07 +0100, Sudeep Holla wrote: > This series adds support for SCMI communication debug metrict tracking. > I am just sending on behalf of Luke with minor reworks in his absense. > > Cristian, > > I have retained your review tags, please shout if you disagree. > > [...] Applied to sudeep.holla/linux (for-next/scmi/updates), thanks! [1/5] firmware: arm_scmi: Remove superfluous handle_to_scmi_info https://git.kernel.org/sudeep.holla/c/20c9234d623c [2/5] firmware: arm_scmi: Add support for debug metrics at the interface https://git.kernel.org/sudeep.holla/c/1b18d4295f9d [3/5] firmware: arm_scmi: Track basic SCMI communication debug metrics https://git.kernel.org/sudeep.holla/c/0b3d48c4726e [4/5] firmware: arm_scmi: Create debugfs files for SCMI communication debug metrics https://git.kernel.org/sudeep.holla/c/f6a905eaf6bf [5/5] firmware: arm_scmi: Add support to reset the debug metrics https://git.kernel.org/sudeep.holla/c/bd02b0737f38 -- Regards, Sudeep
This series adds support for SCMI communication debug metrict tracking. I am just sending on behalf of Luke with minor reworks in his absense. Cristian, I have retained your review tags, please shout if you disagree. Regards, Sudeep V4->V5 - Updated/improved some patch titles and commit messages - Moved all debugs strings to an array and changed the creations of the same into a for loop - Minor changes to the debugfs file names itself to improve readability V3->V4 - Rename to counters rather than statistics to reflect the scmi protocol better - Use basic writing rather than custom function on debugfs in patch 5 V2->V3 - Switch statistic counters to an array to store statistics. - Add more statistics - Add the ability to reset statistics, both individually and all V1->V2 - Add a minor fix removing an unneeded call to handle_to_scmi_info - Use new scmi_log_stats op/no-op rather than if(IS_ENABLED) - Drop unneeded atomic_set's - Use a helper function for stats debugfs creation Luke Parkin (5): firmware: arm_scmi: Remove superfluous handle_to_scmi_info firmware: arm_scmi: Add support for debug metrics at the interface firmware: arm_scmi: Track basic SCMI communication debug metrics firmware: arm_scmi: Create debugfs files for SCMI communication debug metrics firmware: arm_scmi: Add support to reset the debug metrics drivers/firmware/arm_scmi/Kconfig | 14 +++++ drivers/firmware/arm_scmi/common.h | 24 +++++++++ drivers/firmware/arm_scmi/driver.c | 83 +++++++++++++++++++++++++++--- 3 files changed, 113 insertions(+), 8 deletions(-)