From patchwork Fri Aug 9 19:35:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13759209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE90AC531DA for ; Fri, 9 Aug 2024 19:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Vk1e8ARA15dU1QMhgPg8BifClY0riAbfm4/wBOVvjHE=; b=xkLllzcnfR6q1UT7yw/Z8eGlDr ifpdD98I5gY31r3XVwO2LzSPdhdFS+oPO3eJCH8PZy6FwE6FodYJRzuxT1xe2pH0YkdXMDnUEuPhj elny8qk13lqN3InoX9Wa9RlaFIvrX/6w0x/n+fIkROTHiudjbLAHbnb0ujwF9WjDicOccNUVWuDuO jzZ7t2uWv0D4P2+utKRV2SJjWoK/oRsF75PnBx10+q9fE9DbE+R5kQfNYr9PO4dLrH8kGC1k/Qq4F bvIO6uJSXqTCiatVubntKu/otxpa/F7tgxY9yPVIb7PGYrfUcv1V6ymhR2KqvYb+U4jF/X9X7xi6B DpUFluVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scVQ5-0000000CNZZ-056q; Fri, 09 Aug 2024 19:37:01 +0000 Received: from out-175.mta1.migadu.com ([2001:41d0:203:375::af]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scVPS-0000000CNKP-1ttk for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 19:36:24 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723232178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Vk1e8ARA15dU1QMhgPg8BifClY0riAbfm4/wBOVvjHE=; b=tExPOYACOBawkQZEDsycZHtynFdqegGNMn4fZ2p4PB7TsFWLcKDzPs6uMaJzPHsHm8HFbg MKyEducQ3JfmjLzZiZ+6mrAL3kWfXdjyTaMQPXtUjvOGcw0GblFCHeFhCO++PKdXf1gaYZ mvd4aQiJz1wSzBn3nw8+06iiaxFimoU= From: Sean Anderson To: Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, David Airlie , Michal Simek , Daniel Vetter , Tomi Valkeinen , Sean Anderson Subject: [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support Date: Fri, 9 Aug 2024 15:35:52 -0400 Message-Id: <20240809193600.3360015-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_123622_781195_2CC623CF X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it adds debugfs support. The intent is to enable compliance testing or to help debug signal-integrity issues. Previously, I discussed converting the HPD work(s) to a threaded IRQ. I did not end up doing that for this series since the steps would be - Add locking - Move link retraining to a work function - Harden the IRQ - Merge the works into a threaded IRQ (omitted) Which with the exception of the final step is the same as leaving those works as-is. Conversion to a threaded IRQ can be done as a follow-up. Changes in v6: - Unplug DRM device before removal - Fix hang upon driver removal - Rebase onto drm-misc/drm-misc-next Changes in v5: - Rebase onto drm-misc/drm-misc-next Changes in v4: - Rebase onto drm/drm-next Changes in v3: - Convert to a hard IRQ - Use AUX IRQs instead of polling - Take dp->lock in zynqmp_dp_hpd_work_func Changes in v2: - Split off the HPD IRQ work into another commit - Expand the commit message - Document hpd_irq_work - Document debugfs files - Add ignore_aux_errors and ignore_hpd debugfs files to replace earlier implicit functionality - Attempt to fix unreproducable, spurious build warning - Drop "Optionally ignore DPCD errors" in favor of a debugfs file directly affecting zynqmp_dp_aux_transfer. Sean Anderson (8): drm: zynqmp_kms: Unplug DRM device before removal drm: zynqmp_dp: Add locking drm: zynqmp_dp: Don't retrain the link in our IRQ drm: zynqmp_dp: Convert to a hard IRQ drm: zynqmp_dp: Use AUX IRQs instead of polling drm: zynqmp_dp: Split off several helper functions drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func drm: zynqmp_dp: Add debugfs interface for compliance testing Documentation/gpu/drivers.rst | 1 + Documentation/gpu/zynqmp.rst | 149 ++++++ MAINTAINERS | 1 + drivers/gpu/drm/xlnx/zynqmp_dp.c | 846 ++++++++++++++++++++++++++++-- drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +- 5 files changed, 951 insertions(+), 48 deletions(-) create mode 100644 Documentation/gpu/zynqmp.rst