From patchwork Mon Aug 12 20:46:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13761018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB419C3DA7F for ; Mon, 12 Aug 2024 20:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Mime-Version:Message-Id:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uer6PQjscKvGgXXE3fJO4sZtaX8fzUOBmNat/aWkUT0=; b=GYtfwh7gIVbzFBWILzVEmVWQnN u1r8CcLI3zXwvp7K6h6YoARaQFxQkBXnzJjamHIZLOp6/blnlbTCXL+6VXLqGBO9GczIwE5SHgB5L yoZZv/K2zG8B8DX/r1mEK3ARlafwf99Cyw/+i68LLwi60liwdZ4kADLk8/MKbyPw2CPAKNeNiFG53 bmhcZS0zaroOCy1k3+6XzY0QaIl0cuRGRUuhraWlyleDzQGwFMlKhiHAge75v+/K3TwX+SdDZgAkw RTAl4Y5NZNKg6ckPo8jVrOjni6Lrut1yPOvdhO11lz5YlmbmtFYr72APM8WVYRcGt2sSgF/agtvvB 6sfIwwtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdbxY-00000001UjL-2TLG; Mon, 12 Aug 2024 20:48:08 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdbws-00000001UQW-3RT3 for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 20:47:28 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-68f95e37bbfso117951307b3.0 for ; Mon, 12 Aug 2024 13:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723495644; x=1724100444; darn=lists.infradead.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=uer6PQjscKvGgXXE3fJO4sZtaX8fzUOBmNat/aWkUT0=; b=F3xAieScV1GqZS0e40dRwOkFiCAwi94h/8JYL54Wwz07OlkkYDqzXJE1m+pOH8wD4K XeTn2/paHLn3mEocy/vQhGYPVoRI9fvdMVLfVeGPDRQpP5UoPKOAx5Nde8JvaVDpAKqC D69WW+tnL8mWb8JGSMHoIeA5fCyB909RgyMUxZJvSFH4H4MaK0YhcPKN+iSJOyBXUEeo wUTz4UBxnpcWvEs6MdifdwKiOZvdh3gPoL5FSrabJfbPIB/D4G2oRFSA1Xlhmrp5BNXC mFLeX3yxcuPMrSyhnADiQfwx5qhwfx+pgfXA0T13I7QlrVg4e7f65oHtU1dtTGAej3O6 fhoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723495644; x=1724100444; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uer6PQjscKvGgXXE3fJO4sZtaX8fzUOBmNat/aWkUT0=; b=bVONahBrxk1x5a5+N3mX+9YyQqCAjTEbhkI3BaRxmv9hdQlgtoag/blCwRU4238FI9 Eyj3GVJ0JrY+zGERpGNhMCBAylRX9a2bhI4etVd/giNKmaje+Ej5+SfyH2P0ykW//+cv e6qVwr3qRVOkN8BYPmIIJhOvF2cvMOHQWifQs3WHOxIilv7vJ44QOpStZZEr8TtKQBRx geZQ8GNeNqYmtBMEvosfCHqQc7ZRx6yP9CeJ1+w9CfTM2JZE/iht8YLtsAgevJFvYyW5 YeCyCNrXNBPrWSC4pW/oqSG1DxliZRRRvNvYvhqthezXpBSFaig9iwPizD25O8QqpCxV QWdw== X-Forwarded-Encrypted: i=1; AJvYcCXfVWkQn2Wt9IExQd29lZRgnOP5k/mGQRl8Wb+8bb4XQq+SbWTwwBHFVyZ0MrmODFtaX5hK9WnQyemv0wxt0Y8aYTpMxh5kZDcIkLjZpQ1jWaFR9vo= X-Gm-Message-State: AOJu0YxFwtoec2ePdsdY3lPGPt2xtIUylVMqcOYffzYa6SaPnpFhU8UK 4ZDIyuPDzPP0QWpbpnksNJGeUSDhK28dGyzRj/ZgL4s+KxFP/AI5uBguxfinQe0uwX56entEMvM mfGzJ8w== X-Google-Smtp-Source: AGHT+IEu0sMNYCIm71cwC3UyJ4MUqsU6Lo8drC4vUiZ6GZl6gb9xWPCK3IYSZfz8TDUui39XAjW2ez9/ny6C X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:e7f1:b90:720c:35bf]) (user=irogers job=sendgmr) by 2002:a81:d84d:0:b0:622:cd7d:fec4 with SMTP id 00721157ae682-6a97695ee2amr538717b3.9.1723495644367; Mon, 12 Aug 2024 13:47:24 -0700 (PDT) Date: Mon, 12 Aug 2024 13:46:52 -0700 Message-Id: <20240812204720.631678-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.46.0.76.ge559c4bf1a-goog Subject: [PATCH v7 00/27] Constify tool pointers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_134726_887094_46297AB3 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct perf_tool provides a set of function pointers that are called through when processing perf data. To make filling the pointers less cumbersome, if they are NULL perf_tools__fill_defaults will add default do nothing implementations. This change refactors struct perf_tool to have an init function that provides the default implementation. The special use of NULL and perf_tools__fill_defaults are removed. As a consequence the tool pointers can then all be made const, which better reflects the behavior a particular perf command would expect of the tool and to some extent can reduce the cognitive load on someone working on a command. v7: Rebase and correct Adrian's reviewed-by tags. v6: Rebase adding Adrian's reviewed-by/tested-by and Leo's tested-by. v5: Rebase dropping asan fix merged by Namhyung. v4: Simplify perf_session__deliver_synth_attr_event following Adrian's suggestions. v3: Just remove auxtrace dummy tools [Adrian] and make s390-cpumsf struct removal its own patch [Adrian]. v2: Remove dummy tool initialization [Adrian] and make zero sized. Add cs-etm fix for address sanitizer build, found necessary when testing dummy tool change. Ian Rogers (27): perf auxtrace: Remove dummy tools perf s390-cpumsf: Remove unused struct perf tool: Constify tool pointers perf tool: Move fill defaults into tool.c perf tool: Add perf_tool__init perf kmem: Use perf_tool__init perf buildid-list: Use perf_tool__init perf kvm: Use perf_tool__init perf lock: Use perf_tool__init perf evlist: Use perf_tool__init perf record: Use perf_tool__init perf c2c: Use perf_tool__init perf script: Use perf_tool__init perf inject: Use perf_tool__init perf report: Use perf_tool__init perf stat: Use perf_tool__init perf annotate: Use perf_tool__init perf sched: Use perf_tool__init perf mem: Use perf_tool__init perf timechart: Use perf_tool__init perf diff: Use perf_tool__init perf data convert json: Use perf_tool__init perf data convert ctf: Use perf_tool__init perf test event_update: Ensure tools is initialized perf kwork: Use perf_tool__init perf tool: Remove perf_tool__fill_defaults perf session: Constify tool tools/perf/arch/x86/util/event.c | 4 +- tools/perf/bench/synthesize.c | 2 +- tools/perf/builtin-annotate.c | 44 ++-- tools/perf/builtin-buildid-list.c | 10 + tools/perf/builtin-c2c.c | 33 ++- tools/perf/builtin-diff.c | 30 ++- tools/perf/builtin-evlist.c | 10 +- tools/perf/builtin-inject.c | 161 ++++++------ tools/perf/builtin-kmem.c | 20 +- tools/perf/builtin-kvm.c | 19 +- tools/perf/builtin-kwork.c | 33 ++- tools/perf/builtin-lock.c | 41 ++-- tools/perf/builtin-mem.c | 37 +-- tools/perf/builtin-record.c | 47 ++-- tools/perf/builtin-report.c | 67 +++-- tools/perf/builtin-sched.c | 50 ++-- tools/perf/builtin-script.c | 106 ++++---- tools/perf/builtin-stat.c | 26 +- tools/perf/builtin-timechart.c | 25 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 4 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/dlfilter-test.c | 2 +- tools/perf/tests/dwarf-unwind.c | 2 +- tools/perf/tests/event_update.c | 9 +- tools/perf/tests/stat.c | 6 +- tools/perf/tests/thread-map.c | 2 +- tools/perf/util/Build | 1 + tools/perf/util/arm-spe.c | 55 +---- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 20 +- tools/perf/util/bpf-event.c | 4 +- tools/perf/util/build-id.c | 34 +-- tools/perf/util/build-id.h | 8 +- tools/perf/util/cs-etm.c | 39 +-- tools/perf/util/data-convert-bt.c | 34 ++- tools/perf/util/data-convert-json.c | 47 ++-- tools/perf/util/event.c | 54 ++-- tools/perf/util/event.h | 38 +-- tools/perf/util/header.c | 6 +- tools/perf/util/header.h | 4 +- tools/perf/util/hisi-ptt.c | 6 +- tools/perf/util/intel-bts.c | 37 +-- tools/perf/util/intel-pt.c | 30 +-- tools/perf/util/jitdump.c | 4 +- tools/perf/util/s390-cpumsf.c | 11 +- tools/perf/util/session.c | 366 +++------------------------- tools/perf/util/session.h | 9 +- tools/perf/util/synthetic-events.c | 80 +++--- tools/perf/util/synthetic-events.h | 70 +++--- tools/perf/util/tool.c | 294 ++++++++++++++++++++++ tools/perf/util/tool.h | 18 +- tools/perf/util/tsc.c | 2 +- 53 files changed, 978 insertions(+), 1103 deletions(-) create mode 100644 tools/perf/util/tool.c