[0/8] kselftest/arm64: various compilation fixes

Message

Andre Przywara Aug. 16, 2024, 3:32 p.m. UTC

This fixes several smaller issues I faced when compiling the arm64
kselftests on my machine.
Patch 1 avoids a warning about the double definition of GNU_SOURCE,
for the arm64/signal tests. Patch 2 fixes a typo, where the f8dp2 hwcap
feature test was looking at the f8dp*4* cpuinfo name. Patch 3 adjusts
the output of the MTE tests when MTE is not available, so that tools
parsing the TAP output don't get confused and report errors.
The remaining patches are about wrong printf format specifiers. I grouped
them by type of error, in patch 4-8.

Please have a look!

Cheers,
Andre

Andre Przywara (8):
  kselftest/arm64: signal: drop now redundant GNU_SOURCE definition
  kselftest/arm64: hwcap: fix f8dp2 cpuinfo name
  kselftest/arm64: mte: use proper SKIP syntax
  kselftest/arm64: mte: use string literal for printf-style functions
  kselftest/arm64: mte: fix printf type warning about mask
  kselftest/arm64: mte: fix printf type warnings about __u64
  kselftest/arm64: mte: fix printf type warnings about pointers
  kselftest/arm64: mte: fix printf type warnings about longs

 tools/testing/selftests/arm64/abi/hwcap.c         |  2 +-
 .../selftests/arm64/mte/check_buffer_fill.c       |  4 ++--
 tools/testing/selftests/arm64/mte/check_prctl.c   |  4 ++--
 .../selftests/arm64/mte/check_tags_inclusion.c    |  4 ++--
 .../testing/selftests/arm64/mte/mte_common_util.c | 15 +++++++--------
 .../testing/selftests/arm64/mte/mte_common_util.h |  6 +++---
 tools/testing/selftests/arm64/signal/Makefile     |  2 +-
 7 files changed, 18 insertions(+), 19 deletions(-)

Comments

Catalin Marinas Oct. 17, 2024, 5:59 p.m. UTC | #1

On Fri, 16 Aug 2024 16:32:43 +0100, Andre Przywara wrote:
> This fixes several smaller issues I faced when compiling the arm64
> kselftests on my machine.
> Patch 1 avoids a warning about the double definition of GNU_SOURCE,
> for the arm64/signal tests. Patch 2 fixes a typo, where the f8dp2 hwcap
> feature test was looking at the f8dp*4* cpuinfo name. Patch 3 adjusts
> the output of the MTE tests when MTE is not available, so that tools
> parsing the TAP output don't get confused and report errors.
> The remaining patches are about wrong printf format specifiers. I grouped
> them by type of error, in patch 4-8.
> 
> [...]

Applied to arm64 (for-next/kselftest), thanks!

I skiped patch 5 since Mark wanted it handled differently. Andre, would
you mind respinning that patch?

[1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition
      https://git.kernel.org/arm64/c/a2aa5dcc6393
[2/8] kselftest/arm64: hwcap: fix f8dp2 cpuinfo name
      https://git.kernel.org/arm64/c/b0d80dbc378d
[3/8] kselftest/arm64: mte: use proper SKIP syntax
      https://git.kernel.org/arm64/c/bf52ca5912c0
[4/8] kselftest/arm64: mte: use string literal for printf-style functions
      https://git.kernel.org/arm64/c/0f995f22a03f
[6/8] kselftest/arm64: mte: fix printf type warnings about __u64
      https://git.kernel.org/arm64/c/7e893dc81de3
[7/8] kselftest/arm64: mte: fix printf type warnings about pointers
      https://git.kernel.org/arm64/c/4716f719202e
[8/8] kselftest/arm64: mte: fix printf type warnings about longs
      https://git.kernel.org/arm64/c/96dddb7b9406