From patchwork Mon Aug 19 12:59:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 13768340 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9581C3DA4A for ; Mon, 19 Aug 2024 13:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2/2q58t2F+cTHe7kDtGWS0JUyi56Siw+Ync/NtddUfE=; b=f4I7jXtcOPRKF6 4itxndjqGV7iU/5Oi2wnylrIhW8QsX6VSt0ETkYcxUhPvDiXLJdtDwGWzbSXjjo7lcTgYbQ7GfXZf slXBdFQrH6fnhxJyqavaQlxuuB8Ys9j47XHC1eXuvAnXzEpRgc+KNPgWP/iips4AqqmJj+mN81fwV DQBsgD8lIsq1uRMqfjWdnqBU+YbM1sI/LCb+Pipy7psEJ470DPyuHeSBWazNe3w3En2XoT2JU6NOw cLk1TBPKlAQZUJ5CeRyiWJ4DN6w4q0FyTbvhc9VzG/sUDJbWLkOLOAWQ0mLIln7afMquJXXYHCuds nNKnkuIY2UEaBZpOX9vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg213-00000001Wbf-0TSb; Mon, 19 Aug 2024 13:01:45 +0000 Received: from ns.iliad.fr ([212.27.33.1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg1z5-00000001WD1-1oUs for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 12:59:46 +0000 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 8E84020989; Mon, 19 Aug 2024 14:59:37 +0200 (CEST) Received: from [127.0.1.1] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 7CD0E2097B; Mon, 19 Aug 2024 14:59:37 +0200 (CEST) From: Marc Gonzalez Subject: [PATCH 0/2] Work around reserved SMMU context bank on msm8998 Date: Mon, 19 Aug 2024 14:59:34 +0200 Message-Id: <20240819-smmu-v1-0-bce6e4738825@freebox.fr> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIALZBw2YC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDC0MT3eLc3FLdFFNzo2TDREOzxMRkJaDSgqLUtMwKsDHRsbW1ACh0KDJ WAAAA To: Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Arnaud Vrac , Pierre-Hugues Husson , Marijn Suijten , Caleb Connolly , Marc Gonzalez X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_055943_683550_E7FB4FFD X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On qcom msm8998, writing to the last context bank of lpass_q6_smmu (base address 0x05100000) produces a system freeze & reboot. The hardware/hypervisor reports 13 context banks for the LPASS SMMU on msm8998, but only the first 12 are accessible... Override the number of context banks [ 2.546101] arm-smmu 5100000.iommu: probing hardware configuration... [ 2.552439] arm-smmu 5100000.iommu: SMMUv2 with: [ 2.558945] arm-smmu 5100000.iommu: stage 1 translation [ 2.563627] arm-smmu 5100000.iommu: address translation ops [ 2.568923] arm-smmu 5100000.iommu: non-coherent table walk [ 2.574566] arm-smmu 5100000.iommu: (IDR0.CTTW overridden by FW configuration) [ 2.580220] arm-smmu 5100000.iommu: stream matching with 12 register groups [ 2.587263] arm-smmu 5100000.iommu: 13 context banks (0 stage-2 only) [ 2.614447] arm-smmu 5100000.iommu: Supported page sizes: 0x63315000 [ 2.621358] arm-smmu 5100000.iommu: Stage-1: 36-bit VA -> 36-bit IPA [ 2.627772] arm-smmu 5100000.iommu: preserved 0 boot mappings Specifically, here: qsmmu->bypass_cbndx = smmu->num_context_banks - 1; arm_smmu_cb_write(smmu, qsmmu->bypass_cbndx, ARM_SMMU_CB_SCTLR, 0); and here: arm_smmu_write_context_bank(smmu, i); arm_smmu_cb_write(smmu, i, ARM_SMMU_CB_FSR, ARM_SMMU_CB_FSR_FAULT); It is likely that FW reserves the last context bank for its own use, thus a simple work-around would be: DON'T USE IT in Linux. For reference, the lpass_q6_smmu node looks like this: lpass_q6_smmu: iommu@5100000 { compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2"; reg = <0x05100000 0x40000>; clocks = <&gcc HLOS1_VOTE_LPASS_ADSP_SMMU_CLK>; clock-names = "iface"; #global-interrupts = <0>; #iommu-cells = <1>; interrupts = , , , , , , , , , , , , ; power-domains = <&gcc LPASS_ADSP_GDSC>; status = "disabled"; }; Changes in v2: - Use the compatible prop instead of a specific prop to trigger work-around (Bjorn & Caleb) - Add qcom,msm8998-lpass-smmu compatible string - Link to v1: https://lore.kernel.org/r/20240814-smmu-v1-0-3d6c27027d5b@freebox.fr --- Marc Gonzalez (2): iommu/arm-smmu-qcom: hide last LPASS SMMU context bank from linux arm64: dts: qcom: msm8998: add qcom,msm8998-lpass-smmu compatible arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) --- base-commit: edb6307a8d9be5052ba5ce121e0bd55900ce44c4 change-id: 20240814-smmu-d572c1a16aac Best regards,