[net-next,v18,00/13] Introduce PHY listing and link_topology tracking

Message

Maxime Chevallier Aug. 21, 2024, 3:09 p.m. UTC

Hello everyone,

This is V18 of the phy_link_topology series, aiming at improving support
for multiple PHYs being attached to the same MAC.

V18 is a simple rebase of the V17 on top of net-next, gathering the
tested-by and reviewed-by tags from Christophe (thanks !).

This iteration is also one patch shorter than V17 (patch 12/14 in V17 is gone),
as one of the patches used to fix an issue that has now been resolved by
Simon Horman in 

743ff02152bc ethtool: Don't check for NULL info in prepare_data callbacks

As a remainder, here's what the PHY listings would look like :
 - eth0 has a 88x3310 acting as media converter, and an SFP module with
   an embedded 88e1111 PHY
 - eth2 has a 88e1510 PHY

# ethtool --show-phys *

PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
Upstream type: MAC

PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0

PHY for eth2:
PHY index: 1
Driver name: Marvell 88E1510
PHY device name: f212a200.mdio-mii:00
Upstream type: MAC

Ethtool patches : https://github.com/minimaxwell/ethtool/tree/mc/topo-v16
(this branch is compatible with this V18 series)

Link to V17: https://lore.kernel.org/netdev/[e-mail]/
Link to V16: https://lore.kernel.org/netdev/[e-mail]/
Link to V15: https://lore.kernel.org/netdev/[e-mail]/
Link to V14: https://lore.kernel.org/netdev/[e-mail]/
Link to V13: https://lore.kernel.org/netdev/[e-mail]/
Link to v12: https://lore.kernel.org/netdev/[e-mail]/
Link to v11: https://lore.kernel.org/netdev/[e-mail]/
Link to V10: https://lore.kernel.org/netdev/[e-mail]/
Link to V9: https://lore.kernel.org/netdev/[e-mail]/
Link to V8: https://lore.kernel.org/netdev/[e-mail]/
Link to V7: https://lore.kernel.org/netdev/[e-mail]/
Link to V6: https://lore.kernel.org/netdev/[e-mail]/
Link to V5: https://lore.kernel.org/netdev/[e-mail]/
Link to V4: https://lore.kernel.org/netdev/[e-mail]/
Link to V3: https://lore.kernel.org/netdev/[e-mail]/
Link to V2: https://lore.kernel.org/netdev/[e-mail]/
Link to V1: https://lore.kernel.org/netdev/[e-mail]/

More discussions on specific issues that happened in 6.9-rc:

https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/

Thanks,

Maxime

Maxime Chevallier (13):
  net: phy: Introduce ethernet link topology representation
  net: sfp: pass the phy_device when disconnecting an sfp module's PHY
  net: phy: add helpers to handle sfp phy connect/disconnect
  net: sfp: Add helper to return the SFP bus name
  net: ethtool: Allow passing a phy index for some commands
  netlink: specs: add phy-index as a header parameter
  net: ethtool: Introduce a command to list PHYs on an interface
  netlink: specs: add ethnl PHY_GET command set
  net: ethtool: plca: Target the command to the requested PHY
  net: ethtool: pse-pd: Target the command to the requested PHY
  net: ethtool: cable-test: Target the command to the requested PHY
  net: ethtool: strset: Allow querying phy stats by index
  Documentation: networking: document phy_link_topology

 Documentation/netlink/specs/ethtool.yaml      |  58 ++++
 Documentation/networking/ethtool-netlink.rst  |  51 +++
 Documentation/networking/index.rst            |   1 +
 .../networking/phy-link-topology.rst          | 121 +++++++
 MAINTAINERS                                   |   1 +
 drivers/net/phy/Makefile                      |   2 +-
 drivers/net/phy/marvell-88x2222.c             |   2 +
 drivers/net/phy/marvell.c                     |   2 +
 drivers/net/phy/marvell10g.c                  |   2 +
 drivers/net/phy/phy_device.c                  |  48 +++
 drivers/net/phy/phy_link_topology.c           | 105 ++++++
 drivers/net/phy/phylink.c                     |   3 +-
 drivers/net/phy/qcom/at803x.c                 |   2 +
 drivers/net/phy/qcom/qca807x.c                |   2 +
 drivers/net/phy/sfp-bus.c                     |  26 +-
 include/linux/netdevice.h                     |   4 +-
 include/linux/phy.h                           |   6 +
 include/linux/phy_link_topology.h             |  82 +++++
 include/linux/sfp.h                           |   8 +-
 include/uapi/linux/ethtool.h                  |  16 +
 include/uapi/linux/ethtool_netlink.h          |  20 ++
 net/core/dev.c                                |  15 +
 net/ethtool/Makefile                          |   3 +-
 net/ethtool/cabletest.c                       |  35 +-
 net/ethtool/netlink.c                         |  66 +++-
 net/ethtool/netlink.h                         |  33 ++
 net/ethtool/phy.c                             | 308 ++++++++++++++++++
 net/ethtool/plca.c                            |  30 +-
 net/ethtool/pse-pd.c                          |  31 +-
 net/ethtool/strset.c                          |  24 +-
 30 files changed, 1056 insertions(+), 51 deletions(-)
 create mode 100644 Documentation/networking/phy-link-topology.rst
 create mode 100644 drivers/net/phy/phy_link_topology.c
 create mode 100644 include/linux/phy_link_topology.h
 create mode 100644 net/ethtool/phy.c

Comments

[e-mail] Aug. 23, 2024, 12:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Wed, 21 Aug 2024 17:09:54 +0200 you wrote:
> Hello everyone,
> 
> This is V18 of the phy_link_topology series, aiming at improving support
> for multiple PHYs being attached to the same MAC.
> 
> V18 is a simple rebase of the V17 on top of net-next, gathering the
> tested-by and reviewed-by tags from Christophe (thanks !).
> 
> [...]

Here is the summary with links:
  - [net-next,v18,01/13] net: phy: Introduce ethernet link topology representation
    https://git.kernel.org/netdev/net-next/c/384968786909
  - [net-next,v18,02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY
    https://git.kernel.org/netdev/net-next/c/4d76f115ab91
  - [net-next,v18,03/13] net: phy: add helpers to handle sfp phy connect/disconnect
    https://git.kernel.org/netdev/net-next/c/b2db6f4ace72
  - [net-next,v18,04/13] net: sfp: Add helper to return the SFP bus name
    https://git.kernel.org/netdev/net-next/c/0a2f7de0f3b9
  - [net-next,v18,05/13] net: ethtool: Allow passing a phy index for some commands
    https://git.kernel.org/netdev/net-next/c/c15e065b46dc
  - [net-next,v18,06/13] netlink: specs: add phy-index as a header parameter
    https://git.kernel.org/netdev/net-next/c/9af0e89d6c24
  - [net-next,v18,07/13] net: ethtool: Introduce a command to list PHYs on an interface
    https://git.kernel.org/netdev/net-next/c/17194be4c8e1
  - [net-next,v18,08/13] netlink: specs: add ethnl PHY_GET command set
    https://git.kernel.org/netdev/net-next/c/d3d9a3e48a63
  - [net-next,v18,09/13] net: ethtool: plca: Target the command to the requested PHY
    https://git.kernel.org/netdev/net-next/c/02180fb525ba
  - [net-next,v18,10/13] net: ethtool: pse-pd: Target the command to the requested PHY
    https://git.kernel.org/netdev/net-next/c/31748765bed3
  - [net-next,v18,11/13] net: ethtool: cable-test: Target the command to the requested PHY
    https://git.kernel.org/netdev/net-next/c/3688ff3077d3
  - [net-next,v18,12/13] net: ethtool: strset: Allow querying phy stats by index
    https://git.kernel.org/netdev/net-next/c/e96c93aa4be9
  - [net-next,v18,13/13] Documentation: networking: document phy_link_topology
    https://git.kernel.org/netdev/net-next/c/db31e09d517b

You are awesome, thank you!