[0/3] regulator: Minor cleanups

Message

Chen-Yu Tsai Aug. 22, 2024, 7:20 a.m. UTC

Hi,

Here are some cleanups for some bits that I saw while reworking my I2C
device tree component prober to use of_regulator_bulk_get_all().
These are not directly related to that series, so I send them
separately here.

Patch 1 makes the regulator_get*() function misuse error message easier
to understand.

Patch 2 makes of_regulator_bulk_get_all() pass out the error code from
regulator_get() instead of replacing it with -EINVAL.

Patch 3 makes of_regulator_bulk_get_all() clean up *everything* and not
touch the passed in pointer on error, and explicitly documents this
behavior.

Please have a look and merge if possible.


Thanks
ChenYu

[1] https://lore.kernel.org/linux-arm-kernel/[e-mail]/

Chen-Yu Tsai (3):
  regulator: Clarify error message for "id == NULL" in _regulator_get()
  regulator: Return actual error in of_regulator_bulk_get_all()
  regulator: Fully clean up on error in of_regulator_bulk_get_all()

 drivers/regulator/core.c         |  2 +-
 drivers/regulator/of_regulator.c | 23 +++++++++++++----------
 2 files changed, 14 insertions(+), 11 deletions(-)

Comments

Mark Brown Aug. 22, 2024, 10:44 p.m. UTC | #1

On Thu, 22 Aug 2024 15:20:43 +0800, Chen-Yu Tsai wrote:
> Here are some cleanups for some bits that I saw while reworking my I2C
> device tree component prober to use of_regulator_bulk_get_all().
> These are not directly related to that series, so I send them
> separately here.
> 
> Patch 1 makes the regulator_get*() function misuse error message easier
> to understand.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/3] regulator: Clarify error message for "id == NULL" in _regulator_get()
      commit: ad9d7a82901d9cea756b8666035b30ca41728e15
[2/3] regulator: Return actual error in of_regulator_bulk_get_all()
      commit: 395a41a1d3e377462f3eea8a205ee72be8885ff6
[3/3] regulator: Fully clean up on error in of_regulator_bulk_get_all()
      commit: bfefa214d179f13d01cf1b64a7efbabf586b0c49

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark