| Message ID | 20240826104821.1516344-1-b-padhi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Reserve Timer Nodes to avoid clash with Remoteproc firmware | expand |
On 26/08/24 16:18, Beleswar Padhi wrote: > The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain > use timers. At the same time, if Linux probes the timers, some > instability is observed while booting remote cores. Therefore, change > the status of the timer nodes to "reserved" to avoid any clash. > > NOTE: This series has been rebased on top of a sibling series[0] as both of them > introduce changes in the same files. Thus, please apply [0] before applying this > series. > > [0]: https://lore.kernel.org/all/20240826093024.1183540-1-b-padhi@ti.com/ > > v4: Changelog: > 1) Refactored changes from {}-common-proc-board.dts to {}-som.dtsi to put all > remoteproc related changes at one place as remotecores were getting enabled at > {}-som.dtsi file. > 2) Rebased this series on top of [0]. > > * Nishanth: > 1) Fixed $subject line for all patches to include the board level files where > the changes were applied instead of the SoC level files. > 2) Applied these timer fixes to J721E-SK, AM68-SK and AM69-SK boards as well. Adding to the changelog, * Udit: 1) Dropped patch "arm64: dts: ti: k3-j722s: Change timer nodes status to reserved" in v4 revision as remoteproc support (DT) has not been upstreamed yet for j722s-evm platform. Apologies for missing this changelog in the cover-letter itself. > > Link to v3: > https://lore.kernel.org/all/20240816073908.2343650-1-b-padhi@ti.com/ > > v3: Changelog: > * Udit > 1) j7200: Updated commit message description to remove DSPs as the SoC does not > have one. > 2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug. > 3) For entire series, removed comment about timer usage by R5fs in the MCU > voltage domain as those are used by Device Manager firmware to get SoC > functional. > > Link to v2: > https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/ > > v2: Changelog: > - Split the changes into individual patches for each SoC to tag the > correct offending commit for "Fixes:" tag. > > * Udit > 1) Add the correct clashing timer nodes for J7200 SoC. > 2) Port these changes to board level dts files instead of SoC level dtsi files. > > Link to v1: > https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/ > > Beleswar Padhi (7): > arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved > arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved > arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved > arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to > reserved > arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved > arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved > arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved > > arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 25 ++++++++++++ > arch/arm64/boot/dts/ti/k3-am69-sk.dts | 41 ++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 13 +++++++ > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 29 ++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 29 ++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 25 ++++++++++++ > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 41 ++++++++++++++++++++ > 7 files changed, 203 insertions(+) >
Hi Beleswar Padhi, On Mon, 26 Aug 2024 16:18:13 +0530, Beleswar Padhi wrote: > The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain > use timers. At the same time, if Linux probes the timers, some > instability is observed while booting remote cores. Therefore, change > the status of the timer nodes to "reserved" to avoid any clash. > > NOTE: This series has been rebased on top of a sibling series[0] as both of them > introduce changes in the same files. Thus, please apply [0] before applying this > series. > > [...] I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/7] arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved commit: f7d6dacb233e1fe7e99e766abddd2a0247957d80 [2/7] arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved commit: 96b2d17bfe407faae341053e1f376c7429c03c22 [3/7] arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved commit: a8d1241bd6e57add2807c3127f987f8929bb45a1 [4/7] arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to reserved commit: 1cf3a036f91a2e5a6187f7cea8f9bfab1d9b504f [5/7] arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved commit: ce25e4c7dff5c9a392ad5a5c38c4fc7031305cd2 [6/7] arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved commit: d8087ca36a29fa81cc80dd0a9b347b2877cc9b3d [7/7] arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved commit: bdebd509e43e508386488ba7a35cf714dffa0088 I dropped the fixes tag while applying: the behavior you are considering here is firmware specific. While I understand it is important for the board, the reported "fixes" tag has nothing to do with the board, it is a SoC timer introduction which is not where the bug is. All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain use timers. At the same time, if Linux probes the timers, some instability is observed while booting remote cores. Therefore, change the status of the timer nodes to "reserved" to avoid any clash. NOTE: This series has been rebased on top of a sibling series[0] as both of them introduce changes in the same files. Thus, please apply [0] before applying this series. [0]: https://lore.kernel.org/all/20240826093024.1183540-1-b-padhi@ti.com/ v4: Changelog: 1) Refactored changes from {}-common-proc-board.dts to {}-som.dtsi to put all remoteproc related changes at one place as remotecores were getting enabled at {}-som.dtsi file. 2) Rebased this series on top of [0]. * Nishanth: 1) Fixed $subject line for all patches to include the board level files where the changes were applied instead of the SoC level files. 2) Applied these timer fixes to J721E-SK, AM68-SK and AM69-SK boards as well. Link to v3: https://lore.kernel.org/all/20240816073908.2343650-1-b-padhi@ti.com/ v3: Changelog: * Udit 1) j7200: Updated commit message description to remove DSPs as the SoC does not have one. 2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug. 3) For entire series, removed comment about timer usage by R5fs in the MCU voltage domain as those are used by Device Manager firmware to get SoC functional. Link to v2: https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/ v2: Changelog: - Split the changes into individual patches for each SoC to tag the correct offending commit for "Fixes:" tag. * Udit 1) Add the correct clashing timer nodes for J7200 SoC. 2) Port these changes to board level dts files instead of SoC level dtsi files. Link to v1: https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/ Beleswar Padhi (7): arm64: dts: ti: k3-j7200-som-p0: Change timer nodes status to reserved arm64: dts: ti: k3-j721e-som-p0: Change timer nodes status to reserved arm64: dts: ti: k3-j721e-sk: Change timer nodes status to reserved arm64: dts: ti: k3-j721s2-som-p0: Change timer nodes status to reserved arm64: dts: ti: k3-am68-sk-som: Change timer nodes status to reserved arm64: dts: ti: k3-j784s4-evm: Change timer nodes status to reserved arm64: dts: ti: k3-am69-sk: Change timer nodes status to reserved arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 25 ++++++++++++ arch/arm64/boot/dts/ti/k3-am69-sk.dts | 41 ++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 13 +++++++ arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 29 ++++++++++++++ arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 29 ++++++++++++++ arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 25 ++++++++++++ arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 41 ++++++++++++++++++++ 7 files changed, 203 insertions(+)