[v2,0/3] Fix regulators and assign them on NanoPi NEO Plus2

Message

Kryštof Černý Aug. 27, 2024, 9 p.m. UTC

Many thanks for your feedback, especially from André Przywara,
I learned a lot from you and your kind words motivated me to do a follow-up.
Regulators should correspond to reality (schematics).
Proper regulators were added for pio and r_pio.
Added missing regulator for mmc2.

Signed-off-by: Kryštof Černý <[e-mail]>
---
Kryštof Černý (3):
      Fix NanoPi NEO Plus2 regulators
      Use regulators for pio on NanoPi NEO Plus2
      Add vqmmc-supply on NanoPi NEO Plus2

 .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
---
base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca

Best regards,

Comments

Chen-Yu Tsai Sept. 4, 2024, 2:52 p.m. UTC | #1

Hi,

On Wed, Aug 28, 2024 at 5:01 AM Kryštof Černý <[e-mail]> wrote:
>
> Many thanks for your feedback, especially from André Przywara,
> I learned a lot from you and your kind words motivated me to do a follow-up.
> Regulators should correspond to reality (schematics).
> Proper regulators were added for pio and r_pio.
> Added missing regulator for mmc2.
>
> Signed-off-by: Kryštof Černý <[e-mail]>
> ---
> Kryštof Černý (3):
>       Fix NanoPi NEO Plus2 regulators
>       Use regulators for pio on NanoPi NEO Plus2
>       Add vqmmc-supply on NanoPi NEO Plus2

I just realized that all your patch subjects are missing the proper prefixes.
Can you check the history of the file you changed to see what is usually
used and send a revised version?

Thanks
ChenYu

>
>  .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> ---
> base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
> change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca
>
> Best regards,
> --
> Kryštof Černý <[e-mail]>
>