| Message ID | 20240828140736.156703-1-james.clark@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Event parsing fixes | expand |
On Wed, Aug 28, 2024 at 03:07:14PM +0100, James Clark wrote: > I rebased this one and made some other fixes so that I could test it, > so I thought I'd repost it here in case it's helpful. I also added a > new test. > > But for the testing it all looks ok. > > There is one small difference where it now hides _all_ <not supported> > events, when previously it would only hide some selected subset of > events like "stalled-cycles-frontend". I think this is now more > consistent across platforms because, for example, Apple M only has > cycles and instructions, and the rest of the default events would > always show as <not supported> there. I'm not a big fan of hiding all of <unsupported>, when they are explicitly specified on the command line they should be absolutely shown. I do have tools that specify events on the command line and expect the same order/events in the output. This might well cause breakage. -Andi
On Wed, Aug 28, 2024 at 10:02 AM Andi Kleen <ak@linux.intel.com> wrote: > > On Wed, Aug 28, 2024 at 03:07:14PM +0100, James Clark wrote: > > I rebased this one and made some other fixes so that I could test it, > > so I thought I'd repost it here in case it's helpful. I also added a > > new test. > > > > But for the testing it all looks ok. > > > > There is one small difference where it now hides _all_ <not supported> > > events, when previously it would only hide some selected subset of > > events like "stalled-cycles-frontend". I think this is now more > > consistent across platforms because, for example, Apple M only has > > cycles and instructions, and the rest of the default events would > > always show as <not supported> there. > > I'm not a big fan of hiding all of <unsupported>, when they are explicitly > specified on the command line they should be absolutely shown. > > I do have tools that specify events on the command line and expect > the same order/events in the output. This might well cause breakage. The patch series doesn't do this, it just doesn't display unsupported events that came from the set of default events - default evsels have a "skippable" flag set. In patch 3 James has added to should_skip_zero_counter in stat-display.c: + /* + * Skip unsupported default events when not verbose. (default events + * are all marked 'skippable'). + */ + if (verbose == 0 && counter->skippable && !counter->supported) + return true; Thanks, Ian
I rebased this one and made some other fixes so that I could test it, so I thought I'd repost it here in case it's helpful. I also added a new test. But for the testing it all looks ok. There is one small difference where it now hides _all_ <not supported> events, when previously it would only hide some selected subset of events like "stalled-cycles-frontend". I think this is now more consistent across platforms because, for example, Apple M only has cycles and instructions, and the rest of the default events would always show as <not supported> there. Tested on Raptor Lake, Juno, N1, Ampere (with the DSU cycles PMU) and I also faked an Apple M on Juno. Changes since v4: * Hide all <not supported> default events when not verbose * Remove previous note about <not supported> behavior from the cover letter and replace it with a new note about the new behavior Changes since v3: * Rebase onto perf-tools-next 6236ebe07 * Fix Intel TPEBS counting mode test * Fix arm-spe build * Add support for DT devices in stat test * Add a new test for hybrid perf stat default arguments Ian Rogers (5): perf evsel: Add alternate_hw_config and use in evsel__match perf stat: Uniquify event name improvements perf stat: Remove evlist__add_default_attrs use strings perf evsel x86: Make evsel__has_perf_metrics work for legacy events perf evsel: Remove pmu_name James Clark (2): perf test: Make stat test work on DT devices perf test: Add a test for default perf stat command tools/perf/arch/arm64/util/arm-spe.c | 4 +- tools/perf/arch/x86/util/evlist.c | 74 +---- tools/perf/arch/x86/util/evsel.c | 35 ++- tools/perf/builtin-diff.c | 6 +- tools/perf/builtin-stat.c | 291 +++++++----------- tools/perf/tests/parse-events.c | 2 +- tools/perf/tests/shell/stat.sh | 33 +- .../perf/tests/shell/test_stat_intel_tpebs.sh | 11 +- tools/perf/util/evlist.c | 46 +-- tools/perf/util/evlist.h | 12 - tools/perf/util/evsel.c | 28 +- tools/perf/util/evsel.h | 22 +- tools/perf/util/metricgroup.c | 4 +- tools/perf/util/parse-events.c | 58 ++-- tools/perf/util/parse-events.h | 8 +- tools/perf/util/parse-events.y | 2 +- tools/perf/util/pmu.c | 6 +- tools/perf/util/pmu.h | 2 +- tools/perf/util/stat-display.c | 109 +++++-- tools/perf/util/stat-shadow.c | 14 +- tools/perf/util/stat.c | 2 +- 21 files changed, 356 insertions(+), 413 deletions(-)