mbox series

[v4,0/2] media: imx335: Fix reset-gpio handling

Message ID 20240830-imx335-vflip-v4-0-cb9f20fc7b87@ideasonboard.com (mailing list archive)
Headers show
Series media: imx335: Fix reset-gpio handling | expand

Message

Umang Jain Aug. 30, 2024, 6:11 a.m. UTC 
These couple of patches intends to fix the reset-gpio handling
for imx335 driver.

Patch 1/2 mentions reset-gpio polarity in DT binding example.

Patch 2/2 fixes the logical value of reset-gpio during
power-on/power-off sequence.

--
Changes in v4:
- rework 2/2 commit message
- Explain conclusions for 2/2 patch, in the '---' section.

Changes in v3:
- Rework 1/2 commit message
- Fix gpio include in DT example in 1/2
- Remove not-so-informative XCLR comment in 2/2

Changes in v2:
- Also include reset-gpio polarity, mention in DT binding
- Add Fixes tag in 2/2
- Set the reset line to high during init time in 2/2

Link to v2:
https://lore.kernel.org/linux-media/20240729110437.199428-1-umang.jain@ideasonboard.com/

Link to v1:
https://lore.kernel.org/linux-media/tyo5etjwsfznuk6vzwqmcphbu4pz4lskrg3fjieojq5qc3mg6s@6jbwavmapwmf/T/#m189ccfa77ddceda6c3b29be3306f1a27ed0934d6

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
Umang Jain (2):
      dt-bindings: media: imx335: Add reset-gpios to the DT example
      media: imx335: Fix reset-gpio handling

 Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ++++
 drivers/media/i2c/imx335.c                                   | 9 ++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)
---
base-commit: 393556c9f56ced8d9776c32ce99f34913cfd904e
change-id: 20240830-imx335-vflip-7f5d4b4d00fe

Best regards,

Comments

Sakari Ailus Aug. 30, 2024, 8:28 a.m. UTC | #1 
On Fri, Aug 30, 2024 at 11:41:50AM +0530, Umang Jain wrote:
> These couple of patches intends to fix the reset-gpio handling
> for imx335 driver.
> 
> Patch 1/2 mentions reset-gpio polarity in DT binding example.
> 
> Patch 2/2 fixes the logical value of reset-gpio during
> power-on/power-off sequence.
> 
> --
> Changes in v4:
> - rework 2/2 commit message
> - Explain conclusions for 2/2 patch, in the '---' section.

Thanks, Umang!

I've applied these in my tree.