From patchwork Sat Aug 31 16:24:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13786132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3114CD13DF for ; Sat, 31 Aug 2024 16:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=6c4lVF1o5OGS37nEpgMWyRqL9oqfcCpSbrXO4L/zAHk=; b=wKfcSdgZjv5DtuwVAT2IRhvktr dAP2C2SzKibIRc8a+0rNdznxDjClrH8ChubBVWpX0BqbcAV4Ysdw9BXLBkEBqI9VXjUPjV4BnI1Wt itHsMIWKu/+1LA+NdYs5vAErC/eNR8Beh3BIbFNC63v7Xjk+2oS8GXAWWoqvSiPh8zDGKQvmKc9Td soF2DY2GgTQ46YXz2or+lbGCFBiq4nicslpQIOr2APcaik9np6AnfniSlgbzPGXSuTebbvvXr4ULx P1uzfxVj3oE78C+IiN3LwwtOTg+RV47IZqHrUqPNsF37YuLsLqQ47oNua3wXWP8N4XPG8hKxPZYg6 2JBhT1hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQv1-00000009eqg-1Lof; Sat, 31 Aug 2024 16:25:43 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQu7-00000009ebz-0gOB; Sat, 31 Aug 2024 16:24:48 +0000 Received: from umang.jain (unknown [IPv6:2405:201:2033:3865:19c8:9110:3e7:4518]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 99712667; Sat, 31 Aug 2024 18:23:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725121414; bh=tCs3u8U4oWN2NuA+AQctVtTJPmFCLiIYcdDvk/A+34g=; h=From:To:Cc:Subject:Date:From; b=oltdpM7OYAWn6Qe84sWLU5qJLde9UmSXKI7bZ/golEC3kePBdJzZVzy/HmoLlhKsW ohDZQxIG67yHJtE/nbF8KGNR9aYyNLtlMXso32YbWyNkEJJ5L3HesdbierD7LaAqJv dcdpa7mDCHaC7/hYjk5NttwUNDjBbM7IgBPNQY4c= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Arnd Bergmann , Stefan Wahren , Dave Stevenson , Phil Elwell , Laurent Pinchart , Umang Jain Subject: [PATCH v2 0/7] staging: vchiq_core: Refactor vchiq_bulk_transfer() logic Date: Sat, 31 Aug 2024 21:54:28 +0530 Message-ID: <20240831162435.191084-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240831_092447_362968_E6BEDA86 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Series mostly refactors vchiq_bulk_transfer() code according to Arnd's review comment from [1]: > You can also wrap vchiq_bulk_transfer() in order to have > four separate functions based on the different 'mode' > values and have them only take the arguments they actually > need. I didn't wrap vchiq_bulk_transfer(), instead created four differnet function, one for each mode. This will pave the way to address his second comment: > Ideally this should be cleaned up in a way that completely > avoids passing both user and kernel data at the same time. which is not part of this series and will be done on top as arguments shuffling will have to fix the sparse warnings that exists currently. Patch 1/7 first moves the VCHIQ_BULK_MODE_WAITING logic out of vchiq_bulk_transfer Patch 2/7 then moves the core logic to vchiq_bulk_transfer() which can be shared in subsequent patches Patch 3/7 and 4/7 refactors remaining bulk transfer modes Patch 5/7 finally drops the vchiq_bulk_transfer() as not needed patch 6/7 and 7/7 are drive by patches, noticed during development. [1]: https://lore.kernel.org/linux-staging/3d3b7368-93b2-4c0d-845e-4099c2de9dc1@app.fastmail.com/ Changes in v2: - Directly return if service == NULL in 3/7 - Prefix non-static functions with "vchiq_" (appropriate driver prefix) - Use typed argument for 'userdata' in 1/7 Umang Jain (7): staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING staging: vchiq_core: Simplify vchiq_bulk_transfer() staging: vchiq_core: Factor out bulk transfer for blocking mode staging: vchiq_core: Factor out bulk transfer for (no/)callback mode staging: vchiq_core: Drop vchiq_bulk_transfer() staging: vchiq_core: Remove unused function argument staging: vchiq_core: Pass enumerated flag instead of int .../interface/vchiq_arm/vchiq_arm.c | 20 +- .../interface/vchiq_arm/vchiq_core.c | 321 +++++++++++------- .../interface/vchiq_arm/vchiq_core.h | 16 +- .../interface/vchiq_arm/vchiq_dev.c | 15 +- 4 files changed, 233 insertions(+), 139 deletions(-)