| Message ID | 20240905-nanopi-neo-plus2-regfix-v3-0-1895dff59598@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | NanoPi NEO Plus2: Fix regulators and assign them | expand |
On Thu, 05 Sep 2024 19:37:09 +0200 Kryštof Černý <cleverline1mc@gmail.com> wrote: Hi Kryštof, thanks for the follow-up! > Just minor changes based on feedback. > > Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com> There is no need for a Signed-off-by: in the cover letter. But you are supposed to add any tags, like my "Reviewed-by", to a new revision. I guess unfortunately you missed the v6.12 merge window by an hour or so, but in any case I hope Chen-Yu can copy in the tags when applying. > --- > Changes in v3: > - Renamed patches - added prefix. > - Remove the patch that added regulator to emmc. > - Link to v2: https://lore.kernel.org/r/20240827-nanopi-neo-plus2-regfix-v2-0-497684ec82c7@gmail.com Thanks for the changelog, that's helpful. Ideally you would stack this up with the changes from previous revisions, so listing the changes from v1 .. v2 here as well. Cheers, Andre > > --- > Kryštof Černý (2): > arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators > arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio > > .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > --- > base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12 > change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca > > Best regards,
From: Chen-Yu Tsai <wens@csie.org> On Thu, 05 Sep 2024 19:37:09 +0200, Kryštof Černý wrote: > Just minor changes based on feedback. > > Applied to sunxi/dt-for-6.12 in sunxi/linux.git, thanks! [1/2] arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators https://git.kernel.org/sunxi/linux/c/37ed8e75c660 [2/2] arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio https://git.kernel.org/sunxi/linux/c/605f56405a67 I also changed the "H5" in the subject to lowercase, matching most other commits. Best regards,
Just minor changes based on feedback. Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com> --- Changes in v3: - Renamed patches - added prefix. - Remove the patch that added regulator to emmc. - Link to v2: https://lore.kernel.org/r/20240827-nanopi-neo-plus2-regfix-v2-0-497684ec82c7@gmail.com --- Kryštof Černý (2): arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) --- base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12 change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca Best regards,