From patchwork Thu Sep 5 18:52:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 13792882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B8D0CE7A89 for ; Thu, 5 Sep 2024 19:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=PqFNwfvYsgS6vo30lTnhwzemr9bycu9C6rzu97s2RSs=; b=AnwzKB454zplcwCvekS4w2ZvyN VFvCCe/3MYSz6SsuNZ0pjm80zkEsFxCaZyfuz40G7I1XCiz/vCJa4MExRmdS438yXugsCna/kpUVN ICQRy6DqOP5BOgsdPAibvUJoZOoN+DWTicsHJX9/MveX0XY3fNxJyRU9A1T62OQYqQ5jNxh2VKLR8 NTdCdP9tC/W/yumMsiQKL9JIaYJUVtOH69Wa9IbB3rVs65WRAXJ/yVKIB3oXCnFKbsOYiFqDrRRqb LjJpo4Q9n+ekqQkv6XxY6BKOmmsDVORRuQoiYa3vk2CwjLQVjarbWd8Ef9IJlConzIACDTHT3qmF2 C19WXL8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smHjj-00000009X5k-1wd0; Thu, 05 Sep 2024 19:01:43 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smHbB-00000009Uxj-0nbb; Thu, 05 Sep 2024 18:52:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PqFNwfvYsgS6vo30lTnhwzemr9bycu9C6rzu97s2RSs=; b=QQcU3hd5iiI3eF/kwRllkGjuts fti1YV+ELJokmUHIIKRJrcijXJwg3XGB8qXenCruLZDyC2uec8mjg30myz4L5bVT4EVbre0egKve7 n3GQzvy0RZh01y1NIoHl0QM+M1VSGrDdtFQGWod3W1B7ailP0LQAsxlCqdXoEkGPB8x55kO7qyd/3 iqeWuGjhGMtklLMoKgAPVuozHLZQJekQiFQc1kbYBWdjLucVz9ZE05ZbeQ5nhY7UyRfySeOvxD3AT iMk6bT7vSiJVONgaZqM6njIAWP/9/0/3/9Bvl0cq3c7dSuZVyjlBOvCLufHAW+sV7gt5cUi5InTBA P8ka+nGg==; Received: from i5e860d0f.versanet.de ([94.134.13.15] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smHav-0003sR-Uu; Thu, 05 Sep 2024 20:52:38 +0200 From: Heiko Stuebner To: lee@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jdelvare@suse.com, linux@roeck-us.net, heiko@sntech.de, dmitry.torokhov@gmail.com, pavel@ucw.cz, ukleinek@debian.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v7 0/8] Drivers to support the MCU on QNAP NAS devices Date: Thu, 5 Sep 2024 20:52:24 +0200 Message-ID: <20240905185232.2899464-1-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_115253_337905_F9BDA851 X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This implements a set of drivers for the MCU used on QNAP NAS devices. Of course no documentation for the serial protocol is available, so thankfully QNAP has a tool on their rescue-inird to talk to the MCU and I found interceptty [0] to listen to what goes over the serial connection. In general it looks like there are two different generations in general, an "EC" device and now this "MCU" - referenced in the strings of the userspace handlers for those devices. For the MCU "SPEC3" and "SPEC4" are listed which is configured in the model.conf of the device. When setting the value from SPEC4 to SPEC3 on my TS433, the supported commands change, but the command interface stays the same and especially the version command is the same. The binding also does not expose any interals of the device that might change, so hopefully there shouldn't be big roadblocks to support different devices, apart from possibly adapting the commands. changes in v7: - use ASCII representation in commands where possible instead of hex vals - drop get_variant function and use mfd platform-data instead mfd: - a lot of style improvements leds: - name variables better (value -> brightness, num -> num_err_led) - handle preservation of blink mode more effectively - snprintf -> scnprintf - drop duplicate "failed to register ... LED" messages changes in v6: - format mcu commands arrays in single lines (Lee) mfd: - drop obsolete remain kdoc for the removed reply_lock (kernel test robot) changes in v5: binding: - add Conor's Reviewed-by mfd: Address comments from Lee - improve commit message - improve Kconfig help text - sort headers alphabetical - style and spelling improvements - constants for magic numbers - drop reply assignment, the mcu only replies to commands sent to it, so there should only ever be one command in fligth. hwmon: Add Acked-by from Guenter and address some remarks - don't allow empty fan subnode - use num var directly when getting cooling levels, without using ret intermediate - use dev_err_probe in thermal init function changes in v4: binding: - move cooling properties into a fan subnode and reference fan-common.yaml (Rob) - dropped Krzysztof's Ack because of this mfd: - use correct format-string for size_t (kernel test robot) input: - added Dmitry's Ack hwmon: - adapted to fan-subnode when reading cooling properties - dropped Guenter's Ack because of this changes in v3: mfd - use correct power-off priority: default - constify the cmd-data array in command functions (Dmitry) leds: - don't point to temporary buffers for cdev->name (Florian Eckert) hwmon: - use clamp_val(), don't try to reimplement (Guenter) - add Guenter's Ack input: address Dmitry's comments - constify some cmd arrays - add input-close callback to cancel beep worker - drop initial input event report changes in v2: binding: - rename to qnap,ts433-mcu.yaml (Krzysztof) - drop "preserve formatting" indicator (Krzysztof) - add Krzysztof's Review tag mfd: - fix checkpatch --strict CHECKs - add a MAINTAINERS entry for all qnap-mcu-parts Heiko Stuebner (8): mfd: core: make platform_data pointer const in struct mfd_cell dt-bindings: mfd: add binding for qnap,ts433-mcu devices mfd: add base driver for qnap-mcu devices leds: add driver for LEDs from qnap-mcu devices Input: add driver for the input part of qnap-mcu devices hwmon: add driver for the hwmon parts of qnap-mcu devices arm64: dts: rockchip: hook up the MCU on the QNAP TS433 arm64: dts: rockchip: set hdd led labels on qnap-ts433 .../bindings/mfd/qnap,ts433-mcu.yaml | 42 ++ Documentation/hwmon/index.rst | 1 + Documentation/hwmon/qnap-mcu-hwmon.rst | 27 ++ MAINTAINERS | 9 + .../boot/dts/rockchip/rk3568-qnap-ts433.dts | 61 +++ drivers/hwmon/Kconfig | 12 + drivers/hwmon/Makefile | 1 + drivers/hwmon/qnap-mcu-hwmon.c | 364 ++++++++++++++++++ drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/qnap-mcu-input.c | 153 ++++++++ drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-qnap-mcu.c | 227 +++++++++++ drivers/mfd/Kconfig | 13 + drivers/mfd/Makefile | 2 + drivers/mfd/qnap-mcu.c | 332 ++++++++++++++++ include/linux/mfd/core.h | 2 +- include/linux/mfd/qnap-mcu.h | 26 ++ 19 files changed, 1296 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml create mode 100644 Documentation/hwmon/qnap-mcu-hwmon.rst create mode 100644 drivers/hwmon/qnap-mcu-hwmon.c create mode 100644 drivers/input/misc/qnap-mcu-input.c create mode 100644 drivers/leds/leds-qnap-mcu.c create mode 100644 drivers/mfd/qnap-mcu.c create mode 100644 include/linux/mfd/qnap-mcu.h