From patchwork Fri Sep 6 07:24:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13793514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC07ACE7AE0 for ; Fri, 6 Sep 2024 07:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=YTK9xizXwMLeg8LNBSTAbWJGrOd+mke1j6EvahcAWVE=; b=VkL/C7URzS+vgm7vd2jvSbj8ew w84PPh8e+7eCkz632heANc2fGYtZ93BxtLAIFYEv7gH8N53j4Jroi68qL24IYXDUPHnRqNGtPsU7K d9zkUeAXOZDk4gO8ZF3SJxSJAmI/7/8fmNONNi8dFl1cyTx8lekcMGA+HxRaASfiui3CFDzbFu/as 4e8sSE/HkDnqMKxxuRwEd5S0yIMx8xc+IqAJQKJIHnuPbipH2ySkTV0SplQrM15eop0/vYb/3xw/j pNyqXpp4TQ2udehjW7xD2C6e+tAcveXbcUU7ITQnBUsOeZcArynLVV39kJK9mr9j29Lml6WaN2UEG eYe71rbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smTXs-0000000B7tK-1d9M; Fri, 06 Sep 2024 07:38:16 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smTLO-0000000B4Kf-3kNs; Fri, 06 Sep 2024 07:25:25 +0000 Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A018FEF3; Fri, 6 Sep 2024 09:24:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725607444; bh=K1WcmrcLbEELBSkrxY1A3Spx7Lfdyu+4/yUq696iEAg=; h=From:To:Cc:Subject:Date:From; b=jbqABgOBBaoWeQRIINe/jW9ME8XGFVSmDB017NiuuUsKkMUC30vo/iA35Gahf9YMr 1CFD/fb6PkuFwEghTLK9Z09UciEqyVwsIAijaYClZQIDGfqokZiS84tcPSn2gUjZ/x C8gqsY0J6UJT0BR4X1TpKaA6Q4h1uNvgLNItku5w= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Arnd Bergmann , Stefan Wahren , Dave Stevenson , Phil Elwell , Laurent Pinchart , Umang Jain Subject: [PATCH v4 0/7] staging: vchiq_core: Refactor vchiq_bulk_transfer() logic Date: Fri, 6 Sep 2024 12:54:59 +0530 Message-ID: <20240906072506.174026-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_002523_095650_E3F3E8B8 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Series mostly refactors vchiq_bulk_transfer() code according to Arnd's review comment from [1]: > You can also wrap vchiq_bulk_transfer() in order to have > four separate functions based on the different 'mode' > values and have them only take the arguments they actually > need. I didn't wrap vchiq_bulk_transfer(), instead created four differnet function, one for each mode. This will pave the way to address his second comment: > Ideally this should be cleaned up in a way that completely > avoids passing both user and kernel data at the same time. which is not part of this series and will be done on top as arguments shuffling will have to fix the sparse warnings that exists currently. Patch 1/7 first moves the VCHIQ_BULK_MODE_WAITING logic out of vchiq_bulk_transfer Patch 2/7 then moves the core logic to vchiq_bulk_transfer() which can be shared in subsequent patches Patch 3/7 and 4/7 refactors remaining bulk transfer modes Patch 5/7 finally drops the vchiq_bulk_transfer() as not needed patch 6/7 and 7/7 are drive by patches, noticed during development. [1]: https://lore.kernel.org/linux-staging/3d3b7368-93b2-4c0d-845e-4099c2de9dc1@app.fastmail.com/ Changes in v4: - In 1/7 return 0 direcly instead of assigning status = 0 - In 3/7, fix null assignment of bulk waiter CHanges in v3: - Directly return if service == NULL in 1/7 and 4/7 - Drop set-but-unused variable from 1/7 Changes in v2: - Directly return if service == NULL in 3/7 - Prefix non-static functions with "vchiq_" (appropriate driver prefix) - Use typed argument for 'userdata' in 1/7 Umang Jain (7): staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITING staging: vchiq_core: Simplify vchiq_bulk_transfer() staging: vchiq_core: Factor out bulk transfer for blocking mode staging: vchiq_core: Factor out bulk transfer for (no/)callback mode staging: vchiq_core: Drop vchiq_bulk_transfer() staging: vchiq_core: Remove unused function argument staging: vchiq_core: Pass enumerated flag instead of int .../interface/vchiq_arm/vchiq_arm.c | 20 +- .../interface/vchiq_arm/vchiq_core.c | 319 +++++++++++------- .../interface/vchiq_arm/vchiq_core.h | 16 +- .../interface/vchiq_arm/vchiq_dev.c | 15 +- 4 files changed, 228 insertions(+), 142 deletions(-)