From patchwork Wed Sep 11 22:24:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colton Lewis X-Patchwork-Id: 13801166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CF7DEE57DB for ; Wed, 11 Sep 2024 22:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:Mime-Version:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=T+nODGyulHWxs0JnvJus4UAc0zy0GDYGIyi7bhZj7WY=; b=LQbzadHvkhdS5aregsEukjtIzz SwmzxhaJmsBUv+cZe7Ykld/WOfoOn5qvHb++lg+OnElqkgmeSB0vGTwSE1DAHbrWADc6sAf5S0i2f wBbnY/ttptyXH5HKi0/JwAcVFVRUil06rY7+lQulcT2nSMVBCqvGpmcotggu/Hm8Uni++nzWiHBzd hfqoUe0RRwOyjkhihyaR7OtG4YpMkaeH7FKu1G+tLHnwIHNbxpQjbUqoQsV1uz5QSir2q4/gXmYfi ToaIDwNGeffiJIN5R45fvFyjPF+Q4cie6ei6+nNhbOsL9EMDcdlxYIgS4pPq+HdLlMCBV0al7dqiH QsQUldwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soVn2-0000000BBMC-0AHc; Wed, 11 Sep 2024 22:26:20 +0000 Received: from mail-il1-x14a.google.com ([2607:f8b0:4864:20::14a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soVlu-0000000BAy7-48Nl for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 22:25:12 +0000 Received: by mail-il1-x14a.google.com with SMTP id e9e14a558f8ab-3a05311890bso6841945ab.1 for ; Wed, 11 Sep 2024 15:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726093509; x=1726698309; darn=lists.infradead.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=T+nODGyulHWxs0JnvJus4UAc0zy0GDYGIyi7bhZj7WY=; b=EJ6+2MpJwf8PR2YMe49LQOoyc8YIchYZ5R29Raqmcmc9L/LBv1BqlbKHyUOsYTTAno zzaldhPrZt9GhvPiZUOzhFxVATO8uSUoQ8S+jhqmEKvhQTf2uPC6d7j6y+4W5SFjZVaj W4jEDkTfzCmnp2XFcrBL3mEtjKVAy9VPvWbpp3boH4Dvpn/aEQnD4eLf+e2FV2YqZT/s z8jevLiL0lwP0gYGyvAUxjYRrxKWQrnWNOKttvQS9Nq0a2TXZuAIBayVFxhn3qE+hqSE 1GDtGZoHu/PZH5CCirDtMxwi1Fszwt4S3+5n6SAlDF5qm+FOk3u8NzkFzqZ46+G/O6l6 e2Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726093509; x=1726698309; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T+nODGyulHWxs0JnvJus4UAc0zy0GDYGIyi7bhZj7WY=; b=KSajs/EqRrUloZus9YL5vB36UoMnksJrE8XGmJXeinjhG/ajHA7sDtRIgcMnQ7UMNH QtFggNqFP/4aKSbE8zGMqHrq00V78CT2RHLaMZrbVitC1gEZs6t8hoeRpDNr6d7pagI7 CoUpBdYFSIEcH5D9jnsox5KTgaz1XjnuyQYxZo0YJjFV4I4xWXTBQbgLjuipDOETSe0n oww5/Q5kZU1e42LpUfy7REFv9GL5absMTCLbpjDhQBg7+CqdKlr5pYuXJZ71kTNck1M+ WW5GnONFRx+YKADW6h1NEJxwdfc9uG//6jJRmk+4WhMP6fSqZZdVmlMnv6LvlWiHQhb/ cNhg== X-Forwarded-Encrypted: i=1; AJvYcCVhad9+mQBY5lohOzQghWQE3DGHY1A2ZfXrRGJFzuqzbVUNgeneimnz14bPWZ7ZXg2HnEQrt3QnkJ1k05ENv5dR@lists.infradead.org X-Gm-Message-State: AOJu0Ywnk0xgqvsopSepux8JdlF2hhWZ4hJukhCZIdp+C/b+08UHS4sq T3EjTEzsdP8U0uUrKPcjRKbDFTkM5wK/gNqP0vW/tmaE8Qox+SM6fztNFkaUFKmxSWoH9f699cR I/HkZuuthRo3OL6pSpFMINw== X-Google-Smtp-Source: AGHT+IGXXpOojFFO7Gu+zUTSei0211tStzLtWSxgCQLqddaqaDV88691OqMetcHXtFlM9KtKiGpFHXylg3PWPs5bQA== X-Received: from coltonlewis-kvm.c.googlers.com ([fda3:e722:ac3:cc00:11b:3898:ac11:fa18]) (user=coltonlewis job=sendgmr) by 2002:a05:6e02:2181:b0:3a0:80ae:71b6 with SMTP id e9e14a558f8ab-3a084976fe0mr327905ab.6.1726093509599; Wed, 11 Sep 2024 15:25:09 -0700 (PDT) Date: Wed, 11 Sep 2024 22:24:27 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.46.0.598.g6f2099f65c-goog Message-ID: <20240911222433.3415301-1-coltonlewis@google.com> Subject: [PATCH v2 0/5] Correct perf sampling with Guest VMs From: Colton Lewis To: kvm@vger.kernel.org Cc: Oliver Upton , Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Will Deacon , Russell King , Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Colton Lewis X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_152511_055461_76DF89CA X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v2: * Better explain commit messages * Fix incorrect type in patch 2 * Fix missing argument in call to common_misc_flags() in patch 5 * Rebase to 6.11-rc7 and include base commit in letter v1: https://lore.kernel.org/kvm/20240904204133.1442132-1-coltonlewis@google.com/ This series cleans up perf recording around guest events and improves the accuracy of the resulting perf reports. Perf was incorrectly counting any PMU overflow interrupt that occurred while a VCPU was loaded as a guest event even when the events were not truely guest events. This lead to much less accurate and useful perf recordings. See as an example the below reports of `perf record dirty_log_perf_test -m 2 -v 4` before and after the series on ARM64. Without series: Samples: 15K of event 'instructions', Event count (approx.): 31830580924 Overhead Command Shared Object Symbol 54.54% dirty_log_perf_ dirty_log_perf_test [.] run_test 5.39% dirty_log_perf_ dirty_log_perf_test [.] vcpu_worker 0.89% dirty_log_perf_ [kernel.vmlinux] [k] release_pages 0.70% dirty_log_perf_ [kernel.vmlinux] [k] free_pcppages_bulk 0.62% dirty_log_perf_ dirty_log_perf_test [.] userspace_mem_region_find 0.49% dirty_log_perf_ dirty_log_perf_test [.] sparsebit_is_set 0.46% dirty_log_perf_ dirty_log_perf_test [.] _virt_pg_map 0.46% dirty_log_perf_ dirty_log_perf_test [.] node_add 0.37% dirty_log_perf_ dirty_log_perf_test [.] node_reduce 0.35% dirty_log_perf_ [kernel.vmlinux] [k] free_unref_page_commit 0.33% dirty_log_perf_ [kernel.vmlinux] [k] __kvm_pgtable_walk 0.31% dirty_log_perf_ [kernel.vmlinux] [k] stage2_attr_walker 0.29% dirty_log_perf_ [kernel.vmlinux] [k] unmap_page_range 0.29% dirty_log_perf_ dirty_log_perf_test [.] test_assert 0.26% dirty_log_perf_ [kernel.vmlinux] [k] __mod_memcg_lruvec_state 0.24% dirty_log_perf_ [kernel.vmlinux] [k] kvm_s2_put_page With series: Samples: 15K of event 'instructions', Event count (approx.): 31830580924 Samples: 15K of event 'instructions', Event count (approx.): 30898031385 Overhead Command Shared Object Symbol 54.05% dirty_log_perf_ dirty_log_perf_test [.] run_test 5.48% dirty_log_perf_ [kernel.kallsyms] [k] kvm_arch_vcpu_ioctl_run 4.70% dirty_log_perf_ dirty_log_perf_test [.] vcpu_worker 3.11% dirty_log_perf_ [kernel.kallsyms] [k] kvm_handle_guest_abort 2.24% dirty_log_perf_ [kernel.kallsyms] [k] up_read 1.98% dirty_log_perf_ [kernel.kallsyms] [k] __kvm_tlb_flush_vmid_ipa_nsh 1.97% dirty_log_perf_ [kernel.kallsyms] [k] __pi_clear_page 1.30% dirty_log_perf_ [kernel.kallsyms] [k] down_read 1.13% dirty_log_perf_ [kernel.kallsyms] [k] release_pages 1.12% dirty_log_perf_ [kernel.kallsyms] [k] __kvm_pgtable_walk 1.08% dirty_log_perf_ [kernel.kallsyms] [k] folio_batch_move_lru 1.06% dirty_log_perf_ [kernel.kallsyms] [k] __srcu_read_lock 1.03% dirty_log_perf_ [kernel.kallsyms] [k] get_page_from_freelist 1.01% dirty_log_perf_ [kernel.kallsyms] [k] __pte_offset_map_lock 0.82% dirty_log_perf_ [kernel.kallsyms] [k] handle_mm_fault 0.74% dirty_log_perf_ [kernel.kallsyms] [k] mas_state_walk Colton Lewis (5): arm: perf: Drop unused functions perf: Hoist perf_instruction_pointer() and perf_misc_flags() powerpc: perf: Use perf_arch_instruction_pointer() x86: perf: Refactor misc flag assignments perf: Correct perf sampling with guest VMs arch/arm/include/asm/perf_event.h | 7 --- arch/arm/kernel/perf_callchain.c | 17 ------- arch/arm64/include/asm/perf_event.h | 4 -- arch/arm64/kernel/perf_callchain.c | 28 ------------ arch/powerpc/include/asm/perf_event_server.h | 6 +-- arch/powerpc/perf/callchain.c | 2 +- arch/powerpc/perf/callchain_32.c | 2 +- arch/powerpc/perf/callchain_64.c | 2 +- arch/powerpc/perf/core-book3s.c | 4 +- arch/s390/include/asm/perf_event.h | 6 +-- arch/s390/kernel/perf_event.c | 4 +- arch/x86/events/core.c | 48 ++++++++++++-------- arch/x86/include/asm/perf_event.h | 12 +++-- include/linux/perf_event.h | 26 +++++++++-- kernel/events/core.c | 27 ++++++++++- 15 files changed, 96 insertions(+), 99 deletions(-) base-commit: da3ea35007d0af457a0afc87e84fddaebc4e0b63 --- 2.46.0.598.g6f2099f65c-goog