| Message ID | 20240914215458.751802-1-leo.yan@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | perf arm-spe: Introduce metadata version 2 | expand |
On 9/14/24 22:54, Leo Yan wrote: > This patch series enhances Arm SPE metadata in the Perf file to a > version 2 format and maintains backward compatibility for metadata v1. > > The version 2 metadata contains a global structure with fields for > metadata header version number, header size, CPU numbers. It also > expands to store per-CPU metadata, which includes the CPU logical > number in the kernel, MIDR, and capacity values associated with Arm SPE. > > This patch set has been tested the perf to decode the Arm SPE metadata > v1 and v2. > > Changes from v1: > - Dropped LDS bit exposing from Arm SPE driver (Will Deacon). > - To simplify the change, this series did not include multiple AUX event > support. Hi Arnaldo, Namhyung, Gentle ping. There is a bit backlog for Arm SPE patches, so I would like to bring up this series and the series [1] for the Arm SPE data source refactoring (which is dependent on the current series). Please kindly review and pick it up if it is fine for you. Thanks, Leo [1] https://lore.kernel.org/linux-perf-users/20240914220901.756177-1-leo.yan@arm.com/ > Leo Yan (5): > perf arm-spe: Define metadata header version 2 > perf arm-spe: Calculate meta data size > perf arm-spe: Save per CPU information in metadata > perf arm-spe: Support metadata version 2 > perf arm-spe: Dump metadata with version 2 > > tools/perf/arch/arm64/util/arm-spe.c | 106 ++++++++++++++++++- > tools/perf/util/arm-spe.c | 151 +++++++++++++++++++++++++-- > tools/perf/util/arm-spe.h | 38 ++++++- > 3 files changed, 281 insertions(+), 14 deletions(-) >
Hi Leo, On Thu, Sep 26, 2024 at 05:20:49PM +0100, Leo Yan wrote: > On 9/14/24 22:54, Leo Yan wrote: > > This patch series enhances Arm SPE metadata in the Perf file to a > > version 2 format and maintains backward compatibility for metadata v1. > > > > The version 2 metadata contains a global structure with fields for > > metadata header version number, header size, CPU numbers. It also > > expands to store per-CPU metadata, which includes the CPU logical > > number in the kernel, MIDR, and capacity values associated with Arm SPE. > > > > This patch set has been tested the perf to decode the Arm SPE metadata > > v1 and v2. > > > > Changes from v1: > > - Dropped LDS bit exposing from Arm SPE driver (Will Deacon). > > - To simplify the change, this series did not include multiple AUX event > > support. > > Hi Arnaldo, Namhyung, > > Gentle ping. There is a bit backlog for Arm SPE patches, so I would > like to bring up this series and the series [1] for the Arm SPE data > source refactoring (which is dependent on the current series). > > Please kindly review and pick it up if it is fine for you. While it seems like general changes, I'd like to see some ARM folks reviewing this series. Thanks, Namhyung > > [1] https://lore.kernel.org/linux-perf-users/20240914220901.756177-1-leo.yan@arm.com/ > > > > Leo Yan (5): > > perf arm-spe: Define metadata header version 2 > > perf arm-spe: Calculate meta data size > > perf arm-spe: Save per CPU information in metadata > > perf arm-spe: Support metadata version 2 > > perf arm-spe: Dump metadata with version 2 > > > > tools/perf/arch/arm64/util/arm-spe.c | 106 ++++++++++++++++++- > > tools/perf/util/arm-spe.c | 151 +++++++++++++++++++++++++-- > > tools/perf/util/arm-spe.h | 38 ++++++- > > 3 files changed, 281 insertions(+), 14 deletions(-) > >
Hi Namhyung, On 9/27/24 07:10, Namhyung Kim wrote: >> Hi Arnaldo, Namhyung, >> >> Gentle ping. There is a bit backlog for Arm SPE patches, so I would >> like to bring up this series and the series [1] for the Arm SPE data >> source refactoring (which is dependent on the current series). >> >> Please kindly review and pick it up if it is fine for you. > > While it seems like general changes, I'd like to see some ARM folks > reviewing this series. Fair point. I will chase review internally after sending a new spin (I think I turned my eyes to James ;)). Thanks a lot for review! Leo