From patchwork Wed Oct 9 15:49:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 13828703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C06F7CEE326 for ; Wed, 9 Oct 2024 15:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To: From:Subject:Message-ID:Mime-Version:Date:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=mp1GmMvEsdG1xOqt7J6qefXNw1tx4nozkIWjiF4j3SI=; b=IzzjGZIXhwjzrYGzOnPFm2goub NpS7hkr8kd01dz0iWLbElu1i5TIGHzitXAiBW1FYKwCK+BGAaD4BAKc5dgKPq9aFlV/hVTFs0m+vs n5EmQPv7eG92Z87UB4hFtBt98byaWyJNiwF906gtjw0p8gkd/NQjPBrw60KgIMYzlNwkbCenM5duq 09XO1V/NGZ8xKT3XcfQb/uqBkWRl+H0uB+TH74ArWdMuPqnA35cFSeMdcdP+1mzGxSKaBniu3cGab U4l0U3iTbNQN5hHxSo29/0ixR8WKQp6Hy6g2ldx8PYlNc3Zsb7n8EXjIsmz6rJzzg5JZpWDKRBHdU hR+aiHwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syZ0Q-00000009oot-2dsn; Wed, 09 Oct 2024 15:53:42 +0000 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syYwo-00000009nzm-0Ryg for linux-arm-kernel@lists.infradead.org; Wed, 09 Oct 2024 15:49:59 +0000 Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-7ea0d46d1f0so4487328a12.2 for ; Wed, 09 Oct 2024 08:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728488996; x=1729093796; darn=lists.infradead.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=mp1GmMvEsdG1xOqt7J6qefXNw1tx4nozkIWjiF4j3SI=; b=IutsCtbi8727Qay0nh9a5iM0k49/t3K39IcpMtHwSBd63wamLV+Ngqg0uYkIeo7+qf rTUsM0tWsPLY/qqOliK5hnvmcpwRtjf9xaPLawLF6nv5T7+udc6tsjU8Nno/J845D9IP xy3tlFhgh4VJynkf32udSVHXzHNPTaFEtqhcMyKRhSOOm7fvIQR8z6B2Q1k7zlN12Gp9 yl6cjyCFHxk4wX54KiXvPz9jWROLineolLEQGOOs38DX8ORkgSvSMN84UbC3cZkHo/4t u75R4slENbtwnnLYBuvgkBGcxl+31kARUJIITp/RdtyySCWCIbXi20Gl6n0xLwDsWAWm d86w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728488996; x=1729093796; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mp1GmMvEsdG1xOqt7J6qefXNw1tx4nozkIWjiF4j3SI=; b=IWPREuBhT0BXcaefhxTR5ACQELE5CamklX4b8Q5ybIGjXI0OhD+koZ4iZlNPRdyxHQ 2LAK8EXluXsxNDAlPjC4nT/ZXl9FhRvjMtZMeUaw5Q1aOX5oZp6BxV0BJDINmfjo1njR NB28sLCQK0ts6bKNmuhJL9vqgyk6B5bLs/Zfw7hRG8Qs9af+gKnUqzufWQjOQ4o9u9Pa rKh0+OHrLu4SKYq/jOJf+WHfXJd6hOSpQRek5JH6n5RGHZO+M73uYqbACZK2xzTWC6Fr VkFybWlpXz5zt1djtzocysolo+xLhv6e+2o2mAjCSbhomI5cy+OrObnTrHDTRkcCPjP6 CIvg== X-Gm-Message-State: AOJu0YwPO9Lsyz2m2tZkulq8b1yYUqAdrEL/xKej6PeiOzD92ll1mPxW bqGklS55hf/fYdhMfKrHq8K3VdaD1htlOliAAySoLQMAkeavY1fRMtWRGu5P0//QqWClE2Tkl5L e2Q== X-Google-Smtp-Source: AGHT+IEKF1Ho4VsrxKapa7g6WWX3VRxIkgUDz21gNBA5z4SeEUBMmHmDj2XN+crbLzcKc/g4iyRtc0M+qRE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:90a:468a:b0:2e0:6c40:e384 with SMTP id 98e67ed59e1d1-2e2a251444emr3074a91.4.1728488995562; Wed, 09 Oct 2024 08:49:55 -0700 (PDT) Date: Wed, 9 Oct 2024 08:49:39 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.47.0.rc0.187.ge670bccf7e-goog Message-ID: <20241009154953.1073471-1-seanjc@google.com> Subject: [PATCH v3 00/14] KVM: selftests: Morph max_guest_mem to mmu_stress From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Sean Christopherson , Andrew Jones , James Houghton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_084958_167864_BE6ECB9D X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The main purpose of this series is to convert the max_guest_memory_test into a more generic mmu_stress_test. The basic gist of the "conversion" is to have the test do mprotect() on guest memory while vCPUs are accessing said memory, e.g. to verify KVM and mmu_notifiers are working as intended. Patches 1-4 are a somewhat unexpected side quest. The original plan was that patch 3 would be a single patch, but things snowballed. Patch 3 reworks vcpu_get_reg() to return a value instead of using an out-param. This is the entire motivation for including these patches; having to define a variable just to bump the program counter on arm64 annoyed me. Patch 4 adds hardening to vcpu_{g,s}et_reg() to detect potential truncation, as KVM's uAPI allows for registers greater than the 64 bits that are supported in the "outer" selftests APIs ((vcpu_set_reg() takes a u64, vcpu_get_reg() now returns a u64). Patch 1 is a change to KVM's uAPI headers to move the KVM_REG_SIZE definition to common code so that the selftests side of things doesn't need #ifdefs to implement the hardening in patch 4. Patch 2 is the truly unexpected part. With the vcpu_get_reg() rework, arm64's vpmu_counter_test fails when compiled with gcc-13, and on gcc-11 with an added "noinline". Long story short, selftests are being compiled with strict aliasing enabled, which allows the compiler to optimize away "u64 *" => "uint64_t *" casts as u64 (unsigned long long) and uint64_t (unsigned long) are technically not aliases of each other. *sigh* v3: - Rebased onto v6.12-rc2. - Disable strict aliasing to fix the PMCR snafu. - Collect reviews. [Drew] - Minor changelog fixes. [Drew] - Include ucall_common.h to prep for RISC-V. [Drew] v2: - Rebase onto kvm/next. - Add the aforementioned vcpu_get_reg() changes/disaster. - Actually add arm64 support for the fancy mprotect() testcase (I did this before v1, but managed to forget to include the changes when posting). - Emit "mov %rax, (%rax)" on x86. [James] - Add a comment to explain the fancy mprotect() vs. vCPUs logic. - Drop the KVM x86 patches (applied and/or will be handled separately). v1: https://lore.kernel.org/all/20240809194335.1726916-1-seanjc@google.com Sean Christopherson (14): KVM: Move KVM_REG_SIZE() definition to common uAPI header KVM: selftests: Disable strict aliasing KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param KVM: selftests: Assert that vcpu_{g,s}et_reg() won't truncate KVM: selftests: Check for a potential unhandled exception iff KVM_RUN succeeded KVM: selftests: Rename max_guest_memory_test to mmu_stress_test KVM: selftests: Only muck with SREGS on x86 in mmu_stress_test KVM: selftests: Compute number of extra pages needed in mmu_stress_test KVM: sefltests: Explicitly include ucall_common.h in mmu_stress_test.c KVM: selftests: Enable mmu_stress_test on arm64 KVM: selftests: Use vcpu_arch_put_guest() in mmu_stress_test KVM: selftests: Precisely limit the number of guest loops in mmu_stress_test KVM: selftests: Add a read-only mprotect() phase to mmu_stress_test KVM: selftests: Verify KVM correctly handles mprotect(PROT_READ) arch/arm64/include/uapi/asm/kvm.h | 3 - arch/riscv/include/uapi/asm/kvm.h | 3 - include/uapi/linux/kvm.h | 4 + tools/testing/selftests/kvm/Makefile | 11 +- .../selftests/kvm/aarch64/aarch32_id_regs.c | 10 +- .../selftests/kvm/aarch64/debug-exceptions.c | 4 +- .../selftests/kvm/aarch64/hypercalls.c | 6 +- .../selftests/kvm/aarch64/no-vgic-v3.c | 2 +- .../testing/selftests/kvm/aarch64/psci_test.c | 6 +- .../selftests/kvm/aarch64/set_id_regs.c | 18 +- .../kvm/aarch64/vpmu_counter_access.c | 19 +- .../testing/selftests/kvm/include/kvm_util.h | 10 +- .../selftests/kvm/lib/aarch64/processor.c | 8 +- tools/testing/selftests/kvm/lib/kvm_util.c | 3 +- .../selftests/kvm/lib/riscv/processor.c | 66 +++---- ..._guest_memory_test.c => mmu_stress_test.c} | 162 ++++++++++++++++-- .../testing/selftests/kvm/riscv/arch_timer.c | 2 +- .../testing/selftests/kvm/riscv/ebreak_test.c | 2 +- .../selftests/kvm/riscv/sbi_pmu_test.c | 2 +- tools/testing/selftests/kvm/s390x/resets.c | 2 +- tools/testing/selftests/kvm/steal_time.c | 3 +- 21 files changed, 241 insertions(+), 105 deletions(-) rename tools/testing/selftests/kvm/{max_guest_memory_test.c => mmu_stress_test.c} (60%) base-commit: 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b