From patchwork Fri Oct 11 13:16:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 13832561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1DA8D0D78D for ; Fri, 11 Oct 2024 13:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=g2TKGyJgT8HCzMKkLqirvkE55tzEqlmM1NvvlVJgJKA=; b=CaqmPtcPmtBlpC 1shkFj0vDcUn5HBD7BUqZVqY5UE5y9+s11Arckdw8ReqDSL6aFOgu/SjjgKeAzoQiIUNNRH/aCudt leelVxaX4PpZY0BuUjdnoGqbSiE0tvbtT4rR91tB2PPGAH79a67mgX9ItPnkohWsfwEooSAd4zefy aFKU1LWNq89EuuVjls6Xx+Um25B3Y1zYVZm0wzyyd/LAdBIBIH6XcCkGKcd8ViUBOPb19XO7xM9Im IwESCGRRXDA3uWzhIOVzmJ7eZ6qu5n1u0oUHB2/KImkv60CVwve9s/mq9pRKcYnCDPrGkDDSDuqxr t9c7yLW9fjfPybKJeR4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szFYF-0000000GQMF-0TUb; Fri, 11 Oct 2024 13:19:27 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szFWq-0000000GQ3h-1ToW for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 13:18:02 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5c5bca6603aso2374111a12.1 for ; Fri, 11 Oct 2024 06:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1728652678; x=1729257478; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=g2TKGyJgT8HCzMKkLqirvkE55tzEqlmM1NvvlVJgJKA=; b=VrrP3AXC9qRoLIyW0hz5AeUdg0ugtlXyU3bR3h8bPPQVyPvMfzEOOSC9eMarL/qQAS v3NeWeND7u2fnxXTWCXpV7xhVV1vFNeferdhkloaoT6Kvez3Z6B+s2Zhi9zfzzmtCw5F mhwcXsu1F9lo63dMdMWl002kE+5Kst1QJvYbOkixYHAHai5ap84nYKMBMqWgmWivg1K6 nsCjm+tbFDgMIMIMdQeXX7iLLf0ObWZMp8KfQwBQTvczW99pGBD9jx2UgFcF2g+dbiOW bWr5zDX+WS2vQFdq0uOwfPn4TUy+bC2y718joy8iieSd+5t64P2HQMoSuknK98zT7utK WupA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728652678; x=1729257478; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g2TKGyJgT8HCzMKkLqirvkE55tzEqlmM1NvvlVJgJKA=; b=ep4Smj8IMDN45UmEKqNes6WcCMCKdAZ2wpCNrnwSYpuwEKaaObdtVX/S78oq2Q9mQ3 HkUQXxABSXOpKBVr+xbENk8qxhnsrcFu/JtRk3ejQdhoHhIvE4ccZMhtS1W42IPFV0yD 5nalGFzwiu5nnKNPLAIIl13YXTNP7CI0dCLrn768rYEb6FIcQ8dv5Ukk/vNjhcFIz3Zf r1bn53GyUQAaxN+WMNlZRbEq7QQdq6GMx6RxQqPKlKRuJ7xTBF2c7gQVIQCSHmBS2zoI yDfRvPFI2S00Es+mmTJ24B320DiV0SKZHqMJFU4ce0VLUnywTJcZniOdsfUaXuedBZQb eTbA== X-Forwarded-Encrypted: i=1; AJvYcCUd5ZtlWaDAEWHQi+53VsiSnT5CQByJbHZkTimhxRXxHdAaUVylyBw/X286+dicMuPLQE0aPvghj2DW/tp7Z7b/@lists.infradead.org X-Gm-Message-State: AOJu0Yx+sgKw7ICVKU+EaYQ31Fdu0IQZLJmPhOAhC7hNpIrbNSx+nwRr paOC2s2R10OALQ20V7CiVEDFakHZ/jYyHI9xrvUdtO3dLcNve3YYeWN372QdTRI= X-Google-Smtp-Source: AGHT+IGKlXmjraErc8Ifbvkc14cGgVhYhFNKvbvyQPD7iVKNrtUZ8LzVrO5D9KawbCRnHnd0GlMvNA== X-Received: by 2002:a17:907:d850:b0:a99:8ed2:7e51 with SMTP id a640c23a62f3a-a99b95a5eaamr218199566b.53.1728652677943; Fri, 11 Oct 2024 06:17:57 -0700 (PDT) Received: from localhost ([2001:4090:a244:83ae:2517:2666:43c9:d0d3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a80bf9e8sm210562066b.98.2024.10.11.06.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 06:17:57 -0700 (PDT) From: Markus Schneider-Pargmann Subject: [PATCH v3 0/9] can: m_can: Add am62 wakeup support Date: Fri, 11 Oct 2024 15:16:37 +0200 Message-Id: <20241011-topic-mcan-wakeup-source-v6-12-v3-0-9752c714ad12@baylibre.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADUlCWcC/x3NTQrDIBBA4auEWXdATQkxVwldmHHSDqUqmj8Iu Xsly2/z3gmFs3CBoTkh8yZFYqhoHw3Qx4U3o/hqMMo8tVIWl5iE8Ecu4O6+vCYscc3EuHWoDfa kfWdtqyffQ42kzLMc92B8XdcfBtFf/nAAAAA= X-Change-ID: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Schiffer , Vishal Mahaveer , Kevin Hilman , Dhruva Gole , Markus Schneider-Pargmann , Andrew Lunn X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4056; i=msp@baylibre.com; h=from:subject:message-id; bh=AmDAWkwPTrSHqB94gNRQX6L8AQLPkbqcCXyEv5EfSaQ=; b=owGbwMvMwCGm0rPl0RXRdfaMp9WSGNI5VQNerDo5vfx2/fdOL5lSxdv/mXOjF62ZxKtb4h/wU WN3zM+NHaUsDGIcDLJiiix3Pyx8Vyd3fUHEukeOMHNYmUCGMHBxCsBE5sxiZHix3nOX7R8PF1Gu AGHGudrz/8ctkNirJjZJ4bL4+umPtPYz/PfcxiQr5XXTVXa9auxL74ZnKbe7D0/8JrD7/UeFHed CVzIDAA== X-Developer-Key: i=msp@baylibre.com; a=openpgp; fpr=BADD88DB889FDC3E8A3D5FE612FA6A01E0A45B41 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_061800_432047_C9E408AF X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Series ------ am62, am62a and am62p support Partial-IO, a poweroff SoC state with a few pin groups being active for wakeup. To support mcu_mcan0 and mcu_mcan1 wakeup for the mentioned SoCs, the series introduces a notion of wake-on-lan for m_can. If the user decides to enable wake-on-lan for a m_can device, the device is set to wakeup enabled. A 'wakeup' pinctrl state is selected to enable wakeup flags for the relevant pins. If wake-on-lan is disabled the default pinctrl is selected. It is based on v6.12-rc1. Partial-IO ---------- This series is part of a bigger topic to support Partial-IO on am62, am62a and am62p. Partial-IO is a poweroff state in which some pins are able to wakeup the SoC. In detail MCU m_can and two serial port pins can trigger the wakeup. A documentation can also be found in section 6.2.4 in the TRM: https://www.ti.com/lit/pdf/spruiv7 This other series is relevant for the support of Partial-IO: - firmware: ti_sci: Partial-IO support https://gitlab.baylibre.com/msp8/linux/-/tree/topic/am62-partialio/v6.12?ref_type=heads Testing ------- A test branch is available here that includes all patches required to test Partial-IO: https://gitlab.baylibre.com/msp8/linux/-/tree/integration/am62-lp-sk-partialio/v6.12?ref_type=heads After enabling Wake-on-LAN the system can be powered off and will enter the Partial-IO state in which it can be woken up by activity on the specific pins: ethtool -s can0 wol p ethtool -s can1 wol p poweroff I tested these patches on am62-lp-sk. Best, Markus Previous versions: v1: https://lore.kernel.org/lkml/20240523075347.1282395-1-msp@baylibre.com/ v2: https://lore.kernel.org/lkml/20240729074135.3850634-1-msp@baylibre.com/ Changes in v3: - Rebase to v6.12-rc1 - Change 'wakeup-source' to only 'true' - Simplify m_can_set_wol by returning early on error - Add vio-suuply binding and handling of this optional property. vio-supply is used to reflect the SoC architecture and which power line powers the m_can unit. This is important as some units are powered in special low power modes. Changes in v2: - Rebase to v6.11-rc1 - Squash these two patches for the binding into one: dt-bindings: can: m_can: Add wakeup-source property dt-bindings: can: m_can: Add wakeup pinctrl state - Add error handling to multiple patches of the m_can driver - Add error handling in m_can_class_allocate_dev(). This also required to add a new patch to return error pointers from m_can_class_allocate_dev(). Signed-off-by: Markus Schneider-Pargmann --- Markus Schneider-Pargmann (8): dt-bindings: can: m_can: Add wakeup properties dt-bindings: can: m_can: Add vio-supply can: m_can: Map WoL to device_set_wakeup_enable can: m_can: Return ERR_PTR on error in allocation can: m_can: Support pinctrl wakeup state can: m_can: Add use of optional regulator arm64: dts: ti: k3-am62: Mark mcu_mcan0/1 as wakeup-source arm64: dts: ti: k3-am62a-mcu: Mark mcu_mcan0/1 as wakeup-source Vibhore Vardhan (1): arm64: dts: ti: k3-am62p-mcu: Mark mcu_mcan0/1 as wakeup-source .../devicetree/bindings/net/can/bosch,m_can.yaml | 22 +++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 2 + arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 2 + .../boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 2 + drivers/net/can/m_can/m_can.c | 109 ++++++++++++++++++++- drivers/net/can/m_can/m_can.h | 4 + drivers/net/can/m_can/m_can_pci.c | 4 +- drivers/net/can/m_can/m_can_platform.c | 4 +- drivers/net/can/m_can/tcan4x5x-core.c | 4 +- 9 files changed, 144 insertions(+), 9 deletions(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 Best regards,