mbox series

[0/2] arm64: Speed up CRC-32 using PMULL instructions

Message ID 20241015104138.2875879-4-ardb+git@google.com (mailing list archive)
Headers show
Series arm64: Speed up CRC-32 using PMULL instructions | expand

Message

Ard Biesheuvel Oct. 15, 2024, 10:41 a.m. UTC 
From: Ard Biesheuvel <ardb@kernel.org>

The CRC-32 code is library code, and is not part of the crypto
subsystem. This means that callers may not generally be aware of the
kind of implementation that backs it, and so we've refrained from using
FP/SIMD code in the past, as it disables preemption, and this may incur
scheduling latencies that the caller did not anticipate.

This was solved a while ago, and on arm64, kernel mode FP/SIMD no longer
disables preemption.

This means we can happily use PMULL instructions in the CRC-32 library
code, which permits an optimization to be implemented that results in a
speedup of 2 - 2.8x for inputs >1k in size (on Apple M2)

Patch #1 implements some prepwork to handle the scalar CRC-32
alternatives patching in C code.

Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Kees Cook <kees@kernel.org>

Ard Biesheuvel (2):
  arm64/lib: Handle CRC-32 alternative in C code
  arm64/crc32: Implement 4-way interleave using PMULL

 arch/arm64/lib/Makefile      |   2 +-
 arch/arm64/lib/crc32-glue.c  |  70 ++++++
 arch/arm64/lib/crc32-pmull.S | 240 ++++++++++++++++++++
 arch/arm64/lib/crc32.S       |  21 +-
 4 files changed, 317 insertions(+), 16 deletions(-)
 create mode 100644 arch/arm64/lib/crc32-glue.c
 create mode 100644 arch/arm64/lib/crc32-pmull.S