From patchwork Fri Oct 18 20:53:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jitendra Vegiraju X-Patchwork-Id: 13842422 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED174D3F29B for ; Fri, 18 Oct 2024 21:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=pF20DeZYC5YMsxvCcTAKvVS9o5mkYpCY20T2qi822Cs=; b=eLjBeaiF4EHyAPKkG+bgssHE0K rXwcXladukBneqKfquMElq5oPZ6aBGbZumyFUdjYTQI1iv7k81RfSyKUUbHdNJ7IZYTxp2Re8nBZP QFG48gJxulkFiTxNU+jWZsjrZJWYjFVgF0KeVN1bhYX/BlH35BTrcG607RxsJixPF9+uktdtqlYyA tKeNEjarCKkj5oWGZ/cfPxcW4KE/pyLN+xKpRfBkixWaURFbC+tyWp50SdYD4SbMQCxdphMfEO1YN +6rGWQLbyorHvMU0dO1qJ4u7PJiRx+zJGoxTA7/FkRziR7/9c0iVkqJ+Px/d+Q6Kgn63cHEbOuXEC wjyfj7eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1u5t-000000022In-4ATs; Fri, 18 Oct 2024 21:01:09 +0000 Received: from relay.smtp-ext.broadcom.com ([192.19.144.207]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1tyf-000000021EU-16nu for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 20:53:45 +0000 Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id BA48CC003AD0; Fri, 18 Oct 2024 13:53:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com BA48CC003AD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1729284816; bh=E32FNLwNzXYMQ3dmaZfd1kvawf2GCQDTG/nAJ32na8Y=; h=From:To:Cc:Subject:Date:From; b=G2nLdEvungefKYlYXOKwOHxCESGaGntxOj88OSeI8oaPtf85XN6VP4KruSAd38Bc0 i2nydnjmlXh88DhMrAEk00YkICn/kaG2Sih56WrRy7woLO9Tli2Rng1oEPjcIqWLGd z3YVor/GtKVDVOMDTxD36tFxkR+n7dnF0RsDxWMY= Received: from pcie-dev03.dhcp.broadcom.net (pcie-dev03.dhcp.broadcom.net [10.59.171.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id 17D4D18041CAC6; Fri, 18 Oct 2024 13:53:36 -0700 (PDT) From: jitendra.vegiraju@broadcom.com To: netdev@vger.kernel.org Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, jitendra.vegiraju@broadcom.com, bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, fancer.lancer@gmail.com, rmk+kernel@armlinux.org.uk, ahalaney@redhat.com, xiaolei.wang@windriver.com, rohan.g.thomas@intel.com, Jianheng.Zhang@synopsys.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, andrew@lunn.ch, linux@armlinux.org.uk, horms@kernel.org, florian.fainelli@broadcom.com, quic_abchauha@quicinc.com Subject: [PATCH net-next v6 0/5] net: stmmac: Add PCI driver support for BCM8958x Date: Fri, 18 Oct 2024 13:53:27 -0700 Message-Id: <20241018205332.525595-1-jitendra.vegiraju@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_135341_561436_27BD9F76 X-CRM114-Status: GOOD ( 22.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jitendra Vegiraju This patchset adds basic PCI ethernet device driver support for Broadcom BCM8958x Automotive Ethernet switch SoC devices. This SoC device has PCIe ethernet MAC attached to an integrated ethernet switch using XGMII interface. The PCIe ethernet controller is presented to the Linux host as PCI network device. The following block diagram gives an overview of the application. +=================================+ | Host CPU/Linux | +=================================+ || PCIe || +==========================================+ | +--------------+ | | | PCIE Endpoint| | | | Ethernet | | | | Controller | | | | DMA | | | +--------------+ | | | MAC | BCM8958X | | +--------------+ SoC | | || XGMII | | || | | +--------------+ | | | Ethernet | | | | switch | | | +--------------+ | | || || || || | +==========================================+ || || || || More external interfaces The MAC block on BCM8958x is based on Synopsis XGMAC 4.00a core. This MAC IP introduces new DMA architecture called Hyper-DMA for virtualization scalability. Driver functionality specific to new MAC (DW25GMAC) is implemented in new file dw25gmac.c. Management of integrated ethernet switch on this SoC is not handled by the PCIe interface. This SoC device has PCIe ethernet MAC directly attached to an integrated ethernet switch using XGMII interface. v5->v6: Change summary to address comments/suggestions by Serge Semin. Patch1: Removed the comlexity of hdma mapping in previous patch series and use static DMA mapping. Renamed plat_stmmacenet_data::snps_dev_id as dev_id and moved to the beginning of the struct. Patch2: Added dw25gmac_get_hw_feature() for dw25gmac. Use static one-to-one VDMA-TC-PDMA mapping. Patch4: Remove usage of plat_stmmacenet_data::msi_*_vec variables for interrupt vector initialization. Change phy_interface type to XGMII. Cleanup unused macros. v4->v5: Summary of changes in this patch series: As suggested by Serge Semin, defined common setup function for dw25gmac. To accommodate early adopter DW25GMAC used in BCM8958x device, provide a mechanism to override snps_id and snps_dev_id used for driver entry matching in hwif.c Patch1: Added plat_stmmacenet_data::snps_id,snps_dev_id fields - Serge Semin Patch2: Define common setup function for dw25gmac_setup() - Serge Semin Support DW25GMAC IPs with varying VDMA/PDMA count - Abhishek Chauhan Allocate and initialize hdma mapping configuration data dynamically based on device's VDMA/PDMA feature capabilities in dw25gmac_setup(). Spelling errors in commit log, lower case 0x for hex -Amit Singh Tomar Patch3: Glue support in hwif.c for DW25GMAC in hwif.c - Serge Semin Provide an option to override snps_id and snps_dev_id when the device reports version info not conformant with driver's expectations as is the case with BCM8958x device. - Serge Semin Patch4: Remove setup function in the glue driver - Serge Semin Remove unnecessary calls pci_enable_device() and pci_set_master() in dwxgmac_brcm_pci_resume() - Jakub Kicinski Merge variable definitions to single line - Amit Singh Tomar https://lore.kernel.org/netdev/20240904054815.1341712-1-jitendra.vegiraju@broadcom.com/ v3->v4: Based on Serge's questions, received a confirmation from Synopsys that the MAC IP is indeed the new 25GMAC design. Renamed all references of XGMAC4 to 25GMAC. The patch series is rearranged slightly as follows. Patch1 (new): Define HDMA mapping data structure in kernel's stmmac.h Patch2 (v3 Patch1): Adds dma_ops for dw25gmac in stmmac core Renamed new files dwxgmac4.* to dw25gmac.* - Serge Semin Defined new Synopsis version and device id macros for DW25GMAC. Converted bit operations to FIELD_PREP macros - Russell King Moved hwif.h to this patch, Sparse flagged warning - Simon Horman Defined macros for hardcoded values TDPS etc - Serge Semin Read number of PDMAs/VDMAs from hardware - Serge Semin Patch3 (v3 Patch2): Hooks in hardware interface handling for dw25gmac Resolved user_version quirks questions - Serge, Russell, Andrew Added new stmmac_hw entry for DW25GMAC. - Serge Added logic to override synopsis_dev_id by glue driver. Patch4 (v3 Patch3): Adds PCI driver for BCM8958x device Define bitmmap macros for hardcoded values - Andrew Lunn Added per device software node - Andrew Lunn Patch5(new/split): Adds BCM8958x driver to build system https://lore.kernel.org/netdev/20240814221818.2612484-1-jitendra.vegiraju@broadcom.com/ v2->v3: Addressed v2 comments from Andrew, Jakub, Russel and Simon. Based on suggestion by Russel and Andrew, added software node to create phylink in fixed-link mode. Moved dwxgmac4 specific functions to new files dwxgmac4.c and dwxgmac4.h in stmmac core module. Reorganized the code to use the existing glue logic support for xgmac in hwif.c and override ops functions for dwxgmac4 specific functions. The patch is split into three parts. Patch#1 Adds dma_ops for dwxgmac4 in stmmac core Patch#2 Hooks in the hardware interface handling for dwxgmac4 Patch#3 Adds PCI driver for BCM8958x device https://lore.kernel.org/netdev/20240802031822.1862030-1-jitendra.vegiraju@broadcom.com/ v1->v2: Minor fixes to address coding style issues. Sent v2 too soon by mistake, without waiting for review comments. Received feedback on this version. https://lore.kernel.org/netdev/20240511015924.41457-1-jitendra.vegiraju@broadcom.com/ v1: https://lore.kernel.org/netdev/20240510000331.154486-1-jitendra.vegiraju@broadcom.com/ Jitendra Vegiraju (5): Add snps_id, dev_id to struct plat_stmmacenet_data Add basic dw25gmac support in stmmac core Integrate dw25gmac into stmmac hwif handling Add PCI driver support for BCM8958x Add BCM8958x driver to build system MAINTAINERS | 8 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 + drivers/net/ethernet/stmicro/stmmac/Makefile | 3 +- drivers/net/ethernet/stmicro/stmmac/common.h | 4 + .../net/ethernet/stmicro/stmmac/dw25gmac.c | 161 ++++++ .../net/ethernet/stmicro/stmmac/dw25gmac.h | 92 ++++ .../net/ethernet/stmicro/stmmac/dwmac-brcm.c | 478 ++++++++++++++++++ .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 1 + .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 42 ++ .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 52 ++ drivers/net/ethernet/stmicro/stmmac/hwif.c | 26 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 1 + .../net/ethernet/stmicro/stmmac/stmmac_main.c | 26 + include/linux/stmmac.h | 2 + 14 files changed, 905 insertions(+), 2 deletions(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/dw25gmac.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/dw25gmac.h create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c